Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221019062347.3756071-1-ruanjinjie@huawei.com> <8eb93fb6-a1c4-5ef4-f549-8649bb36e59a@amd.com>
In-Reply-To: <8eb93fb6-a1c4-5ef4-f549-8649bb36e59a@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 20 Oct 2022 09:12:36 -0400
Message-ID: <CADnq5_Phr_g-LZtqc2sojEqxyoqWLuo7RhFHHyC2wQsEVRBEiQ@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     ruanjinjie <ruanjinjie@huawei.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, jiapeng.chong@linux.alibaba.com,
        hanyihao@vivo.com, aurabindo.pillai@amd.com, Martin.Leung@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Oct 19, 2022 at 9:28 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2022-10-19 02:23, ruanjinjie wrote:
> > The symbol is not used outside of the file, so mark it static.
> >
> > Fixes the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
> > symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
> >
> > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > index 4edd0655965b..206a5ddbaf6d 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
> >       return true;
> >  }
> >
> > -const struct mpc_funcs dcn32_mpc_funcs = {
> > +static const struct mpc_funcs dcn32_mpc_funcs = {
> >       .read_mpcc_state = mpc1_read_mpcc_state,
> >       .insert_plane = mpc1_insert_plane,
> >       .remove_mpcc = mpc1_remove_mpcc,
>