Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexandru Tachici <alexandru.tachici@analog.com>
To:     <linux@armlinux.org.uk>
CC:     <alexandru.tachici@analog.com>, <andrew@lunn.ch>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <lennart@lfdomain.com>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [net v2 1/1] net: ethernet: adi: adin1110: Fix notifiers
Date:   Thu, 20 Oct 2022 16:08:50 +0300
Message-ID: <20221020130850.18780-1-alexandru.tachici@analog.com>
In-Reply-To: <Y1EwzRa3SNpA0++W@shell.armlinux.org.uk>
References: <Y1EwzRa3SNpA0++W@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
Precedence: bulk

> > +
> > +	err = adin1110_setup_notifiers();
> > +	if (err) {
> > +		spi_unregister_driver(&adin1110_driver);
> > +		return err;
> > +	}
>
> And you setup the notifier after, so there is a window when
> notifications could be lost. Is this safe?

At boot time this should be ok. If the module is inserted and then user starts
bridging/bonding etc. will lose some events. Will move notifiers registration
before registering device. Should be fine as the driver checks in all callbacks
if it is meant for him or not the event.

Thanks,
Alexandru