Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221019063115.3757510-1-ruanjinjie@huawei.com> <faaae681-65b7-0cc5-d413-b8995978d2c5@amd.com>
In-Reply-To: <faaae681-65b7-0cc5-d413-b8995978d2c5@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 20 Oct 2022 09:11:38 -0400
Message-ID: <CADnq5_MX4irT51Th6OaQNONohxO85wyf5g5YLX73jOxTyJVetw@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     ruanjinjie <ruanjinjie@huawei.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, jiapeng.chong@linux.alibaba.com,
        aurabindo.pillai@amd.com, isabbasso@riseup.net,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Oct 19, 2022 at 9:27 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-10-19 02:31, ruanjinjie wrote:
> > The symbol is not used outside of the file, so mark it static.
> >
> > Fixes the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> > warning: symbol 'dcn32_mmhubbub_funcs' was
> > not declared. Should it be static?
> >
> > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > index 41b0baf8e183..c3b089ba511a 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
> >       REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE,  params->arbitration_slice);
> >  }
> >
> > -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> > +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> >       .warmup_mcif            = mmhubbub32_warmup_mcif,
> >       .enable_mcif            = mmhubbub2_enable_mcif,
> >       .disable_mcif           = mmhubbub2_disable_mcif,
>