Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp954831rwi; Thu, 20 Oct 2022 07:09:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4c1UJsQa6tThdIUwfCI909Txk71Uiap1WfZ2FCXxY4TeQUFosnoI5Pdmiv088QlHWkuCUv X-Received: by 2002:a17:906:d550:b0:78d:a6d4:c18f with SMTP id cr16-20020a170906d55000b0078da6d4c18fmr11275773ejc.113.1666274965432; Thu, 20 Oct 2022 07:09:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666274965; cv=none; d=google.com; s=arc-20160816; b=GxipD56U6tXdae99vURpqFA38DlId+7mWOFSHuYoB0thYklY2OH8XoqkzRvmFgCf6F lQ4pUbOUQaYimlm2RQRwOmF7qrvVUGXQo9CudH+fmICBcbBMGlRiikDyCCmcGautSJn0 AijSPFXyZfJiik1maHZc2XQiJw5dVjqQQiTdSW0tzKOvILR/2gYFCweTlxBLfq77gsE1 eHnrinD0Z/gbyA0gqCkLagCe8kC/97EE8CY7WHR7eD13mdfYcWaHDKTpEwg01N529Im6 PwJ+xkmHCNdobIyanMGGX9qS2ArOAi+kdLbiPtCOxvE6gFqxhlRdJcKywa8W56JmDuyl IYyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IvSt6EBzxkvQdHc3Jc41I8ETjsWrOT0sld1mY/Xf6wA=; b=LyF/AHJQs7Vhx4KjlUewxBv5iR3YfBqhT/853/L7cImNVCehPVLrjMiOq/9E7m7goh Y0L04HSCdLewHacdbbPeQbaaPU3w4Fj8Ql71kVoiv9AEKi1QHNg5TD249IItwH+hw8ed WzRUBaAedpS8ux2kfrFzhmR2zB+fhdkSXmQDmUNM4Ms/f7wuhRvHAXCSim+G3zIB4Tx4 V0AvGxbTklsPJ9VAGP9E62yYQNBJQQ0CZAEkr85dOcD/num+BcwM2bTyzqECTpf5U4sw uuyyOGOSFNYPwHtBqs2EFVB1kZo3XoXYX/IyeBgjdUWIR1zqPICSjbECuY3TZHGa9ljz OJlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hQ9zEkIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn42-20020a1709070d2a00b0078d0f88a6e9si17105294ejc.284.2022.10.20.07.08.58; Thu, 20 Oct 2022 07:09:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hQ9zEkIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229898AbiJTNvM (ORCPT + 99 others); Thu, 20 Oct 2022 09:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiJTNvJ (ORCPT ); Thu, 20 Oct 2022 09:51:09 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19F72181D81; Thu, 20 Oct 2022 06:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666273865; x=1697809865; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RLLFKLdR8QHeqJ8ykIP9osVfd7AvWCqdb2p3WTU8Lqs=; b=hQ9zEkIZVCwNiaPW37LG0NLo1nLXql1raxN1PgsjoYwxbH4dH3SB0D3h QPT+MCnoh7u9ZZ/V50+JyyaNCqwIq4eo3oa2CsXHPO3FVw6BDzoufPj82 all6Gjk/0dRfmex9Yhjda1mlms9IWhgsSJEQDU2bU+CGg3gEF9SceUcxx pO7Luh5V7//V4cIT5LgAsMYMLDUMkb9UAWBB/nlXuLJBCUoCDIwsjbbsV 4pS+LLGRMZaO5eJrgoCS6eS9Nh69bh/gpKR+tdayuIkfgfi9u3Bc2GXyh cs/RxkLAvJLCbMPd33mQcVqWvAHG1eu4OEJ1Lm5KVsPcAEMIWMZFXPnRZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="290017264" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="290017264" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 06:51:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="719070007" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="719070007" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2022 06:51:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1olVwq-00AZVW-2M; Thu, 20 Oct 2022 16:51:00 +0300 Date: Thu, 20 Oct 2022 16:51:00 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Xiang Yang , mika.westerberg@linux.intel.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources Message-ID: References: <20221020014426.188667-1-xiangyang3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote: > On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang wrote: > > > > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly. > > > > Signed-off-by: Xiang Yang > > --- > > drivers/gpio/gpiolib-acpi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > > index a7d2358736fe..064ba5150fd4 100644 > > --- a/drivers/gpio/gpiolib-acpi.c > > +++ b/drivers/gpio/gpiolib-acpi.c > > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) > > if (ACPI_FAILURE(status)) > > return; > > > > - acpi_walk_resources(handle, "_AEI", > > + acpi_walk_resources(handle, METHOD_NAME__AEI, > > acpi_gpiochip_alloc_event, acpi_gpio); > > This line dates back to 2018 so why -next in your PATCH tag? This means "for Linux next cycle". It has roots in the net subsystem where it's a requirement to mark each patch either net or net-next, because they have a huge traffic of patches. > That being said - patch applied (unless Andy wants to take it directly). I think I will take it. Care to provide your tag? -- With Best Regards, Andy Shevchenko