Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 21:05:26 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Dan Li <ashimida@linux.alibaba.com>
Cc:     masahiroy@kernel.org, michal.lkml@markovi.net,
        ndesaulniers@google.com, corbet@lwn.net,
        linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Nicolas Schier <n.schier@avm.de>
Subject: Re: [RFC] Documentation: kbuild: Add description of git for
 reproducible builds
Message-ID: <Y1FVphEyu23U0jho@debian.me>
References: <20221020103823.31001-1-ashimida@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="89DQWfDuiNa8StyZ"
Content-Disposition: inline
In-Reply-To: <20221020103823.31001-1-ashimida@linux.alibaba.com>
Precedence: bulk


--89DQWfDuiNa8StyZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 20, 2022 at 03:38:23AM -0700, Dan Li wrote:
> diff --git a/Documentation/kbuild/reproducible-builds.rst b/Documentation=
/kbuild/reproducible-builds.rst
> index 071f0151a7a4..13397f38c358 100644
> --- a/Documentation/kbuild/reproducible-builds.rst
> +++ b/Documentation/kbuild/reproducible-builds.rst
> @@ -119,6 +119,16 @@ To avoid this, you can make the vDSO different for d=
ifferent
>  kernel versions by including an arbitrary string of "salt" in it.
>  This is specified by the Kconfig symbol ``CONFIG_BUILD_SALT``.
> =20
> +Git
> +-----------------------
> +
> +Uncommitted changes or different commit ids in git can also lead
> +to different compilation results. For example, after executing
> +``git reset HEAD^``, even if the code is the same, the
> +``include/config/kernel.release`` generated during compilation
> +will be different, which will eventually lead to binary differences.
> +See ``scripts/setlocalversion`` for details.
> +

Briefly read the script, I don't see what the correlation between git
reset with LOCALVERSION thing is. Also, does the exact state of git
repository required for reproducible builds?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--89DQWfDuiNa8StyZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1FVoAAKCRD2uYlJVVFO
ozlaAQCo9yDyW0/QdCKZ+rcNre9GZXMODpqNx+M21L/EvoDWjgEAuj/Lej+0YXPE
aj/+dQET+5XQQO/JuZCJ7df9U2AClgg=
=XenK
-----END PGP SIGNATURE-----

--89DQWfDuiNa8StyZ--