Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1070097rwi; Thu, 20 Oct 2022 08:19:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5F8NZQGJLXThafAp0UUgyw5/9lrovE0DBhj2aS7YFC3OOPeDGNA1y4jxXUuIQ+kjoP8KQT X-Received: by 2002:a17:906:9be9:b0:78d:2f63:10dd with SMTP id de41-20020a1709069be900b0078d2f6310ddmr11378058ejc.479.1666279140735; Thu, 20 Oct 2022 08:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666279140; cv=none; d=google.com; s=arc-20160816; b=WAwztl5ZbuxQJCjrem5XTAdRLzsSZlpNSCHsq3qLD6Pf1ktnLb/iG0UScGPxN7OUXL m/qNEiNYd0Uwv8io6TaaG/MADaq2NSIf0Jw59szMnMipe2jrnrAr6PQV9mstwwGPO6Qo yOfnnykOKqQ1W6qnpLUOgSf1mGqQcr021PMZYtQ9Lro+JHVoWDkXGZ7MXZkwt5QoiqP0 Ki++sk8wmvhXcnHgwm2n8TzQB7v4VUgut92Nlw4d35FwRWhikCP/Qysru+UyOCrGQo8u g9c1A4e6XYVJrmAuoPl0WLBku9lfk9T+yFAG6LcF2avlSLNpZDLP6FjMrchok3YX5lGB k8Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fEnzvgcsJeNbZprUh21cKq/9USyvXftXBPCl1AVe/Jk=; b=cC0DvzGc/Nm6C8KTON22+hT1ZHk2rngc6xHU4aN+HcIDGevPH0UWgRww47U4dts2er Lb8z0vMddiCfhmX5oT6F7ZMtuBo5k6Hg38D0C+fSNf/6xHMIMtPQmpNAqQAXcA0C7++C hV/V/podom30PIJCg+BRuikfQzh89skllCWJx1Les3JE0uzzEL1chuMRjSMEM8Ir/qjo rHsnG6+ePb0Z2Vh0YrbIAtJ7nz9efGfK8YbCsj/Koz1GKt6vCnzmUm0bdfiplsRu6sGv kCx81TlEgY/zxzyrfK/OdCM8AHQyjzcJGSZPscuoBGHQ2NPtdzrZ281pRKFfqnmT3zxs 7SCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=gHxB2v0T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr22-20020a1709073f9600b007830e41ed56si19160053ejc.431.2022.10.20.08.18.29; Thu, 20 Oct 2022 08:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=gHxB2v0T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbiJTPPn (ORCPT + 99 others); Thu, 20 Oct 2022 11:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbiJTPPc (ORCPT ); Thu, 20 Oct 2022 11:15:32 -0400 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C68E6B03DA for ; Thu, 20 Oct 2022 08:15:27 -0700 (PDT) Received: (wp-smtpd smtp.wp.pl 4459 invoked from network); 20 Oct 2022 17:15:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1666278923; bh=fEnzvgcsJeNbZprUh21cKq/9USyvXftXBPCl1AVe/Jk=; h=From:To:Cc:Subject; b=gHxB2v0TC5KTHeARoHbdR1J9nsxImZ+simA4h1p7+eLoRpQKxKuoawwD4XEN08PCR DM2JjkyX4mucggCkalp1oQJeaak7lwkNhpqQ7m4P4ZeWTFcLgJHoq100/OToqXp+XG X74WiqsM0cEA+P2PFXiAum2TuQSLfjz93fPY4BPg= Received: from 89-64-7-202.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.7.202]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 20 Oct 2022 17:15:23 +0200 Date: Thu, 20 Oct 2022 17:15:22 +0200 From: Stanislaw Gruszka To: "Colin King (gmail)" Cc: Tomislav =?utf-8?Q?Po=C5=BEega?= , Helmut Schaa , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: wifi: rt2x00: add TX LOFT calibration for MT7620 Message-ID: <20221020151522.GA99236@wp.pl> References: <01410678-ab7d-1733-8d5a-e06d1a4b6c9e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01410678-ab7d-1733-8d5a-e06d1a4b6c9e@gmail.com> X-WP-MailID: 78bdfce7f51fbd7d7bf58efa97131f14 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [0SM0] X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 02:45:22PM +0100, Colin King (gmail) wrote: > I noticed a signed / unsigned comparison warning when building linux-next > with clang. I believe it was introduced in the following commit: > > commit dab902fe1d29dc0fa1dccc8d13dc89ffbf633881 > Author: Tomislav Požega > Date: Sat Sep 17 21:28:43 2022 +0100 > > wifi: rt2x00: add TX LOFT calibration for MT7620 > > > The warning is as follows: > > drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9472:15: warning: result of > comparison of constant -7 with expression of type 'char' is always false > [-Wtautological-constant-out-of-range-compare] > gerr = (gerr < -0x07) ? -0x07 : (gerr > 0x05) ? 0x05 : gerr; This was very currently addressed: https://lore.kernel.org/linux-wireless/20221019155541.3410813-1-Jason@zx2c4.com/ Regards Stanislaw