Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 11:43:48 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     chensong <chensong_2000@189.cn>
Cc:     mingo@redhat.com, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org, xiehuan09@gmail.com
Subject: Re: [PATCH] trace/ring_buffer: remove unused arguments
Message-ID: <20221020114348.40fe9644@gandalf.local.home>
In-Reply-To: <e3547bc8-3acf-187c-1671-f5274112d01c@189.cn>
References: <1666274811-24138-1-git-send-email-chensong_2000@189.cn>
        <20221020101549.06e3fa5b@gandalf.local.home>
        <e3547bc8-3acf-187c-1671-f5274112d01c@189.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 20 Oct 2022 23:25:56 +0800
chensong <chensong_2000@189.cn> wrote:

> > I guess this doesn't hurt.
> 
> I was reading __kprobe_trace_func, store_trace_args stores args in 
> fbuffer.entry,which is event->array, but at the end, rb_commit uses 
> fbuffer.buffer instead of event.
> 
> Then i thought, if it's useless, why not just clean it up.


I meant your change probably doesn't hurt.

-- Steve