Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1174597rwi; Thu, 20 Oct 2022 09:26:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6/+r8Lu36sPqqO76n4AqlApI7bB+1ki5fshCnbvUxTUXyZhZ2Drk1Jx6n+tZenfQMWjk15 X-Received: by 2002:a17:902:e5c3:b0:185:5100:26f3 with SMTP id u3-20020a170902e5c300b00185510026f3mr15039336plf.73.1666283209130; Thu, 20 Oct 2022 09:26:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666283209; cv=none; d=google.com; s=arc-20160816; b=mTTVdOgxzFfp2PhzaGz6CER9mqCsMXWMMDeMEZsMXiTi/8+iLmedhSC843EDfpJCw9 gjV/ylI84oC8eBkWwlsxq5nX407F33Qh2fwPjunDHGhraUAdMoQi9rbwjvKQfUoMCcGG Tb8TJ6xK7x/0ubk4CFZ9ix0zh9++RRuGjRyNMRhhUXe5dmb3wGbLB9vaGW7sEwNJ+UrS LI55/BaA7HXBEeH/XHyte2Pxn2qVrGUIsMt7ScRn1vjX1JW1xVNbESDJfAE7ywM5UjbD nMf3Vhse4fOJ71naAnJRA8w/AQpccY/91/vrwXqv3R1co55T+K7ZgH+xTLiFypjr8xyy Ov5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iDGNVxNBG5DnP2O72JRwhZ79bFRdgRafb7U2+dHA6NI=; b=XFpLFiSoN9x367DUUO68Myzfzgn6gvNWWuMaIFCyiQ0g1jWm31NdxTVC2XmvS1o+MU 6v8sYsYwkLzzAasffwVgGGldrTgOTAAkadWRUeHnoMDZL5D5Lu6/EE7IrC9C6GHFhxxS 718M7Ld56UTnW2JAIVHaYe2If7sBPb/4/3noiHz58KMWKtTt80j8VU7Mx0Vo8ka/F5Sb eURBVaQ8Enp/dnemdJhJXOd1J3lnuPjHLcl6KnZrSsLggpqAKPhYTnIAMXOK+U587bnW dBeOHWyLxnrqZX6BygFmjw/GfB+j/mQtUpBwcvLA2F+1e6fJs+9AfdUPLx1WX2FmUhF9 zUTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=HQx6beIG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bj14-20020a056a02018e00b0045a43a568casi24060211pgb.717.2022.10.20.09.26.32; Thu, 20 Oct 2022 09:26:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=HQx6beIG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiJTOxM (ORCPT + 99 others); Thu, 20 Oct 2022 10:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbiJTOxK (ORCPT ); Thu, 20 Oct 2022 10:53:10 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 052EDAA3F7 for ; Thu, 20 Oct 2022 07:53:08 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id 13so128636ejn.3 for ; Thu, 20 Oct 2022 07:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iDGNVxNBG5DnP2O72JRwhZ79bFRdgRafb7U2+dHA6NI=; b=HQx6beIGe/7vsiKgB9fdxAVCuvcdbkQg+VQX6cKRsc+Gu2PI/mHpj5LeOPIAJXmziM +gSPF02UrS5CAMYnQTdZCGvU9PP6fjDkOTBfUlQ5yIN0VeNH2RbKyXy0un3FvjX+lHA1 o6gpyV/iQBb3aFE3FpY9lGrCvezZA0rEW+Gk+OP9jc2i7nzek1ENKKOTWwYXa0FBeaS2 DbyxcM7AIaKGFf0haYiX/biPZcdBTp+ORTfmCYyQeu6tZ/ZRziQBgp+tW1leWRQwo4DQ jhZ5azqVFMc2dtaPNro2vcAwaYNuSRvBE5cHnN/PL+CGBDY3eQHvu2UDa7KqwFLAvk0A IsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iDGNVxNBG5DnP2O72JRwhZ79bFRdgRafb7U2+dHA6NI=; b=U7xqY8JAd6b8SbkZPPSyn/vLuboOe4YhEm92kTJgJzShFQKPBN6WT6I0pa697BOYps H5JEXyNJxPVPDcoxKPUjHFYevGfXNqit4YZKgfq5jJJFy6AYhtNi3hGbV/Zw50fDeYmJ pyNHb7hSn3d+uzSd+p69VGjCbZhENjAnUdpSdp/hR8f1+W25TYpE5m2PWg7E6nYzVzN9 n+6OOckPeZkhx1FH8tqnzGyCw7Lb3OZVNrqtGpfJUfIoMixaa8Ot1+bDvBkjew7alLxY yFUv1LlobK5X/dtHUbU7MspSJNow27rvX6pBTpD6YcqU7cszKWUB0QSdmvj1oMSbslP/ dvfQ== X-Gm-Message-State: ACrzQf11c9KHpLbFMkibVPJN3IdmPgERTpvGkA8Gw2Sjo23VeWrG3FKR jiASWWCJe4FxDDv3EGUd/crLHg== X-Received: by 2002:a17:907:c78e:b0:78d:138a:ec4b with SMTP id tz14-20020a170907c78e00b0078d138aec4bmr11231917ejc.381.1666277586545; Thu, 20 Oct 2022 07:53:06 -0700 (PDT) Received: from otso.. (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id fk26-20020a056402399a00b0044dbecdcd29sm12088479edb.12.2022.10.20.07.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 07:53:06 -0700 (PDT) From: Luca Weiss To: linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Stephen Boyd , David Collins , Guru Das Srinagesh , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal/drivers/qcom/temp-alarm: fix inaccurate warning for gen2 Date: Thu, 20 Oct 2022 16:52:37 +0200 Message-Id: <20221020145237.942146-1-luca.weiss@fairphone.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On gen2 chips the stage2 threshold is not 140 degC but 125 degC. Make the warning message clearer by using this variable and also by including the temperature that was checked for. Fixes: aa92b3310c55 ("thermal/drivers/qcom-spmi-temp-alarm: Add support for GEN2 rev 1 PMIC peripherals") Signed-off-by: Luca Weiss --- drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c index be785ab37e53..ad84978109e6 100644 --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c @@ -252,7 +252,8 @@ static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip, disable_s2_shutdown = true; else dev_warn(chip->dev, - "No ADC is configured and critical temperature is above the maximum stage 2 threshold of 140 C! Configuring stage 2 shutdown at 140 C.\n"); + "No ADC is configured and critical temperature %d mC is above the maximum stage 2 threshold of %ld mC! Configuring stage 2 shutdown at %ld mC.\n", + temp, stage2_threshold_max, stage2_threshold_max); } skip: -- 2.38.1