Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1582571rwi; Thu, 20 Oct 2022 14:31:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5L+N5eOZYxLh5KdQe2SXh3uDGoHZw3Ux4/zIu/uxkNYan/9X+C84vKiiZnAOEwryNgA5f1 X-Received: by 2002:a17:907:d08:b0:72f:b107:c07a with SMTP id gn8-20020a1709070d0800b0072fb107c07amr12787263ejc.340.1666301519133; Thu, 20 Oct 2022 14:31:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666301519; cv=none; d=google.com; s=arc-20160816; b=Kk0x4PY94dc4YJ1Pe4+SeakICaVQgJInCS6uWWC0SGn4EDbyDNjc5Yps0+9LrCKhGR joSkaA+UqnlZ+DSMjFV6O/CWljGRcI5Bniq8Jx+Wwl6nQq6PPSHhXaXCy7Ou+AXXyA8+ 77+Hb6Lm4KBYj7cL8hUeCFvwq7BbvF4/QunOMZjZsCcQhkkqrMNKfRihc1Do21jMGTiP Ep3ht+6hVAMA2iZCSJO+i5x1qoTlIeD8rfJ11lZn5UF9pIwJLzSjvpI0nxLHYntpkuRc SYG0ILickG2sJNDut+SL95KoqhzL8tO/kIb5dB7LGu79Ucyo6fO009gAvvLtzY7RWEPf HNhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=zdBrEXLx5M/bkPUDgLOGUSu+ff1P96NoVrZzq25EqHk=; b=tYOan78cRK4LzTvKhvHZdRFKcwDUyD0qh2X4+L4s3yrBIb/h2oywivVX3XNKo8Gigf fkozav9PNd+7JACf2lBICKQ4WYOk3/ExT5xNP0HL4NIAC/xKaNBfq6Kzd6HpbVUi0may +k25cfroYaZVuOgSdfwxIeH6WDn2WnRG4Dg5DBnTl1ajvSpg7i2M0yOGGIz1QqxDEj7g xmAtSWK8YEL1uWK4UPDJ4ZAGCnH8OdPW3si4dD9Vc+5CPX740jElC72iibVOvfpYauD7 tNpDsBbvCi/QzFYO3mqn9n43diqnQRrHDSKYlGQrbEwzSX7bIu/Lc0aIKEu4axjU4ocs 52/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw5-20020a1709066a0500b0078df6780adfsi16509899ejc.22.2022.10.20.14.31.33; Thu, 20 Oct 2022 14:31:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbiJTV3V (ORCPT + 99 others); Thu, 20 Oct 2022 17:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbiJTV3R (ORCPT ); Thu, 20 Oct 2022 17:29:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44986229E5C; Thu, 20 Oct 2022 14:29:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C173961D32; Thu, 20 Oct 2022 21:29:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DD56C433D6; Thu, 20 Oct 2022 21:29:03 +0000 (UTC) Date: Thu, 20 Oct 2022 17:29:08 -0400 From: Steven Rostedt To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, xuqiang36@huawei.com, Sergei Shtylyov Subject: Re: [PATCH V3 06/11] tracing: Improve panic/die notifiers Message-ID: <20221020172908.25c6e3a5@gandalf.local.home> In-Reply-To: <20220819221731.480795-7-gpiccoli@igalia.com> References: <20220819221731.480795-1-gpiccoli@igalia.com> <20220819221731.480795-7-gpiccoli@igalia.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Aug 2022 19:17:26 -0300 "Guilherme G. Piccoli" wrote: > Currently the tracing dump_on_oops feature is implemented through > separate notifiers, one for die/oops and the other for panic; > given they have the same functionality, let's unify them. > > Also improve the function comment and change the priority of the > notifier to make it execute earlier, avoiding showing useless trace > data (like the callback names for the other notifiers); finally, > we also removed an unnecessary header inclusion. > > Cc: Petr Mladek > Cc: Sergei Shtylyov > Cc: Steven Rostedt > Signed-off-by: Guilherme G. Piccoli Sorry for the late reply. Acked-by: Steven Rostedt (Google) -- Steve