Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1603438rwi; Thu, 20 Oct 2022 14:54:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ngVGD2t8IS+LBJj+BDjO+sITX6cfaGu+Z2Ln+auEQcEM6s+yyek+IqOLUnDz9Zd+mIisN X-Received: by 2002:a17:902:ab0c:b0:186:5eff:c8db with SMTP id ik12-20020a170902ab0c00b001865effc8dbmr7185051plb.144.1666302898646; Thu, 20 Oct 2022 14:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666302898; cv=none; d=google.com; s=arc-20160816; b=ZjC/a6Lr4fVB5zIteE3ol+sKpXTcYRQ+JG4/BWgrcFTszlj+Py7YQulaIUee8e5HiY ZIWtZ7kALgeBK66atWvi/NJFkOrwEp1XyqLSb/23/GTahY4BfU7XPCnTAsJyhkeI5Awe XDDkHfq+jgblzgqUjEAU+cQJLzpFrjNFWedJv20omRFg2xpFNm305zq5RTQ8fEnz7olS qxwRfNHiDaghTb5DSwxgv3QY6CZbLdCoXq6ifc1MjuUTq4kd3qeCDKsqZhrTthOtFRQi l3QKat8my9qYlcER4hq6t/EslJFTjo9x1FE+L77S7hP4n2nrWClMedU1uJkV8XnVqV0E r4tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=cYh5sXG787ssP4HzSFUIAYU9ZX2XFwN1lsmR+z8QVhk=; b=kdX9uAjzvzTXze+jt8OhBUuDbEL21ShCKfQZYcKu+f5Ef38dqZvYuWYwlC75WtkC05 /jWqX/HFHlfte3GLx0iHlU+zDvMYnNr56DiLx5mKo0wtyZkcvooLC9G+pDXvTKCLSWKW id+rwDNAGip0ohaDjKSYh9HCRo+MSh8pERNKCO5fTfy6uZ0Bnn51VgAOrS5rhsjrtjVA dZ/v0Rpb7NKgHdBpX+/KmWPMU0VjPVE9oEi84kux1+krUI7NaMlpeyPLKVGXtX0+PJA0 I9B4tnxgUoPDQPAqZ6/DHvjrj0ZUgi5nshDd849q5EA1xFbPBWiyhN96ihMQujUqq2pP BFmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=GaLXFnyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a170902f68100b00179d2e2e690si27319084plg.332.2022.10.20.14.54.46; Thu, 20 Oct 2022 14:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=GaLXFnyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbiJTV1V (ORCPT + 99 others); Thu, 20 Oct 2022 17:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbiJTV1D (ORCPT ); Thu, 20 Oct 2022 17:27:03 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397F91B65DC for ; Thu, 20 Oct 2022 14:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666301176; bh=ibzGFol51WWHH1kAZe6QOOvlh+zMJhgtwaluS+pfjKo=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=GaLXFnyiaSpTngMuEfh8nxTIumTnBEP1AwbhNoBFpPg1habkNXoiGsRY8mTCI2nVP 2+Kcck/mr17SmpiLn8m9H2o3R6uspxM25bHybTaz4/CVyNeahz3I4N/YgdhbDbhd+L nlmYKQ7LH6qZepzgkVihAoUKD0iCH2mlpphZKGFg= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 23:26:16 +0200 (CEST) X-EA-Auth: JE9KFmpUaJpP3Y1Ti1VTiLP+tKc//LVPG0j41IQ1zfzKaCfv/DmG0sYiOyy2mj572pLPj8eMZc98oeUov4bPR0sZO/MrFq1u Date: Fri, 21 Oct 2022 02:56:10 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Address different kinds of checkpatch complains for the staging/r8188eu module. The patches are required to be applied in sequence. Changes in v4: 1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr 2. Update patch 1 per feedback from David.Laight@ACULAB.COM 3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr Changes in v3: 1. Patch 4: Extend the __constant_htons to htons change to other files of the driver. This was suggested by philipp.g.hortmann@gmail.com 2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com 3. Patch 5 through 10: Included in this version. Additional clean up patches. Changes in v2: I incorrectly labeled the first revision as v1 instead of v2. So, following change recorded under v1 is actually changes for v2. Feedback provided by philipp.g.hortmann@gmail.com 1. Improve language / grammar for the patch descriptions 2. Further improve code reformatting Deepak R Varma (11): staging: r8188eu: use Linux kernel variable naming convention staging: r8188eu: reformat long computation lines staging: r8188eu: remove {} for single statement blocks staging: r8188eu: use htons macro instead of __constant_htons staging: r8188eu: correct misspelled words in comments staging: r8188eu: Add space between function & macro parameters staging: r8188eu: Associate pointer symbol with parameter name staging: r8188eu: replace leading spaces by tabs staging: r8188eu: Put '{" on the symbol declaration line staging: r8188eu: Correct missing or extra space in the statements staging: r8188eu: Remove unused macros drivers/staging/r8188eu/core/rtw_br_ext.c | 119 +++++++++--------- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++--- drivers/staging/r8188eu/core/rtw_recv.c | 8 +- drivers/staging/r8188eu/core/rtw_xmit.c | 14 +-- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 16 +-- .../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +- .../staging/r8188eu/include/osdep_service.h | 4 +- .../staging/r8188eu/include/rtl8188e_hal.h | 6 +- .../staging/r8188eu/include/rtl8188e_spec.h | 18 +-- drivers/staging/r8188eu/include/rtw_cmd.h | 62 +++++---- drivers/staging/r8188eu/include/rtw_io.h | 16 +-- .../staging/r8188eu/include/rtw_ioctl_set.h | 4 +- drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++-- .../staging/r8188eu/include/rtw_mlme_ext.h | 12 +- drivers/staging/r8188eu/include/rtw_recv.h | 4 +- drivers/staging/r8188eu/include/rtw_xmit.h | 2 +- drivers/staging/r8188eu/include/wifi.h | 12 +- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- 22 files changed, 176 insertions(+), 197 deletions(-) -- 2.30.2