Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 14:59:09 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Wei Chen <harperchen1110@gmail.com>
Cc:     Vlastimil Babka <vbabka@suse.cz>,
        Matthew Wilcox <willy@infradead.org>, hughd@google.com,
        dhowells@redhat.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: kernel BUG in page_try_dup_anon_rmap
Message-ID: <Y1HErfuQox2DfwxV@monkey>
References: <CAO4mrfdLMXsao9RF4fUE8-Wfde8xmjsKrTNMNC9wjUb6JudD0g@mail.gmail.com>
 <8ef3a72d-8719-aeaf-1a03-9b7cb1a03cc4@suse.cz>
 <CAO4mrffHdnG7fEkxcoEXEhqYN8HkcY9d1-NxRvHsqf0mQN6T1w@mail.gmail.com>
 <Y1F+aRB0/ZhHIlE8@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1F+aRB0/ZhHIlE8@monkey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XM7CvRSchefoUeHZs7pg8Z0NpR18HxjzQ9Gh1AcdnPgEO/2WkXV6q54sfkad?=
 =?us-ascii?Q?d8TESHclKI50f23txgKUvZ6ZZwWmBGd5+LWsD7nggYKRdwt9hDjzTY5dCOuq?=
 =?us-ascii?Q?Sdfx+2yZDbCMx+Y3TDu8nRS9zqDZXkdY5opMzVxoDjMJTBxRVLrEWRyoWyPr?=
 =?us-ascii?Q?07N2Umv/0pY5yK/icmfHWo3kKVnNU+T9qMrpojKNj6O4pwH6NMd83KvIKWeE?=
 =?us-ascii?Q?Xuh9HvIfw2Uj/Rqkrgb6FBIeEZdLSbFt2PyNIFjnH86+/98DwX3QvsJfRLu/?=
 =?us-ascii?Q?VuJjd98vsuL7bvfxmR6xC3UOD/9Iu3eirC8juUplbmU6rCoSP7qENkGCP+2b?=
 =?us-ascii?Q?NYIjB8ncLIVmpiwgbB2AgoncTDcGPALeJBIb8LEB018EqcXM9SEbb3zayG3m?=
 =?us-ascii?Q?uqkt4zhZ2LuYxABytYVY0RDjd06mZ3t8lsVIS8ELgDphoT9w1E+xqbiuhysu?=
 =?us-ascii?Q?dx2f06Z4e3+wgWE4QXQtJr2di2+kzMz8RBKESiXBqjpEIwAvzyg/hS5w5zM2?=
 =?us-ascii?Q?cTLixRorrjn8deJmSE/AF/JYLLAifj6ZYDCKeWt5D5ulTPVMpeB9+YZjg6XG?=
 =?us-ascii?Q?NXGQq3j9bckFSPMg1j70lzyp/Ubfwix2Vm2JkTNm7WJmpUBSRq/dX6etiSFt?=
 =?us-ascii?Q?mcalCEhh36ECCjbqr/vFy6ZTJy2X+b4a9YLnAQCjj/BbtcWQh5nuTno+uHTM?=
 =?us-ascii?Q?PuOLRPHdwC5U0mYfLTMUThVwMndHsQxS/hHRiisvMlicS3Z/wUbgSs1kaBGm?=
 =?us-ascii?Q?rtnxqjRtkszI5EZYQ4+UKFygEwiiGzUVgFLM44ZctS/N2sxRXMWnBtUVUlpI?=
 =?us-ascii?Q?Lg3XrG3AVH5Tw21JY2FYo7f9V4cQ7pwKlcujAm3LGzZ9BPoSQFEPdl0culP5?=
 =?us-ascii?Q?ztJ+5KWF2M7sE45oQU8oysK6lKp8Xgi/Go+f8OZU9GufUYoewOWqgBL3a++f?=
 =?us-ascii?Q?SY+o3mMZ3Ertq4c/YFk2ZGT9ovtLpioTCCY7llwYS+izqVOMFdXAv58OSS/g?=
 =?us-ascii?Q?kVXzuralj0NEgRZ8mm4BdytFJ+31mhaBu1HnxB+DlqoPcQi69LPpP6pBpALw?=
 =?us-ascii?Q?xDH+gwtlw1p6FvjIBVYxl7QwN5bsID2mwgVP7jBLpDeZvK2TYwjfuygNxkMT?=
 =?us-ascii?Q?ZcBJ+/soENGG0QPvopme/SZxkhAPzLUOtWBwKt7DfMQi2jQUA0PQlFRw+sud?=
 =?us-ascii?Q?e2RSd/AVnStcqdpF6oPEbezcUctlqyg34JJTtOXq5YdJmR6EK+REk0u5HnLf?=
 =?us-ascii?Q?nBnBgSgbWYXXsjYjMKOE/hwoK/i8Y4N8uce1uxv7o+G4UPWnTmEv/PfBEX6R?=
 =?us-ascii?Q?LU1LFnA6yCUed5VIbCHCSRf4tJgLU0T43nFRzed18uaFQYWs+EqjYQT+MBHI?=
 =?us-ascii?Q?eWg9bb9AVn/RTyxqnqkERHH1eYFTfPhpuLqQZis5rl5nOCwUIPJRleStP5fX?=
 =?us-ascii?Q?WItgG7ghTzgDrcgqChCkibg7+xHgT1TdyFlLSbbbtxPZORt6hf/yPog5lB2N?=
 =?us-ascii?Q?+K53x1hPqecCQAOd+5SHvygIVw7W5XPFVhqVI/1Rvo+KTHBadp5edXpg4z/C?=
 =?us-ascii?Q?G01BrJetfVqg55SqIsqdKQpat7LByWlSVoo3n974cQg1PFB4fuKQqFOMHFOe?=
 =?us-ascii?Q?Pg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3fc9ac-0829-48d9-a3d5-08dab2e65210
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 21:59:12.1340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uB8hG40pJg8GFOxgNydtxE6j5v2E68lSRSXOQ1b296I6x+VcTlMPkQU42aWpob8KIqt8pOxBZdyuqLuAJS09Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4337
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_11,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=518
 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210200139
X-Proofpoint-ORIG-GUID: F99ReT9RnewnuVez2KSgDPUW0g8wEjLg
X-Proofpoint-GUID: F99ReT9RnewnuVez2KSgDPUW0g8wEjLg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/20/22 09:59, Mike Kravetz wrote:
> On 10/21/22 00:21, Wei Chen wrote:
> > Dear Vlastimil,
> > 
> > Thank you for the reply. The bug persists in v6.0. Here is the
> > information. Luckily I got C reproducer this time.
> 
> Ooh.  Looks like the reproducer is doing a MADV_DONTNEED on a hugetlb mapping.
> That support was added somewhat recently (5.18).  Not sure if it is related in
> any way.  Have not looked at the code/implementation around write_protect_seq.

I verified that the new hugetlb MADV_DONTNEED is the root cause. :(

The reproducer calls madvise(MADV_DONTNEED) on the hugetlb mapping before
mapping any pages.  madvise(MADV_DONTNEED) ends up calling:
zap_page_range
	unmap_single_vma
		__unmap_hugepage_range_final

__unmap_hugepage_range_final ends up clearing VM_MAYSHARE.  This is
because it assumes the vma is going away and wants to prevent someone from
doing PMD sharing with the vma on it's way out.  The causes confusion in
subsequent faults in the vma as sharing or private keys off VM_MAYSHARE.
We then end up with pages in the page table where page_mapping is NULL.

Somewhat good news is that I thought clearing of VM_MAYSHARE as done above
was kludgy and was able to remove it in 6.1 with the introduction of hugetlb
vma_lock for pmd sharing.  So, should not be an issue in development
branches.

I'll come up with a way to fix for 5.18 to 6.0 kernels.
-- 
Mike Kravetz