Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1691057rwi; Thu, 20 Oct 2022 16:18:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7faheqyDMG1KjrlXRmt9DHdIVLfXAi9zd3eTplpQ4Jd13uzIvYM1TgrUeRFTgTszDrR7xZ X-Received: by 2002:a17:907:7635:b0:78d:c5e9:3e57 with SMTP id jy21-20020a170907763500b0078dc5e93e57mr13123621ejc.204.1666307903188; Thu, 20 Oct 2022 16:18:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666307903; cv=none; d=google.com; s=arc-20160816; b=Ok8bZii0mXVkJnWjtes5ElRa0UAhPLTAgMG1E/QUUGrFYeG4O1n3ftt/1ynGsgnsSI wRrb/dJeTFG2dDwvAD8V738mSlgR0RjCkgTTr0SdL/iHkLh6/MgPB7Ij5uluV+s5TbXK stHvTYsGa0LFZGL575Ic+2rZfgiINYZBvEbi3KX/3foZhmVAEiagAnuqJnSF/T9eNFal XqCg4f6FGL+Y6Bqdw/EukswFcQf+VyMImN+5DY7akEz5o5T8Oq0LuyJPrbr+aWmWYOfp 4RQz002la69D+tUwUDOTuyBjx0YU0zUQec6SkR4E4TzckLHWHasndt67KbznG0tuiHhX Yfvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=L2G/9Nt1UPxsYT32uFvEw5BhWk6FA6rHpv/vvZ1BQSE=; b=Xlk1JYQozRD5t+ARlmQcfAw+bfLgWprp6K+rTf+hEYoiYVbhlGi2JL0ElUDZQdIN6M TT7PM8Z2UUlDqAU7wsu7xxs4S9UMSACs/6cf8Y4gOpCVMP6GdC0eUm2omcBcJ6O3ZoZd pEF0cRl3maVDcFWuxDtjbFYut0ZGj3ee4hkiOffqQmTrOigJTI1BpLzQc/A6hSSqOnF6 vTieswN80AYTOSPrI/9orXnEY0Qq8LFoNSAarrFYWsEzLm4sLkJ2HEetQiKALhL5azrx fTXGinvceB75itS5bXcuh8yd9wbqI1eTa6DAf+djihKSpndeXq2q7udS0aVnDn8dlrqr hmhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=L7KL7Cmq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e11-20020a056402104b00b004587cd5a5bdsi16289964edu.81.2022.10.20.16.17.57; Thu, 20 Oct 2022 16:18:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=L7KL7Cmq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiJTWw5 (ORCPT + 99 others); Thu, 20 Oct 2022 18:52:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbiJTWwz (ORCPT ); Thu, 20 Oct 2022 18:52:55 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87B2B21E109; Thu, 20 Oct 2022 15:52:53 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a26so3082704ejc.4; Thu, 20 Oct 2022 15:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L2G/9Nt1UPxsYT32uFvEw5BhWk6FA6rHpv/vvZ1BQSE=; b=L7KL7Cmq5BeuUdYGMW3cAgtIcuVZg5ASkJ/IZNJWWUiJ+/Qt6gVlScz1u/W2UurieC StTRCMiF1gayWtat9yR1jxy03jHzqPRpY+d/GgJ1K8lmNPRqj47kEmjBivrdxwcQlJRP gqfaCFKJCe0cSgQC/Xx9MVQoKg98NUMWFRqSK3/+nRYCXn1Q7yrGT4PHRNV43mZeBqb1 cVtzyuggTcE1Pu9cpikwolaS6fyiZ1HlsdnyB5HAFFtEAPY8oUGlBvmr4xSRLlq7VRIk 7rfYUfkbEQcY9aYc3JzsWSeJh1CqZ0CXrIEVX1+mmeRiMEa2Rwrz9msL2vRPepDcIKvz 1T1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L2G/9Nt1UPxsYT32uFvEw5BhWk6FA6rHpv/vvZ1BQSE=; b=dhwJv04hCIZT/VPN6Q7cb18sc6g3DaXpAxwAirdY3Jaainq3iLmmALw0QK7+W8x1Ug 1DrvGDOl5/TBlynCuatReW7AeCD14d7qdvNfJlf4WXLTRPgnUNFkhDul/7SMS62pw5zM kdJdeV/xy6blwtIxzhTswIVanGSesXNdJ7SxTBuOCzItM9Mtl2bOhHeLlcagY+q0xrAy nmtBW9KqdlFtkKXQ7GSlKkP1Bc2YWgn0yYFEqA7QxjMNZd1+UTiL8es7Q7drAR3iIzMV SRCUxBTZDQ8WU8GYRN8W+218f87nktmjZhNRUwzjmiRi/h68BdRqDe7ADhPuG8CUh3DZ 2oxQ== X-Gm-Message-State: ACrzQf0z1EcO+Ivt007VdVCWgmsCz3w8hz4dSAD8AGvIPh2oGf8zQ5KF TWGApTr4XvzhM9IHQgPp5iY= X-Received: by 2002:a17:907:9602:b0:780:8c9f:f99a with SMTP id gb2-20020a170907960200b007808c9ff99amr12947250ejc.465.1666306371826; Thu, 20 Oct 2022 15:52:51 -0700 (PDT) Received: from skbuf ([188.27.184.197]) by smtp.gmail.com with ESMTPSA id v25-20020a17090651d900b0078da24ea9c7sm10939361ejk.17.2022.10.20.15.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 15:52:51 -0700 (PDT) Date: Fri, 21 Oct 2022 01:52:47 +0300 From: Vladimir Oltean To: netdev@kapio-technology.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 05/12] net: dsa: propagate the locked flag down through the DSA layer Message-ID: <20221020225247.acy4cejhcmtmf6ua@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221020130224.6ralzvteoxfdwseb@skbuf> <715c068915c9f07ad62d9837e70df7a1@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <715c068915c9f07ad62d9837e70df7a1@kapio-technology.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 09:43:40PM +0200, netdev@kapio-technology.com wrote: > I guess you mean, why it differs from the inherit flag mask list? > > If so it is explained in the update to v7 in 00/12. The following is written there: | v7: Remove locked port and mab flags from DSA flags | inherit list as it messes with the learning | setting and those flags are not naturally meant | for enheriting, but should be set explicitly. Can you go one level deeper with the explanation? What messes with the learning setting? Why are those brport flags not naturally meant for inheriting? It's pretty hard to take your patch set seriously if you don't provide proper explanations.