Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 17:20:10 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH v2 03/12] cxl: Unify debug messages when calling
 devm_cxl_add_port()
Message-ID: <6351e5ba56f96_4da3294b1@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221018132341.76259-1-rrichter@amd.com>
 <20221018132341.76259-4-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221018132341.76259-4-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1lfZHf+Q+jkOADfWPyrKmtkM5cifzI33kE26oKPJiPy0cz1yzmy9LzTnZS22?=
 =?us-ascii?Q?jCN4cPInC9Bxf9dNqsRuQkKf9ME/4Il9s50jLOXDUBeNCM/vVSx8ZtbevCw7?=
 =?us-ascii?Q?yaBu0/Ff36iOCibBPMXu7i77eTVnYbcm4NK5/lmRBW3EOibh3rQ4IIqPuw8A?=
 =?us-ascii?Q?0s+bZU5RKJazgJHVcd3KBVv0I9IdWCOhc0DWNVd7smIpoNFCsQffwIHoIuJq?=
 =?us-ascii?Q?qNXD5JbHEp3KuWoXSIS09Qpn9nDJmt8CNr52/4O/L1HD9lGK5t7KTR/feErY?=
 =?us-ascii?Q?JYdHPfyLUUkU/pRq7uMogS5c+9wWGMhwA00PiaXMtThG5f/ZgO4RFSaOfqY+?=
 =?us-ascii?Q?zORh0VoITo7ejZb8OHwiRY/BAWDRfsM7DRfVxirQfKIg5WPJNQ+ugNNUtM4h?=
 =?us-ascii?Q?29quyyafjX2/iExZl6L8P3fXdw88LpsF5IVH0Hk8Samp3snYg3ZDAVYfduBc?=
 =?us-ascii?Q?EDm5W6iS1tC9uFlCjRUoDGTTytLV+bcmA5e6Bl+ivKXEST4LlGIQQYCyALz4?=
 =?us-ascii?Q?kZ3wiUfy9kug20RCMwyLuaq8o1v3DlJlXMOIFNPbW15OavOfnOw04U0yvvTh?=
 =?us-ascii?Q?2jFEDY5DpUxOxg1N029aIy3Ra/GdPVX7FMBZtCBnudNE18TJK3CJtAITDGBa?=
 =?us-ascii?Q?8KueiX/FNqoOTspnr6PcoDHrrDh1fRihWmXoCi5zC3L7cIeSjlUSPeN71EC3?=
 =?us-ascii?Q?IU7uIAG8u8l0aQzKT59dkwtBbZetiwOuQ/y0Q4KKtL95STtSVRUrJfJyMFRS?=
 =?us-ascii?Q?d9xWSLAwqRYErwyoxc3FjR50BQFe5atOzvp2WP46H9D1Qty7GMBn5Foa2teb?=
 =?us-ascii?Q?InA0/zttx7RLIBTH5MCNCiukXyZJFbshZqGFWJ9zMttKfRuqHZLyvkko8om7?=
 =?us-ascii?Q?3kwMhuHb9iXBwpXj8Nxvg9TTNy76ZTlL7lNtR34qbToGQw5a2B3KxI4WEddX?=
 =?us-ascii?Q?Ocq3Bjy/AtkCjarF4ZAaqYfLd0DKt3qd0rtNruw6yI8EeSJeQoESZsl6fi9H?=
 =?us-ascii?Q?OeVJQdc8jN/0t8HO0G/XoxwBaFJUZXnSXSlZ7aCH95yE0XEU4TwMfBEowSKb?=
 =?us-ascii?Q?0dl3lg+QVfGMjnmVnWY3eDmGfxUP04Da2orFJCgfbsxGS4Ro+yihbL83RZcX?=
 =?us-ascii?Q?a1JqpfR6dRlSGSEFBzbF5USV2L5DzRdGdut/MtsqBtyWJpe+YmHPUGckBSV5?=
 =?us-ascii?Q?kPDEKZms+Vbf7boSO6JjpFsH4NQ58YIDOF7Y46ClUkXN3J90KUr+H53SZVcK?=
 =?us-ascii?Q?bU8r7Xx6LltsQG52tJqe5kh+lgmvQmKIcF1WF/jGqlD0DWRFIGeYte+NKhsX?=
 =?us-ascii?Q?P+XnEyBq93RmkxjKAXl7E8PkV/dyMXgPmOs9vfP9p+lAwCTfgzjGApNQc5bR?=
 =?us-ascii?Q?QK61PkNMFJoihVTVt0yGNje4KtX4hOjWqZU8qh7nIHv7iw05DLcwkCXE0oj9?=
 =?us-ascii?Q?16wIFzMFemFGl8Ydst7nR4HC99FG9/tY0/hXQct4ICqw8gLFFC3nTg+Q5cGS?=
 =?us-ascii?Q?zLE/7N/6UtLbqF+8IphA1klCc+k3MGB4hncbhKSadXtX7mrkTHYgZDYBD6La?=
 =?us-ascii?Q?aeN7OOFrvUn1ehfzYEEFhFam+BQPCy4qEs1+HBGSm0UsP2OjcudFjk69s0Bg?=
 =?us-ascii?Q?gQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9479143-a454-4262-c32c-08dab2fa0569
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 00:20:14.0137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3hVs0yHpyaV+Tbo6dKMZ0A6LIJwzWfRUR4NHzbQwF7A8lF9EXkzOa/3nDn/qCWzaO2ikR1k4Y8qKvU8tClAZ2E2yYEUSxwln3iPT+ID7B2U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5106
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> CXL ports are added in a couple of code paths using devm_cxl_add_
> port(). Debug messages are individually generated, but are incomplete

Hmm, devm_cxl_add_port() got wrapped in a few places here. I fixed it up
locally, but maybe take a look at your word wrap to keep function
symbols unbroken in future changelogs.

> and inconsistent. Change this by moving its generation to devm_cxl_
> add_port(). This unifies the messages and reduces code duplication.
> Also, generate messages on failure. Use a __devm_cxl_add_port()
> wrapper to keep the readability of the error exits.

Otherwise looks good, applied for v6.2.