Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 17:32:58 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH v2 04/12] cxl: Unify debug messages when calling
 devm_cxl_add_dport()
Message-ID: <6351e8bac4623_4da3294d0@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221018132341.76259-1-rrichter@amd.com>
 <20221018132341.76259-5-rrichter@amd.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221018132341.76259-5-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXRKODduUEp3K3Z1UzNETHVMSnFPL2hhMFhXeXlxY09UUEIwNWViL3lkWE9P?=
 =?utf-8?B?eCtDY01paUV1VHpFdVZmM3lIOHFJRDR1OHE1ZG5vNmovUUNobXdha0JtREdE?=
 =?utf-8?B?ckVtb2VLZURVODQ5OUdRMUdlVWVBdTVncE15Y2FtSWZRUlIzUjlmVEtraXU0?=
 =?utf-8?B?NVp5a01NZzZyY2ZCRlBMSzFQaERuQnIxdFNyU2ZuN3R1OVd2ZHE3aEZxdWF6?=
 =?utf-8?B?VzV1WTYxS1YzbG9GL2o4U3VjSmV4d0JIcFN4b05WMUFNanR6Wnk0WUlLOVdD?=
 =?utf-8?B?bXFUaWRZQ0w4NUlXM1BqWGs4Ky9hVmI0TnpVam1uT1dYQW56VWQyQkpNMzQw?=
 =?utf-8?B?a3lHMzBMc08wYkRqL252UlJ6K2ppWFpSZ2pkM1F5aFVHTi9mNWszeE1UZzhM?=
 =?utf-8?B?OTdmY1R3NTVlQVcyUm1vTG9nbFJWaCt1Mys2WjJJL2RhekxFZTFONHQyS2Zz?=
 =?utf-8?B?N3ZCSm04Y0dFOEtGTU9LbFA0a1JEdk81cGEvN2lWM04zVVB2SGJ5SHk2SGx0?=
 =?utf-8?B?aEtNeTJFekliMzVXYXptT1ZNdm8wUUNpcEtFdnlqdENLOFNMK0pvM3oxV1J2?=
 =?utf-8?B?Mi9HbjN4VUtLU2Evbjh0bTlTSUgxYzJkL3pkQTBvVjZsVE14T21Tb28wSXpI?=
 =?utf-8?B?WDlPNDBCYTk0OTNyNlc3U0ZwbmFjbXBHNVJkSUQxNGFwRlJtY0p4OGZac1Ax?=
 =?utf-8?B?RzBFb0RUbVMvcXVCTm02UG1Ma3ZuRStybHdtd0lSbEsrcnc5eWlmVS9TUHM5?=
 =?utf-8?B?WDJ0aS9ua2dPRHZVVlpiTGtvdnczdlFncm0zQXNFaHdRUlpGdEgwREVacmxv?=
 =?utf-8?B?bGtZdkkwcjZBZVJVVGRoZUFrcEVUSmRmWjhmS2U4akF6elRiTTZLY29PVGhV?=
 =?utf-8?B?bnRKbDlhSm5FZmtZQ2RIVjc1VEF2NDhhck05eWJ1SWVxbFFjcHJpdHFBMWtD?=
 =?utf-8?B?WWRwcFRIT0FhMk9ERUlmTmYrYXZZbzhMQXRNRjl3eWxTRTgyQ1BpSEFPaWUx?=
 =?utf-8?B?YXEzYVpPbnJKNFdONXpVbWhrZ01ZSnAzRlJHMUtOZlFFZ2NDR1J3cCtxRVhZ?=
 =?utf-8?B?NnZna1RMZHFFa0hCM3ZsVFFYZkpqN0RLaGM2OWlTaUZJR3FGdEQrbS94Wm5n?=
 =?utf-8?B?Y3Q4djBvTFpPRFZaOUU3MCtpTFlzc1pTemFrSXp5aHFRd1N4c0hxZ0JvYURu?=
 =?utf-8?B?dzA2YlBSdVpCZWUxWnVZUlI1emlFQ201dE5Ic0k1QUxXa3pxbzdiSllOUnZX?=
 =?utf-8?B?ZktQNklFdFplSnNuWUtOSmFrcXdoQUtLa1lXcmhTRlMxMTVlcURZcXlCaURj?=
 =?utf-8?B?cU5udTNESEFtZDlGRnhWR01tbEFtWEVNOXdrbExXT05UOE1ONzV4dVBuMzUx?=
 =?utf-8?B?UmFmYTZxSU04REZQdGcwbzNacWgyVmo1RElvOUVsUnBBWTR4bFdVenE2YTZJ?=
 =?utf-8?B?WXhRV1hUQ3VzOGJOTHd6WnBzeThOQ3VPcVp3VU5ZR0RSRTRVSm5BUlA4Nit2?=
 =?utf-8?B?TzFYMkttQk5qeFljcFNMTDg4Q2cyTU80RmJ0SkFsTCttbHFiaGIrT3lVaHRO?=
 =?utf-8?B?NkUydXV0ODNRbEc0Q0U1VXNBT2xtNE9BcmgvRjFEZEpqeTFiVllyNWwyZDhr?=
 =?utf-8?B?TUdacytGNkpYNHJucytWVDVITHhCb09ZZTBmSFNKZS9Ua1JwVEEycXhaZXZ1?=
 =?utf-8?B?bmtoV0tSN3llcHphRnZ5eFRWcGdpNXBwTFc1UytROGZBK0VlWnRteDRlVW9y?=
 =?utf-8?B?M1pkSnRNTCtFbExFRldCcm1LeU9nVFRKUDJ4bnExRDhRWTJTd280NmxYUU55?=
 =?utf-8?B?cU1OOERQMHgvVXNvRzU1QXlJSTRYWk9VVGxOdnp3SEtoNG5vSjdOZ1dRMm5R?=
 =?utf-8?B?aG5KMWNobkZPa09LbmQ2Nk81YjZKeFYweDY2QytkVGNVMVpqYzlVUWJTVWVk?=
 =?utf-8?B?OTR1YVN0bHlRdU4yckVtZSsybHErTE1zaGcxbzdWMkpMWFNjSlZpOUZwRERE?=
 =?utf-8?B?TVlrcmtVRExERjNvRTQ5bktDL0lMME55M0cwWXJtc2hHeFBlemVCeFhvTHpl?=
 =?utf-8?B?VEpyWWZKT0hzSkZFRWxWcnAwcHREeWtIaUZMU0ZETDNtSEd5enMyRXRVNmx0?=
 =?utf-8?B?S2tPWnhFeWF2ZWdtZFY4Ym13QldtVytpUUNIZE9CVXBkKzFLRWdCTkNTUkpw?=
 =?utf-8?B?YWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e67c3c07-a271-489a-05f6-08dab2fbcf73
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 00:33:01.6116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4WzmUIN1Ju1AioxM1Is+QEov4j8YSDpbwzvb3iEShxF2sutAFOZ6SLAYkOYe5wRxwpwwS/t1vVpn00VIUXzAKL+tGsZlRHrnPtMzOCdiSso=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5393
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> CXL dports are added in a couple of code paths using devm_cxl_add_
> dport(). Debug messages are individually generated, but are incomplete
> and inconsistent. Change this by moving its generation to devm_cxl_
> add_dport(). This unifies the messages and reduces code duplication.
> Also, generate messages on failure. Use a __devm_cxl_add_dport()
> wrapper to keep the readability of the error exits.

Looks good, I fixed up the wrapping of devm_cxl_add_dport() and one more
fixup below, but applied for v6.2.

> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/acpi.c           |  7 ++----
>  drivers/cxl/core/pci.c       |  2 --
>  drivers/cxl/core/port.c      | 48 +++++++++++++++++++++++++-----------
>  tools/testing/cxl/test/cxl.c |  8 +-----
>  4 files changed, 37 insertions(+), 28 deletions(-)
> 
[..]
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index a072b2d3e726..c610625e8261 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -582,14 +582,8 @@ static int mock_cxl_port_enumerate_dports(struct cxl_port *port)
>  		dport = devm_cxl_add_dport(port, &pdev->dev, pdev->id,
>  					   CXL_RESOURCE_NONE);
>  
> -		if (IS_ERR(dport)) {
> -			dev_err(dev, "failed to add dport: %s (%ld)\n",
> -				dev_name(&pdev->dev), PTR_ERR(dport));
> +		if (IS_ERR(dport))
>  			return PTR_ERR(dport);
> -		}
> -
> -		dev_dbg(dev, "add dport%d: %s\n", pdev->id,
> -			dev_name(&pdev->dev));

This hunk causes this new compile error:

tools/testing/cxl/test/cxl.c: In function ‘mock_cxl_port_enumerate_dports’:
tools/testing/cxl/test/cxl.c:559:24: error: unused variable ‘dev’ [-Werror=unused-variable]
  559 |         struct device *dev = &port->dev;
      |                        ^~~
cc1: all warnings being treated as errors

I fixed it up locally, but just double check that you are building
cxl_test if you touch tools/testing/cxl/:

    make M=tools/testing/cxl