Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2458332d-5a55-a74d-d6f0-c1457fbda282@linaro.org>
Date:   Thu, 20 Oct 2022 20:57:29 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek
 RT6190 regulator
Content-Language: en-US
To:     cy_huang <u0084500@gmail.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org
Cc:     lgirdwood@gmail.com, cy_huang@richtek.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1666249033-12219-1-git-send-email-u0084500@gmail.com>
 <1666249033-12219-2-git-send-email-u0084500@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <1666249033-12219-2-git-send-email-u0084500@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/10/2022 02:57, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
> 
> Add devicetree binding for Richtek RT6190 4-Switch buckboost controller.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
>  .../regulator/richtek,rt6190-regulator.yaml        | 77 ++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt6190-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6190-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6190-regulator.yaml
> new file mode 100644
> index 00000000..be0fa7f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt6190-regulator.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/richtek,rt6190-regulator.yaml#

Filename based on compatible, so just richtek,rt6190.yaml

Unless it is a part of some MFD-like device, but then compatibles needs
fixes.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Richtek RT6190 4-Switch BuckBoost controller
> +
> +maintainers:
> +  - ChiYuan Huang <cy_huang@richtek.com>
> +
> +description: |
> +  The RT6190 is 4-Switch BuckBoost controller designed for converting input
> +  voltage to output voltage that can be equal to, higher or lower than input
> +  voltage. It operates with wide input voltage range from 4.5V to 36V, and
> +  the output voltage can be set from 3V to 36V by external FB pin. It's commonly
> +  used for the application like as BuckBoost bus upply, docking station and USB
> +  power delivery product.
> +
> +  Datasheet is available at
> +  https://www.richtek.com/assets/product_file/RT6190/DS6190-02.pdf
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - richtek,rt6190

Best regards,
Krzysztof