Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 18:00:15 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH v2 05/12] cxl/acpi: Improve debug messages in
 cxl_acpi_probe()
Message-ID: <6351ef1f70cc6_4da329414@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221018132341.76259-1-rrichter@amd.com>
 <20221018132341.76259-6-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221018132341.76259-6-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FnQefSK1z7tP7cEdHB6SyS2UiEbTIQ9jl8XidsuCAdV92bMh9PnWenzVzBrP?=
 =?us-ascii?Q?b4W7T1xMr4xi2KC3vbiMZuwxtCOuxadvgdoD4Wp9MTaUKFg7L3/Sp0muBmdR?=
 =?us-ascii?Q?+demJbPXihC4YMUeabMNPoYXqSHe/bxeocufPym5cjLdeO+XXPxibIPLzOFq?=
 =?us-ascii?Q?jyRJT1iSlFgaD3PUrBLRJ7YJHoLiZ97HWhnTK9+8ZBNumbqbwNjrQoccc3+l?=
 =?us-ascii?Q?SU5fQVt3Liv++cEl0JVme6ksRrYl/dJzZilCZPS75Sm9SiCpwMsuJVEc3aqX?=
 =?us-ascii?Q?6f5vUz1LBloAohfxEcHpDyUivWBkEMKBVHUjGsYLvZQ/CGpw43zmDlZryWZs?=
 =?us-ascii?Q?19R9RzYWB6bUF0nBDgFV4s1rsw2X4iQn6jgCeDaJ6QG5FvzNRpbWqTGC+9tX?=
 =?us-ascii?Q?7Uquu8BsQTWEc939G+2SN1wmyimbD6jtjlySk4jZHURbnr4Jh5fsgiqnLX2c?=
 =?us-ascii?Q?UBzjjRe/HHSGgx5Ho3nbZNjGei68cUovQbT0fxUXXPHIwNR6+ZskkIWI9kK4?=
 =?us-ascii?Q?pi3l0wj6Mx1uSeJ8sIpGmJsbcnXSs+np+IRHuWGIjrTJiAjpSsaQOdWy0hkH?=
 =?us-ascii?Q?/SAoag8Mf/GoQ0VX9+qKGz7xuc+65AzRrGmwum608S5X6gwi4nUJKLVmn2+z?=
 =?us-ascii?Q?ovQCEClZrYeG0kpBAAJCe38+3OvNRmjFNYqzAuN8hj5JryKrs1ggluLac8OL?=
 =?us-ascii?Q?ilJXOAauskLfF+NzZ4zjnfRPF0jElayrNuK9GPXrB7y2+ViQ/BLh2te9szPx?=
 =?us-ascii?Q?998i80fbbHob4ZLFgaud2CDQafPmzw5qgnuW2mSWFfb/01CfqYqL/d6RTktN?=
 =?us-ascii?Q?Jxg1H9aLTnzy/dNNV7MFNPR3jq/Jvjyl/8ndBFQFyISC+JjVb0A2CmOMAyNL?=
 =?us-ascii?Q?8cmcvxb/cbLofOKW6J3z4FSW9byeufe5MTgHXLfhfZOlSG7yLa4jiNXwZw+D?=
 =?us-ascii?Q?JY6uW01TQ111LTeTg2TT9v92u/DY+LPpH3epluJfFSEO6JrP6dYpVSFHnrD3?=
 =?us-ascii?Q?u3JS9yDtoIKktyvDP8Tvl235gjN6w1bFhkf6qreSRigpXs8cOC/9AzvK7WXf?=
 =?us-ascii?Q?MNZ84VCdv2UDbhHrAsJRN9VGR78xaP5OxhRTZQjPQXpV0X2WorA+hyzIFsqZ?=
 =?us-ascii?Q?4gOdmUBhvrsxHUgLOVt08ycSGrmRlGv1+Ci/Y805EaM1N/6gIAl+jFKHtPK/?=
 =?us-ascii?Q?isjZWvZEjhFYTYvrQcZFBeVtDSxLm7BjrBW36Vzvn/rpAXgFOHXbE+GZY+RY?=
 =?us-ascii?Q?HLtklrTl2UqU50fxxvuEHNlj2T+djQKPye3QCpbTs+52FvrtoF7HDt5vg1ar?=
 =?us-ascii?Q?fToYDOMmf93fUuU8mYt5gHLtEESyXcjNFNCGnSYMPwFXiEgDUqL+oPDITGM7?=
 =?us-ascii?Q?+f5iktZ9xl6d4Jq3gwYVtfMT7qYFPSrdholsT3WgLPj1JsHJbZV4Qf8pIIrv?=
 =?us-ascii?Q?0/+YxUC3HHmcRHUJ+tnk3g1i5j23z2y3afdExo4gJ2SbUKmx0gr9Qh4gMRFt?=
 =?us-ascii?Q?hV1JMg3TS8+0AiFyBvxbNnAtq+nKWVljKETkRoiqDxN4VgWla3UQDkcu6vCP?=
 =?us-ascii?Q?ga4JR8bf6R0MO46+Rb6zjif0gtcYq0jujbGtUKkMfsUYKVLi50dj8YBCjR/T?=
 =?us-ascii?Q?Ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 862b55e6-8000-4d47-1371-08dab2ff9efb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 01:00:18.2817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WCKv7o0RhoPW9M2gHVLy7kKyeIPjFV0jWqmQFNYgmDCR/5acdy1PzcMul8NJ3fxAKfkfR6CGcIYbDeLnNwL24dYpdU/dyrNuxUyqkoxHgow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5086
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> In cxl_acpi_probe() the iterator bus_for_each_dev() walks through all
> CXL hosts. Since all dev_*() debug messages point to the ACPI0017
> device which is the CXL root for all hosts, the device information is
> pointless as it is always the same device. Change this to use the host
> device for this instead.
> 
> Also, add additional host specific information such as CXL support,
> UID and CHBCR.
> 
> This is an example log:
> 
>  acpi ACPI0016:00: UID found: 4
>  acpi ACPI0016:00: CHBCR found: 0x28090000000
>  acpi ACPI0016:00: dport added to root0
>  acpi ACPI0016:00: host-bridge: ACPI0016:00
>   pci0000:7f: host supports CXL
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/acpi.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 31e104f0210f..fb9f72813067 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -221,6 +221,8 @@ static int add_host_bridge_uport(struct device *match, void *arg)
>  	if (IS_ERR(port))
>  		return PTR_ERR(port);
>  
> +	dev_info(pci_root->bus->bridge, "host supports CXL\n");
> +

I generally advocate for drivers to be silent, but this is a fundamental
message in a place that is helpful to indicate whether platform-firmware
is doing its job correctly, and it's only once per host bridge.

Applied for v6.2.