Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07232902-0e64-fab5-c60c-570e7004d6c9@huawei.com>
Date:   Fri, 21 Oct 2022 09:01:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH] tools lib traceevent: Fix double free in
 event_read_fields()
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     <acme@redhat.com>, <linux-kernel@vger.kernel.org>,
        <namhyung@kernel.org>
References: <20221017085937.8583-1-shangxiaojing@huawei.com>
 <20221020172324.66c6927f@gandalf.local.home>
From:   shangxiaojing <shangxiaojing@huawei.com>
In-Reply-To: <20221020172324.66c6927f@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/10/21 5:23, Steven Rostedt wrote:
> On Mon, 17 Oct 2022 16:59:37 +0800
> Shang XiaoJing <shangxiaojing@huawei.com> wrote:
> 
>> There is a double free in event_read_fields(). After calling free_token()
>> to free the token, if append() failed, then goto fail, which will call
>> free_token() again. Triggered by compiling with perf and run "perf sched
>> record". Fix the double free by goto fail_expect instead of fail while
>> append() failed, which won't call redundant free_token().
>>
>> BUG: double free
>> free(): double free detected in tcache 2
>> Aborted
>>
>> Fixes: d286447f23cd ("tools lib traceevent: Handle realloc() failure path")
>> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
>> ---
>>   tools/lib/traceevent/event-parse.c | 2 +-
> 
> tool/lib/traceevent is deprecated.
> 
> Can you send this patch to linux-trace-devel@vger.kernel.org against
> 
>    https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
> 
ok, thanks for the reminder.

Thanks,
-- 
Shang XiaoJing