Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] fsnotify: fix softlockups iterating over d_subdirs
Date:   Thu, 20 Oct 2022 18:03:07 -0700
Message-Id: <20221021010310.29521-1-stephen.s.brennan@oracle.com>
In-Reply-To: <20221018041233.376977-1-stephen.s.brennan@oracle.com>
References: <20221018041233.376977-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vBRwvQAkRHyO1iP2o11C0jxo3CWqtLZhRz6K/hz3LenBeo1H/eg8jEq4nfEB?=
 =?us-ascii?Q?KKZCtMJicQ/AEmQRpIBK6y1WWiNSZ0O4nu6iy3v2no+gA14s8/qVRi8qdGIK?=
 =?us-ascii?Q?w0LKEc1qK28XAU33JtmAXWQ3feiqBG/P/PBRswhYIQw/PqazpZ+54L+YXbgo?=
 =?us-ascii?Q?lfoAe/Rxgv4uMgNHUJR5/asZgGSVoYFewlt2rw2WhHZ7++4wLjQ4MZS3xF6q?=
 =?us-ascii?Q?ls//okHbgSp7YgSm/FNZXyU+6Qfw3NlbTuLjQOAfRzbcKN/pDYlgbcviD/tU?=
 =?us-ascii?Q?Cns5AM+ALMAPb+WKSguMWXlDx+98dsrsnVZiQPPYNCkYx4KmcbjGZxoJxjjl?=
 =?us-ascii?Q?5QUXb3I80Li5f6oHy93LZZQ0zJHsvDu5y02Yl5rlDHYdmu/LVTgBoPK1IF6A?=
 =?us-ascii?Q?hNJ8dfqd0DtpPZOuM/MXyJECvG5oHO16vw4sPdGXBBdkQ8Ks/Rst02taI8LB?=
 =?us-ascii?Q?yu3HD1uglf0XyBF+fvrh3JdoNajjLQhBhuDB8nCiVDY9d82lHRzPyVCZnUPo?=
 =?us-ascii?Q?N1yRjn98qsEBy4AXGHTYIgz3okBI6xpS8ZOs8EUj8cxd2YC2rML1sCig41jp?=
 =?us-ascii?Q?RU8A1cQe4xfABA8ndHWcnygM5RydlWizS7YG7iEmuiPdVNtOFQEwj6om7dji?=
 =?us-ascii?Q?T11ny5U39US7t3FeE1qSGESZerXNEP/G9Zwf2SWZjoe5smfy2yREzdJCxgCx?=
 =?us-ascii?Q?8p76bxl1tEg/S7GxsP4TSgLj1v/7xo6wfn/ntYXxwJj7yS3hmbc9Y4abZhUU?=
 =?us-ascii?Q?JwIAB+V0qt98bh3u8SkPJDuGnQGzTDS3y9+3StLHGRIhXab33UWWdEC4dj3p?=
 =?us-ascii?Q?lc87WpkqG+aL5BQ+9YI29PZlpHJjShQSEaJ/ljUPolZvABjuV8AyD5oPa2F4?=
 =?us-ascii?Q?V6QhWyf8uUH54P5Xmi7P2Jr5PDdxBYs5wL0p9TMnTEaZ9mzlKlLg91nRhkie?=
 =?us-ascii?Q?bE3JOIOQlR8avtXCZN8k9mEVkdB7hXWRgfDUToaunQin/C3CAuOU7vj6iYRF?=
 =?us-ascii?Q?zhBhVBAHWtsPc6B+aUecVdpvKlsesn5quf4A7qPgDogMOrQvO4pN7BWOqisp?=
 =?us-ascii?Q?vUAHniecDj0eE4emE1K8BCLo1BEMPhV0OX0kix+mANvWoayTCM/EhEHVDVDv?=
 =?us-ascii?Q?GW5NcuR3V2jm+SB5uu03Xsm4OtTT0jDGIGudgaRDPx8biAEk320ya31XiY8Y?=
 =?us-ascii?Q?NZjnNrFB3IoM2hRTRX8r7zlQQ16uNDwo/zYIbUdv566SyXgSrNLfvzUjj76L?=
 =?us-ascii?Q?mHGVVrMhnRqgNNDWE0iz6WyAjyv6MEWP4r941Dd3yO4aY6wsQgSoSDrEpUip?=
 =?us-ascii?Q?uy3Xz1P7MQuQzcHMGeEDVjPq1iHsP6NRtd+pWUqoOH5LhS8yeHNDK7h7Mqrv?=
 =?us-ascii?Q?9snvH5PZSpRnhSDeWwA7OWeWtKBJfj2AQ217fvkeaVHSLSlPxaOYn1N/Vcfa?=
 =?us-ascii?Q?Oxn63OSGZ3wvn1S3khVvEKdv5ID8s6+MGActuI9idC+xEVP9GDMaa/KWCIa0?=
 =?us-ascii?Q?lH1AvUAHwvbIfiRnaKwYzf8M7Ao8petBx/Gzkrb6i1rkzxrKimh5Qu5Lp+9j?=
 =?us-ascii?Q?ofLi+1PxPuNnkIyC4jkKdidyRBKAqjUybM5GcarmrajDHcNAo/aGA+BbSog3?=
 =?us-ascii?Q?IA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e66bd33-ff15-4fe2-5891-08dab30007a5
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 01:03:13.7725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DJME+TRfMadCvARDuZyXWo8hQ2HUzhrBNxBUKLIZ+cJGJZOeMl1THej0zOkXJQ7gVz2b7EnS5aa98h83MzU3hGeqMvZZTwm1+VVV1MuMA+A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4446
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_13,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210210004
X-Proofpoint-GUID: SISF3_kro6IJ5yqCe-0q6sJWnSJKQivB
X-Proofpoint-ORIG-GUID: SISF3_kro6IJ5yqCe-0q6sJWnSJKQivB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Amir, Jan, Al,

Here is my swing at v2 of this series. I've taken Amir's suggestion and
stored the flag state in the connector. There's one issue with that:
when the connector is disconnected, we lose the state information, and
we lose the mutual exclusion of conn->lock. It becomes possible for a
new connector to appear and start doing its own updates. Thankfully I'm
pretty confident that there's no case where it would be actually wrong.

I've tested this without the final patch (since that one triggered the
strange dentry refcount warning) and everything works great. Now that
(hopefully) the changes related to fsnotify connectors and things are
solidified, I'll try to look harder at the sleepable iteration, and see
if I can identify why that's not working, and hopefully solicit some
advice & feedback from Al.

There's definitely a few nits and cleanups to be done yet on the series.
Pretty sure I need to clean up the indentation and a few other
checkpatch oddities, so feel free to hit me with whatever changes you
want to see, however small :)

Stephen Brennan (3):
  fsnotify: Use d_find_any_alias to get dentry associated with inode
  fsnotify: Protect i_fsnotify_mask and child flags with inode rwsem
  fsnotify: allow sleepable child flag update

 fs/notify/fsnotify.c             |  92 +++++++++++++++++++--------
 fs/notify/fsnotify.h             |  31 ++++++++-
 fs/notify/mark.c                 | 106 ++++++++++++++++++++-----------
 include/linux/fsnotify_backend.h |   8 +++
 4 files changed, 175 insertions(+), 62 deletions(-)

-- 
2.34.1