Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1870455rwi; Thu, 20 Oct 2022 19:05:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7T1eIdmaqe8tFcEL7rk61PNA81WyJn9n8tzQXmvjRt++9634OxM7rhP518VIr3JfAn36s+ X-Received: by 2002:a17:902:f541:b0:186:4b91:4501 with SMTP id h1-20020a170902f54100b001864b914501mr16800630plf.171.1666317918439; Thu, 20 Oct 2022 19:05:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666317918; cv=none; d=google.com; s=arc-20160816; b=a76ZnzOzmwx+9EfKMrDZnZzVI/As6b6QKeUlSGzNvbTST1Qj/7taiPTBB4gGLsH8Pu hLrGlLe7c4ah1swqMJqiX2+Y/CIXy5XeBZeiANrNYsVg73xqMup8Eg+zLZiL3U/NaMZP Sqt8x/Zs7nRe161ucwinWkB8gHjun7S78S+UV1VZIW0vx+FzTYE8KgySNcljufuItsYk gAvJcSQhf5NZuF94DHZKD5GLWAUrxsbeTmwqQZqjQBiR959VCkPnxvQ+/bMASDFfBkBo sS17f2evUQ6Hfi5diIxNJ7H//67T4e5mKcPmcf6UAsBIJnvbT1HxE0BteJs634a+wEaw 8MRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=riV2LKDCFyGjMOKFMcuq4CjIaZfhS9K0Zw+bRcaY9Ps=; b=cyBeFp7Ek45ubKD47MFcL6qvWGzk2FrDXFCsCwEPxc/qlEHZgWrEGeJRUwj1N4dWkC u/6at9q3d9qjq5e5y5pwdeokpTn63qN9NQjRBPWKNREQOK0gc4yAHQnPNDi434qJK0h2 W8LH2tp32qCZd/uK+bgTflDtww+zbHJxQbAMsJUPn76dod1nX1Mn9XZBlHFNP0TkCZYm 5rPEe6x2F+8fHNllZ7ExEzf9ImFY4LgCHz2CZVqxqmt/YYOwUtt8HytfXn6G0kFKv2sE HMXIiftusVwioL+JwluVTR0+8eknPVy8drN1dyPI12cPPGkB8FkHvlaEQ78+Kn8/thjt Iwug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Z/b1h0Ea"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a170902d4ca00b0017890fb8cdcsi26260196plg.140.2022.10.20.19.05.06; Thu, 20 Oct 2022 19:05:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Z/b1h0Ea"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbiJUBgb (ORCPT + 99 others); Thu, 20 Oct 2022 21:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiJUBga (ORCPT ); Thu, 20 Oct 2022 21:36:30 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DD210DE7E; Thu, 20 Oct 2022 18:36:29 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id ot12so3761594ejb.1; Thu, 20 Oct 2022 18:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=riV2LKDCFyGjMOKFMcuq4CjIaZfhS9K0Zw+bRcaY9Ps=; b=Z/b1h0Ea2IOWf8ygXQlMOLriBrTuYzmtSPrEuu6v+TL+mM9RxVlN44VRR1wiRY3PXT Bt9WCuzw44D56rPl7WwjzQtG3JthD69N1HfVQgJndDhDK9LWPdxdhH6qhdD6oNuF0ZKf v7lpBBhqsSbaQIG2t8Ed2Ldgmb1KjyfOv1qo6+Az9Pqo4tYBB6GUy56zRt9Vdff6lbHi O7hgksyhy7pRlPOAXBco9KRMG56RXO4EUluwNAbNuQGKbinuvJGRxB8aWa+y6QOTK6PX mRGk1nhnjMWZuP98i8prLVwmLuAmnE315L2xgSwUYaYAneLqFfQxI7sQVG4AQFC3YBB6 YC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=riV2LKDCFyGjMOKFMcuq4CjIaZfhS9K0Zw+bRcaY9Ps=; b=UP1iBLhUekRpu8d1p/J2raPCmtYi34lCFpY63O2qRFdamXYwaXePnj25Ub/GLHU18t V8TPdbLdcG7A3I3f+eCe4aY3XUKtb0j9D92+nhVenlbH+BQGPTZc0InYUzkFv2ufDZmn jmq5HZFykaGDesVuM5FBlidvg+td8aDtU/3Hi8oBi3qBzsuJ9Na8FFWbxt7pic4FEay2 lq3yEsVu5RK7mR4pJVsxJTRcfQLa29arvYQZuGuUa7KmYq4O2cPbULL+59216foz3+TT z4hslp2qb+IfdvnZz8ygaxf4t3Jevm9cN47zByyuKow5THa1zvUVEODEK0oEciQmhReI lIGw== X-Gm-Message-State: ACrzQf1vo+UYj9bteerMB/ihGgeTcd5iRsM7K6ZuVDVrA7wqrAc4CgQ0 6hMv4loFr/PwtvwzfKDKkNo/6M0nhyqstacLZ3aUALVF X-Received: by 2002:a17:907:6e93:b0:78d:dff1:71e3 with SMTP id sh19-20020a1709076e9300b0078ddff171e3mr12669803ejc.94.1666316187888; Thu, 20 Oct 2022 18:36:27 -0700 (PDT) MIME-Version: 1.0 References: <20221007081327.1047552-1-sumanthk@linux.ibm.com> In-Reply-To: From: Alexei Starovoitov Date: Thu, 20 Oct 2022 18:36:16 -0700 Message-ID: Subject: Re: [PATCH] bpf: fix sample_flags for bpf_perf_event_output To: Peter Zijlstra , Linus Torvalds Cc: Jiri Olsa , Sumanth Korikkar , bpf , Vasily Gorbik , Heiko Carstens , Ilya Leoshkevich , LKML , Namhyung Kim , Sven Schnelle , Thomas Richter , X86 ML , Daniel Borkmann , Andrii Nakryiko , Jakub Kicinski , "David S. Miller" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter, Another 2 days have passed and bpf side is still broken due to the change that went during the merge window without corresponding fix from the bpf side. Looks like the patch is sitting in tip:perf/urgent. Please send it to Linus asap. We're not sending bpf fixes to avoid breaking bpf tree too. We've worked around the issue in bpf CI for bpf-next tree only. Developers still see failures when they run tests locally. On Tue, Oct 18, 2022 at 9:57 PM Alexei Starovoitov wrote: > > On Fri, Oct 7, 2022 at 8:31 AM Peter Zijlstra wrote: > > > > On Fri, Oct 07, 2022 at 11:45:36AM +0200, Jiri Olsa wrote: > > > On Fri, Oct 07, 2022 at 10:13:27AM +0200, Sumanth Korikkar wrote: > > > > * Raw data is also filled by bpf_perf_event_output. > > > > * Add sample_flags to indicate raw data. > > > > * This eliminates the segfaults as shown below: > > > > Run ./samples/bpf/trace_output > > > > BUG pid 9 cookie 1001000000004 sized 4 > > > > BUG pid 9 cookie 1001000000004 sized 4 > > > > BUG pid 9 cookie 1001000000004 sized 4 > > > > Segmentation fault (core dumped) > > > > > > > > Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data") > > > > Acked-by: Namhyung Kim > > > > Signed-off-by: Sumanth Korikkar > > > > > > Acked-by: Jiri Olsa > > > > > > Peter, > > > I think this should go through your tree again? > > > bpf-next/master does not have sample_flags merged yet > > > > Yep can do. I'll line it up in perf/urgent (Ingo just send out > > perf/core). > > Peter, > > Could you please hurry up. 11 days have passed. > > This issue affects everyone the hard way now after merging > all the trees: tip -> linus -> net-next -> bpf-next. > The BPF CI is red right now with 5 tests failing because > this fix is still missing. > It's causing a headache to maintainers and developers.