Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 21:17:33 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
Cc:     Matthew Wilcox <willy@infradead.org>, <ziy@nvidia.com>,
        <david@redhat.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <mike.kravetz@oracle.com>,
        <opendmb@gmail.com>
Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning
Message-Id: <20221020211733.31b2ee4f81805186367304b0@linux-foundation.org>
In-Reply-To: <23081249-229b-b745-50f5-53e394b623c9@quicinc.com>
References: <20221021030953.34925-1-quic_aiquny@quicinc.com>
        <Y1IPqhVpiehRBGNS@casper.infradead.org>
        <23081249-229b-b745-50f5-53e394b623c9@quicinc.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com> wrote:

> > Honestly, the cure is worse than the disease.  I'd rather not have a
> > line that's this long.
> I don't like this long either. While the current Deadcode warning is 
> also annoying for our clang tidy check.
> 
> will the CONFIG check can be acceptable?
> like:
> 	#ifdef CONFIG_DEBUG_VM
> or
> 	if (IS_ENABLED(CONFIG_DEBUG_VM))
> 
> Any good ideas?

Put a newline in there?

Although the shortly following lines are nearly as long...