Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 21:18:58 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        <dan.j.williams@intel.com>, <dave.jiang@intel.com>,
        <alison.schofield@intel.com>, <bwidawsk@kernel.org>,
        <vishal.l.verma@intel.com>, <a.manzanares@samsung.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cxl/pci: Add generic MSI-X/MSI irq support
Message-ID: <Y1Idsv0Nuu+V9aMj@iweiny-desk3>
References: <20221018030010.20913-1-dave@stgolabs.net>
 <20221018030010.20913-2-dave@stgolabs.net>
 <20221018103619.00004c39@huawei.com>
 <20221018115227.00002a4c@huawei.com>
 <20221020223125.hyrfpt2noiicisxa@offworld>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221020223125.hyrfpt2noiicisxa@offworld>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RjV0OqFTL2XW37YGWl1rtF13ZRM/V2BFY/n/AQBJB7acyJLZkR6SRi1f68s1?=
 =?us-ascii?Q?oR682xPLAS+Gw33NekJMO/KTOtHpoeb3fIN2T1wMUgdA4hb0khktbvJa0nVv?=
 =?us-ascii?Q?i+dsLRJ9SzPn9jFqAlLQIWfAm1rjXiRDP4SO5cK00wtAdKLdNySPdOSoYJDO?=
 =?us-ascii?Q?Xm+eVVZ4IbNXpECNMNFuvt6lndZ0FuCaOC4fHg3p831HWlCQeHrjO3LqooIe?=
 =?us-ascii?Q?1J9K7QELu4Z//j0Cdpnh8CMza3WxoOTcIodcawh1ZBswlCo9htDXxtog7i/F?=
 =?us-ascii?Q?9uRMZllxBgN6TBPNH9RAzCyzs9GErDbUnx9m4A7MphDP9hQz8ifyI1vufDBd?=
 =?us-ascii?Q?3ypvKKMX8GE5pb2juGlFa3hRdIayTPnKI2yux8Zaadf4p/Chh6mWPGvyez+a?=
 =?us-ascii?Q?NTzQvP9+OsvFKL0iOJ6OhddHQWgg9ZlN6kSg2DLZ/be6Azqfr/y7p6ZkK7nC?=
 =?us-ascii?Q?xtl12YyJ/+ZzfEnTAYXqtfmbRTXzi5bV7Brle0wG+l8OLmCK0YDGstGMHJEs?=
 =?us-ascii?Q?LKOZgV4ns88T5r5beUeSGCjn4H2gXg2WC00IZ9AZQFfxXs3BpdrvkBtXWpDt?=
 =?us-ascii?Q?WFv+Z/kGsKGll6YxpkZgy0lVaEAnV56kojiKJ/ke7qz8go5acDcuguCCF8UD?=
 =?us-ascii?Q?3271nRn96NBV634LUjdsbtS2jx3HQkz5CZw/MEfjF5qptZ2vqQkFHp/EcWBY?=
 =?us-ascii?Q?qSlI0IDoZrSvWv072Jd1LayHdct9iby9XsD5ugQ6CFCu+KvQiy+dLap7fuVr?=
 =?us-ascii?Q?4Bd9pQFMsjdKeRy3NzdMZW8QkBd6OikZp5EhgcXaYtVJEhBX5vUrXMyD7zoA?=
 =?us-ascii?Q?omY1H+fKFVCYWMSkYZoZ6qaoBHI/Y9TngW5vKIB6h+KA2NU7MQLLAA1Dv5yz?=
 =?us-ascii?Q?HvGWtoameWnn5Txqswv5dVWXkcO8exoOkCaiPw57CPGOUbCExSFz9Tjrf145?=
 =?us-ascii?Q?G64VaSi9Y7QP7oQVrYiGC2I2L8cZ41FwHK70j/1ZQ+sv9NLbpQ0SNdT6eSjg?=
 =?us-ascii?Q?2LO9pNdCdSaJFRIhITVo6rZRDjsOExcpk6oM002T8FVLvmcrYgP85G2lEpKm?=
 =?us-ascii?Q?j28gBrJ4baga0WxDb6ZjI3oRIJhj2q+7Zz6R7olKBB5Xot9JdeajP1nTxfdv?=
 =?us-ascii?Q?e99iFx8lKSEXG8UhGI/G/IMWMDNUe0CfzK2vwML1GuN2bFVamuxxgEV84Mo0?=
 =?us-ascii?Q?byK0eignTiQVpnJ7E/ihg0O/rzFkbKkBXsH3+e1kWZ4201ZYY6FcVcILlvUP?=
 =?us-ascii?Q?Hm8E1uI9G98pu1XG3zsGK5INkvKG0s41jSf3Uru92AEXScr75MxwVbqNrRm2?=
 =?us-ascii?Q?Q69Iif5l9jAuQ9oD6MPyOjb1jopRXDxVHHkbY9/dQlaZj0pRZHXcS24t4ZwN?=
 =?us-ascii?Q?6OEpmhrbaCdOjS9TdEF3sirtXCde+6U8QFc4uYP9pdwCnKj75vNaFzvvcby+?=
 =?us-ascii?Q?eHQvj3YDe/mBIO1nwMacqowKafZ21KgUwxOu8s5gUA/URVPKlg5qs130dnS8?=
 =?us-ascii?Q?tI6pRjEbcb7pXeiMQ08hEYof+B2q4LgAcqApDoveu8wpG3Hk5yqW5A+fokDV?=
 =?us-ascii?Q?peZiBcxk5RuU+GatvHkDSLoudw5ovXj1Uc3Y5eWe?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c241109-d543-4d87-d01c-08dab31b628d
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 04:19:02.6858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lvD+fu1m8RL6Q38LN/yaCFR9XfoxyRsWbVqj4KWOfHNqqCgwKi5Rs4hxmwAf48vdGxtHsX1+FA5lSRgaP+Kiwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5361
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 20, 2022 at 03:31:25PM -0700, Davidlohr Bueso wrote:
> On Tue, 18 Oct 2022, Jonathan Cameron wrote:
> 
> > Reality is that it is cleaner to more or less ignore the infrastructure
> > proposed in this patch.
> > 
> > 1. Query how many CPMU devices there are. Whilst there stash the maximim
> >   cpmu vector number in the cxlds.
> > 2. Run a stub in this infrastructure that does max(irq, cxlds->irq_num);
> > 3. Carry on as before.
> > 
> > Thus destroying the point of this infrastructure for that usecase at least
> > and leaving an extra bit of state in the cxl_dev_state that is just
> > to squirt a value into the callback...
> 
> If it doesn't fit, then it doesn't fit.
> 
> However, while I was expecting pass one to be in the callback, I wasn't
> expecting that both pass 1 and 2 shared the cpmu_regs_array. If the array
> could be reconstructed during pass 2, then it would fit a bit better;
> albeit the extra allocation, cycles etc., but this is probing phase, so
> overhead isn't that important (and cpmu_count isn't big enough to matter).
> 
> But if we're going to go with a free-for-all approach, can we establish
> who goes for the initial pci_alloc_irq_vectors()? I think perhaps mbox
> since it's the most straightforward and with least requirements, I'm
> also unsure of the status yet to merge events and pmu, but regardless
> they are still larger patchsets. If folks agree I can send a new mbox-only
> patch.

I think there needs to be some mechanism for all of the sub-device-functions to
report their max required vectors.

I don't think that the mbox code is necessarily the code which should need to
know about all those other sub-device-thingys.  But it could certainly take
some 'max vectors' value that probe passed to it.

I'm still not sure how dropping this infrastructure makes Jonathan's code
cleaner.  I still think there will need to be 2 passes over the number of
CPMU's.

Ira

> 
> Thanks,
> Davidlohr