Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2049981rwi; Thu, 20 Oct 2022 22:11:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ZS7+tbllbaQrfkEdm7Z0bTo70IcgD3/mZa9F9480KNtgCW86TfsRmALKIP86M1OU+mgGv X-Received: by 2002:a17:907:2cea:b0:78d:eac6:2d09 with SMTP id hz10-20020a1709072cea00b0078deac62d09mr14096545ejc.124.1666329073488; Thu, 20 Oct 2022 22:11:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666329073; cv=none; d=google.com; s=arc-20160816; b=bNBVNNuoKj4mQjJLpuDzXoSRUZl6s2ies/IBgY2g04POe/1CbusZdoK6ASKbrx37VY /tQoV1VErAySNAcFtrs+oWLCsyOyJ6gCz25UgxwaG8pxd7bKzQzb9+NwSjDzBTvdMhH5 4KfXh8lcEix4nAFw+b28jFZtvpfIu4ITYpgS355X13EM/dTY55cm3/Y5RsDoql4ehhbU Nw1Wsq7r0AXT/kp80tjp0xq/EXqMdLbIq8zLSUIzwVLz2eQbq/juOmuygpcDLK0+lQSL WQW401rTWxE2KDGuvvdZRII/a71U7cKa7t2uRfbPz91SKnVNHb/OdtQmaqcGsPa3NPh8 GS6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MEwZHem6XE7/ekLP3cDVQiDet0qLNX4/5trFWKq/TK4=; b=0EQMKo93rUIyWNhgHyzUMeOSqZg3ylUF0JBOGX0XvlE2YTJ9xjkBCAWC3GrPiCSsPJ XXuRQPDXzeCrBzuppbPQhkJ94+pYEPnLaE136uuYZCiFym4tyK7IUZxw4EldRlc3J9Jl on6ZCV6fXklCQ3vxRE3FNQaJMI9fErwlS+SVyAINnaJiQkNINBAb9aocN7S+WuiScFNk cZ5nxxixv7WqPEL7nGbG2KPtaq5zuO27vNrRffkfjM4NSpsf2SqU2WceWwfWm/DZroja Id1NBV0atGKghmzHbXLjvVROn7tZwUPZmAjJWvcEVIzZE6iruyK/Z8C5k8UG57K6hsol MmmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MhfhmXR8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020aa7dd4a000000b0045c42a9f588si17362540edw.408.2022.10.20.22.10.48; Thu, 20 Oct 2022 22:11:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MhfhmXR8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiJUFHc (ORCPT + 99 others); Fri, 21 Oct 2022 01:07:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiJUFH3 (ORCPT ); Fri, 21 Oct 2022 01:07:29 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC472187DF3; Thu, 20 Oct 2022 22:07:27 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id l127so1390264iof.12; Thu, 20 Oct 2022 22:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MEwZHem6XE7/ekLP3cDVQiDet0qLNX4/5trFWKq/TK4=; b=MhfhmXR8De3QaEZs1GgnopnDHQU/TldUkkJLZfKo8RH91E3wimNUV609GsUonZMXkL tOriKFtKty8u0HT3H/hbnzT4Pxr4xp6d2Q4PDgVtULnkAlptMcSngaeqVa3Q/UrMMhpO IQZeN0ar8S7WYAkf6HFjP8pacsnxEhBCJypQmyY8Tv22rdlXBSEynIJOlflWSFUN4jNH flt31456ja5+HTaQwx9cRyIvmBXJKrk1ncgt9FwND7xVM8TE9aTsfQd72QqProHWSA2d qzPq0jbftOVsKmFzYUBufu9KN09YcFD6h7BSmsVcOFCHspzNXBchYSqH8lKTtVbAlUA3 6PYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MEwZHem6XE7/ekLP3cDVQiDet0qLNX4/5trFWKq/TK4=; b=kyoCnYMuoSOpSN/6T5QNV6JGKrxlFmwFePE770yDFo9LYhGaSKlbwI5sa7H+rWEGV7 VbeLj4748lTDU7AzV9aUXLT561jl1pArOVLhf54ebf2bKfVcnExr432DpAKDzC6+zHkp 07Xe7fKvlSgVTm/SjcaiSEDE7/WGgRG790x9+DF+gM/Q2mMQo6fQfhR625aOBjYkurmf J0mZaFm7c7IV1M2l8MCc6RIvzHLZcphvrJldHyWE0v8VvlOP0CeAOKi4JZUMCf/doRjU glT3Q4Kvt+9v9Bdd1pX8iXavfxOH9lJtDBR/bJWLPohbTlMnOsm5qZdC7/m9j1khd/HM PpRA== X-Gm-Message-State: ACrzQf0eKMsu+RUVV58YpX/PRSvuJV+5M4QL/SGX8DVKG3cHsWRgBdgn bbOlenKHqEOakvuTY9kSHSIa1+6nbnQfj2olZho= X-Received: by 2002:a05:6602:2742:b0:6bb:a95d:7e3a with SMTP id b2-20020a056602274200b006bba95d7e3amr11993607ioe.16.1666328847336; Thu, 20 Oct 2022 22:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20221018195122.8877-1-linux.amoon@gmail.com> <402500e8-b4fe-9b8f-d634-e329191af1b8@linaro.org> In-Reply-To: From: Anand Moon Date: Fri, 21 Oct 2022 10:37:11 +0530 Message-ID: Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ To: Martin Blumenstingl Cc: neil.armstrong@linaro.org, Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin / Neil, On Thu, 20 Oct 2022 at 02:10, Martin Blumenstingl wrote: > > Hi Anand, > > On Wed, Oct 19, 2022 at 7:17 PM Anand Moon wrote: > [...] > > > > +&pwm_AO_ab { > > > > > > &pwm_AO_cd not _ab > > > > > No it has a conflict with CPU_B (vddcpu_b) PWM > Uh, you're right. That's probably why the Hardkernel team uses a > software based PWM implementation: [0] > In hindsight they should have used a different pad either for VDDCPU_B > or the fan. > > I think the most pragmatic approach (since the "GPIO PWM" driver is > not upstream and I don't know if something like that would be accepted > upstream) is to use a GPIO based fan as you did in your initial patch. > Not sure what others think though. > When I use gpio-fan I get the following output with gpioinfo Feature it woks as expected. $ .sudo gpioinfo .... gpiochip1 - 15 lines: line 0: unnamed unused input active-high line 1: unnamed unused input active-high line 2: unnamed "enable" output active-high [used] line 3: unnamed unused input active-high line 4: unnamed unused output active-high line 5: unnamed unused input active-high line 6: unnamed unused input active-high line 7: unnamed unused input active-high line 8: unnamed "regulator-tflash_vdd" output active-high [used] line 9: unnamed "TF_IO" output active-high [used] line 10: unnamed "gpio-fan" output active-high [used] line 11: unnamed "n2:blue" output active-high [used] line 12: unnamed unused input active-high line 13: unnamed unused input active-high line 14: unnamed unused input active-high When I am using pwm-fan using *pwm_ao_d_10_pins* pin is not getting registered below hence it is not working on my end. $ .sudo gpioinfo .... gpiochip1 - 15 lines: line 0: unnamed unused input active-high line 1: unnamed unused input active-high line 2: unnamed "enable" output active-high [used] line 3: unnamed unused input active-high line 4: unnamed unused output active-high line 5: unnamed unused input active-high line 6: unnamed unused input active-high line 7: unnamed unused input active-high line 8: unnamed "regulator-tflash_vdd" output active-high [used] line 9: unnamed "TF_IO" output active-high [used] line 10: unnamed unused output active-high line 11: unnamed "n2:blue" output active-high [used] line 12: unnamed unused input active-high line 13: unnamed unused input active-high line 14: unnamed unused input active-high Thanks -Anand > > Best regards, > Martin > > > [0] https://github.com/hardkernel/linux/blob/c109dec94e7e819554830acfac4b6ed96e230179/arch/arm64/boot/dts/amlogic/meson64_odroidn2.dtsi#L356-L359