Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2130834rwi; Thu, 20 Oct 2022 23:29:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7W3LOeXwavdq8W2VkdYQ5mtp7FYNjgAYYgf+xT7oaRqYiQ/YUSMO4+zFlaKX5JBqg55vCD X-Received: by 2002:a05:6402:4282:b0:459:befa:c79c with SMTP id g2-20020a056402428200b00459befac79cmr16106012edc.23.1666333786231; Thu, 20 Oct 2022 23:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666333786; cv=none; d=google.com; s=arc-20160816; b=TkaAeJm7giumvM2gvdBs6yqz+mf/bGuE4PQgd8HnnE8yD38EMPvz3VP/+g1bY5xGLK DgMZpQUIpUc35EpW/sidpP2jNMXNW/IB6jzAmJUKuOuY14rjo419hHytNwAf0lQgPxJK chAZ0GMj7CwxMxfzRb52Njwl37gpaCRCVpJ9IJitZZdE2uvPxlsQm+oABq1fbRZ7wUZO XgUpon2ywXn56dmxRqyzOUL599Ge8FynUyU7uROG6Vb202RR336mhcCmp66l/Nezdm0Y 7gdaNk79tWS5BgNFF4gg/3cLMjPxZahb/S3i1TsbY6pgyFd0ZSqlGb6Sl+7hiJbF/XHo A3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=4TDVEecvJ/SyUgNeYkrUsV7GwIq/acYXERijSp1ev9I=; b=EuQAFblyThyZr5b4RQ7UkJ7XRNtzgv/kA2ixu2gJWwuQmpu9DtrFC8wJRpxGbR+Q8a htoZOFLJbbI68WrdO3sd3P1V3yFYNQJnnLbFBVtYgvhSdmIN2Z2MrakaUagRztJbkmYr 7o9chv2Vumgz3pRm1KL6nRQAqnL1/G2mqjlsrAeGOpa8NkFw8+/GSwlYy1rpXWuzDJYD SIuKw/mPj80hnEWVaj5zEvjsxSWLpILeRxJI8pVdVmU6bC1EnQ34aMMhYijs9W+2HIVg sDgY7bZpFFmer7LrbWbYDLj4V24oVXoXsKwgVr6GD/Q9SRtOc/s7FrtWgdMvmXNKmiMr ieWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=af+XHWpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds3-20020a170907724300b007833cbbb747si4843614ejc.578.2022.10.20.23.29.20; Thu, 20 Oct 2022 23:29:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=af+XHWpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbiJUGLT (ORCPT + 99 others); Fri, 21 Oct 2022 02:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiJUGLR (ORCPT ); Fri, 21 Oct 2022 02:11:17 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A45CD109D64 for ; Thu, 20 Oct 2022 23:11:16 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id x13so1421337qkg.11 for ; Thu, 20 Oct 2022 23:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=4TDVEecvJ/SyUgNeYkrUsV7GwIq/acYXERijSp1ev9I=; b=af+XHWpH2wFmLESBvoDa53/Ahgt8ffIl6QGSwnrtokuIRg/3jRps7FrEa4rWTzzk6O hdg3enDxjfSk0bsJWevvglz+TrZHs4tHrW0cFUDPrr41FAlyt203JnzvIGZ9p2K8KZX8 AbMZsczY4IsDZHUgoHwvDMC7vMC94CDGQbwcMh4h2XqngsAdWdZ/pa2UzxU5nzJysEkW Bw00aouawlA5J5rNTMTFQS9Jl0qc18SR6tgSQwxVaiIdZQ7Axmn0ZygbslzsNpB+EZIE lURoYnIoE3c5QrwkN/s+dVQvtNvHjvMGsXfqUR8IAdA8PKNa6G8S0wALt3Sssq+/TDJa AjQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4TDVEecvJ/SyUgNeYkrUsV7GwIq/acYXERijSp1ev9I=; b=jSKs683C5kc3wwHPVG+WeGwm4nb9S/c80AOXGtSO9eK9gbcFH6duFXclVLKYDJ6xDi 6O0EvG+VRBQl6qQkXvzP0FNWJEtLREKubDk8lHh5iGlISkO+ivGD8mIziSawO+HXjCFL y1K1G59fiK+PcnGzI+hj/NYtV1uMkvnnC/Jls2d78l81OypVE12NFNFZQH53LsEXZQ1P gdP3vgFFM0PT2mfjAqmytFbNq5LzGiWc9t8jQtSxhIbzsGLf7JeDUEAjl1OsJegMKnlt j/irJSk/UTmwKgfg0C2OMbqd2s2iJIcP1b0pl4CYmqXSFHBAt5uCLSun1waqBpW/eRkV fNHQ== X-Gm-Message-State: ACrzQf3zIM7j34q00brC+W43U9FygCZ1r7NY5Y5yGHyy/22/yWkXyuPe Vf/4dMTmZo57qqp1159ok5kdf2CYZAkDyqnVDsY= X-Received: by 2002:a05:620a:2699:b0:6cf:3a7f:5fe6 with SMTP id c25-20020a05620a269900b006cf3a7f5fe6mr12797372qkp.103.1666332675621; Thu, 20 Oct 2022 23:11:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tanju Brunostar Date: Fri, 21 Oct 2022 07:11:01 +0100 Message-ID: Subject: Re: Request for assistance To: Bhaskar Chowdhury , "Theodore Ts'o" , Greg KH , Tanju Brunostar , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 12:38 AM Bhaskar Chowdhury wrote: > > On 10:39 Thu 20 Oct 2022, Theodore Ts'o wrote: > >Tanju, some additional hints. First of all, please don't send cleanup > >patches to address checkpatch --file complaints about overly long > >lines. It's generally not worth the code churn. > > > >Secondly for code that *you* are writing, think about why you have > >lines which are exceeding the line width in the first place. Is it > >because code is being nested too deeply, and perhaps some judicious > >function refactoring with good function names might make the code > >clearer? Would adding some temporary variables that are judiciously > >named make the code look clearer? > > > >The rules about "thou shalt never have lines which exceed 78 > >characters" are rules of thumb. The high level goal is to make the > >code more readable and easier to understand, since good code is > >maintainable code. And sometimes it's not just about where to split > >lines of code but whether there is a better way to structure the code > >so that long lines aren't needed in the first place. > > > >Cheers, > > > > - Ted > Righto!! I failed to miss it my replies. That an editor can be trained or > customized to that way. Especially , vim and emacs. > -- > Thanks, > Bhaskar > > "Here's looking at you kid"-- Casablanca > https://about.me/unixbhaskar I appreciate all your replies. They have been quite helpful. I will try to apply them as I continue on my journey of contributing to the kernel