Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 08:04:51 +0200
From:   Frank Wunderlich <frank-w@public-files.de>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Frank Wunderlich <linux@fw-web.de>
CC:     linux-mediatek@lists.infradead.org,
        Alexander Couzens <lynxis@fe80.eu>,
        Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <Y1F0pSrJnNlYzehq@shell.armlinux.org.uk>
References: <20221020144431.126124-1-linux@fw-web.de> <Y1F0pSrJnNlYzehq@shell.armlinux.org.uk>
Message-ID: <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 20=2E Oktober 2022 18:17:41 MESZ schrieb "Russell King (Oracle)" <linux@=
armlinux=2Eorg=2Euk>:
>On Thu, Oct 20, 2022 at 04:44:31PM +0200, Frank Wunderlich wrote:
>> diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii=2Ec b/drivers/net/=
ethernet/mediatek/mtk_sgmii=2Ec
>> index 736839c84130=2E=2E8b7465057e57 100644
>> --- a/drivers/net/ethernet/mediatek/mtk_sgmii=2Ec
>> +++ b/drivers/net/ethernet/mediatek/mtk_sgmii=2Ec
>> @@ -122,7 +122,21 @@ static void mtk_pcs_link_up(struct phylink_pcs *pc=
s, unsigned int mode,
>>  	regmap_write(mpcs->regmap, SGMSYS_SGMII_MODE, val);
>>  }
>> =20
>> +static void mtk_pcs_get_state(struct phylink_pcs *pcs, struct phylink_=
link_state *state)
>> +{
>> +	struct mtk_pcs *mpcs =3D pcs_to_mtk_pcs(pcs);
>> +	unsigned int val;
>> +
>> +	regmap_read(mpcs->regmap, mpcs->ana_rgc3, &val);
>> +	state->speed =3D val & RG_PHY_SPEED_3_125G ? SPEED_2500 : SPEED_1000;
>> +
>
>Sorry, looking back at my initial comment on the first revision of this
>patch, I see my second point was confused=2E It should have read:
>
>"2) There should also be a setting for state->duplex=2E"
>
>IOW, "duplex" instead of "pause"=2E
>
>Also, is there no way to read the link partner advertisement?

Hi,

On my board (bpi-r3) we have no autoneg on the gmacs=2E We have a switch (=
mt7531) with fixed-link on the first and a sfp-cage on the other=2E Second =
mac gets speed-setting (1000base-X or 2500base-X) from sfp eeprom, but no a=
dvertisement from the "other end"=2E Imho it is always full duplex=2E

I have no register documentation to check if there is any way to read out =
pause/duplex setting=2E Maybe MTK can answer this or extend function later=
=2E

regards Frank