Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <616a128698656e71a4e28d59bbced17443c5cebc.camel@mediatek.com>
Subject: Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators
 unit names
From:   Chunfeng Yun <chunfeng.yun@mediatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, <matthias.bgg@gmail.com>
CC:     <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <sam.shih@mediatek.com>, <hanks.chen@mediatek.com>,
        <weiyi.lu@mediatek.com>, <zhiyong.tao@mediatek.com>,
        <andrew-sh.cheng@mediatek.com>, <viresh.kumar@linaro.org>,
        <fparent@baylibre.com>, <mars.cheng@mediatek.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Date:   Fri, 21 Oct 2022 14:25:52 +0800
In-Reply-To: <96ab6836-4650-ee53-a0c9-54b8328b8667@collabora.com>
References: <20221013152212.416661-1-angelogioacchino.delregno@collabora.com>
         <20221013152212.416661-7-angelogioacchino.delregno@collabora.com>
         <3b7fc7414f282ca044c24dae280f9bc9533a5b7b.camel@mediatek.com>
         <96ab6836-4650-ee53-a0c9-54b8328b8667@collabora.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote:
> Il 14/10/22 04:43, Chunfeng Yun ha scritto:
> > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno
> > wrote:
> > > Update the names to regulator-usb-p{0-3}-vbus to fix
> > > unit_address_vs_reg
> > > warnings for those.
> > > 
> > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for
> > > MT2712")
> > > Signed-off-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@collabora.com>
> > > ---
> > >   arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
> > >   1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > index 638908773706..d31a194124c9 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
> > >   		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
> > >   	};
> > >   
> > > -	usb_p0_vbus: regulator@2 {
> > > +	usb_p0_vbus: regulator-usb-p0-vbus {
> > 
> > Can we modify dt-binding of fixed regulator instead of changing the
> > node name,
> > since all nodes using fixed regulator may need be changed.
> > 
> 
> These regulators have no MMIO, nor need any index, so it would be
> simply
> wrong to change the binding and leave them as they are here in the
> devicetree.
You are right, then many files need be modified?

Thanks

> 
> Regards,
> Angelo