Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2182851rwi; Fri, 21 Oct 2022 00:17:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6nP6LBtb/Xd5LooSoqlgnWj7y1H/Gj4dhcqBVAPWrbtnV8okHOMG84rjf5x22kEYiuSSia X-Received: by 2002:a05:6402:1052:b0:459:2c49:1aed with SMTP id e18-20020a056402105200b004592c491aedmr15908031edu.212.1666336660436; Fri, 21 Oct 2022 00:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666336660; cv=none; d=google.com; s=arc-20160816; b=a35YXNcWRDMGzO7zmEyWU2tV0lb0z+EsysNOMYADhdKdt8YmndpvMDTH/o6f8jEFim 7KBydpR9xop/YOlUyxf5MxuVOtal3ZB1n314/ALX1T8vBdbfSbw2L3SUcb5C5De5Od4m TVe5hAwH+ZGH9FodDB5UlnQfLQU+nYDxJRdtqf0oAUGx2Ugo4IpcLbT4W5yrjuCO7jJF sKrwLVnmG3nPmAW0DRnrDaluQWB1lAtpU857C62VA7zkP85DubI8XcPpd6+Qrfe3LChU M4q0+mc5P7NEyWF5bg/hJVdThfliujCiSRkSgPS1FjqD+oV3f1Z5NpPp2a+f62Z11gvH fj2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:to:from:date :dkim-signature; bh=bubvLQWB1sUU1KkIeLghnVMfGA+k2ZKujgBoivY4kwc=; b=rt6L48NGyx59xrNxVKY28lPA6VI1R0v2PC2rGC52+mBgXPv3sQRQTinAoQJiXlyjJA AgmskPgPfH9pRVmYuSN9hnLLcDsuIRNdSmD1CDErAtyJOKUNwCcD4A1y/rCneiGSHUkT PPX3mw/Zq5reI67Hjw/3XwTDfQ3TvMcJ9mE1VR9QVTuvR16TvqvCaOwtEeCaIQRfKn6H E4n9AGt0jxkpSIgnD/AsTOAM2ebJqZ+GOpqUETEZW2mmeuWYEE0FpzsC4OEyU9pIrXvV PPKpUcH2toIwZKkjGj1i++o06AQISag/N2Eayz0GSiT67sIPQjT2aBejPK7VV87WvYfe M4QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U1i1XfFX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne41-20020a1709077ba900b00780328a0868si19479425ejc.110.2022.10.21.00.17.14; Fri, 21 Oct 2022 00:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U1i1XfFX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiJUGqp (ORCPT + 99 others); Fri, 21 Oct 2022 02:46:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiJUGqn (ORCPT ); Fri, 21 Oct 2022 02:46:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C5DD1AD6AD; Thu, 20 Oct 2022 23:46:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD6D261DD8; Fri, 21 Oct 2022 06:46:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7097BC433D7; Fri, 21 Oct 2022 06:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666334801; bh=bubvLQWB1sUU1KkIeLghnVMfGA+k2ZKujgBoivY4kwc=; h=Date:From:To:Subject:References:In-Reply-To:From; b=U1i1XfFXvs5/ikSqtUqexz3VEzckcOavlygbiHeknTA6wQmXHOV7NEtnDlPUqqcqP 0kldxzprBKJPAH4IUucRSW0o4Q4eiKcIH9UXW/cgqIAvX8fQ7Yx8v++QnRQtvjXJXw MG4bGCBzqhl1rILnJFOiF9KqXe4r5E1tvQV1oCkdOTSQVJon8BlvsMyz8yk4N4996W ahhOEHPaSiiaLbTySwCY+NmI3debWltVX9KLqOtvyJXpJu2d+0dFT6RQRaymLuoU7m Siv/eP7jl1E4AJRd3r5IjaYx8sU9c9DuO6CAzuUhfRe6jyrbuswrlagCYYkBGmNCQv pJqXIYB4A1uYQ== Date: Fri, 21 Oct 2022 08:46:37 +0200 From: "wsa@kernel.org" To: Asmaa Mnebhi , Ren Zhijie , Khalil Blaiech , Vadim Pasternak , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] i2c: mlxbf: Fix unused-variable warning Message-ID: Mail-Followup-To: "wsa@kernel.org" , Asmaa Mnebhi , Ren Zhijie , Khalil Blaiech , Vadim Pasternak , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20221009133822.254122-1-renzhijie2@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="52vh7K2DLLEJAkC1" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --52vh7K2DLLEJAkC1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 19, 2022 at 09:44:21PM +0200, wsa@kernel.org wrote: > On Mon, Oct 10, 2022 at 12:00:09PM +0000, Asmaa Mnebhi wrote: > > Acked-by: Asmaa Mnebhi >=20 > You need to add your email address as well. >=20 > > If CONFIG_ACPI is not set, >=20 > Since DT support is gone now, shouldn't the driver actually depend on > ACPI now? Then, we could get rid of all the #ifdefs in the code? This has been submitted and accepted meanwhile: http://patchwork.ozlabs.org/project/linux-i2c/patch/S229897AbiJTWqk/2022102= 0224640Z+957@vger.kernel.org/ --52vh7K2DLLEJAkC1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmNSQE0ACgkQFA3kzBSg KbZ8Og/+MUEdlilgl4Ix9MktDfryIigT8PrboTHu/jRzGOjDuDrrHhLQnYETe0xW WoIVq+CBaaeaoP547SoPzG8XbxKmfDMx/gHHmcZu+R87b9PAwJhwLU35Y9tVtCak t1L1mewiEaQqNYE30vRVhIyFOdobP6HoV5V9DhioP0SahFTh2rbRIjshGkq4yZ/Q iRY7Xd3ktt0PKb5jWWOMudcLppDS6Mej/Y1A2Rg1E2HfNgVG2Q5Jkpd7y+47EMKl szShJHi3ljiKVg1si3G7ynl14rSoSz3AZOIO8OSqhW8jne8AEh1Vt+CjcqW/ysZI PzX55UTUsJGIIoM2McLX7Ny3Gw3tWmr6WUOyPsiqK6yA+fXEomcg1PiKpAN2sF7v K+PlxA+C0Xyow4s+Te8poektujFLPgM0vC2mJWB39uG2G5wVGGJ4cZGWaPBJ2HJe 5Xmen0Oy7ueUr3/24xtBN6PVRQquLLtRoUjrz0b3ZY0fIf8HN+0XxanLfA/WdBda mI0s6QGfKUoFEEqTD9Pao34ULRN0h+vWbqq34IVzsMvWZBM9yy1BNRF0jyhQh0Da +bN1XsaXtnHVh+wT0SnQFkcg5lO3Wd990PocVp17ZxRPMwotuZd8FzUyHbBK1Tw2 MqBYTynrTsN2T82mJLCceZenB8J7kcryjkqb194mbD1yk8yJ338= =Z6Ja -----END PGP SIGNATURE----- --52vh7K2DLLEJAkC1--