Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Wenchao Chen <wenchao.chen666@gmail.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "orsonzhai@gmail.com" <orsonzhai@gmail.com>,
        "baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
        "zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "kch@nvidia.com" <kch@nvidia.com>
CC:     "CLoehle@hyperstone.com" <CLoehle@hyperstone.com>,
        "vincent.whitchurch@axis.com" <vincent.whitchurch@axis.com>,
        "bigeasy@linutronix.de" <bigeasy@linutronix.de>,
        "s.shtylyov@omp.ru" <s.shtylyov@omp.ru>,
        "michael@allwinnertech.com" <michael@allwinnertech.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "megoo.tang@gmail.com" <megoo.tang@gmail.com>,
        "lzx.stg@gmail.com" <lzx.stg@gmail.com>
Subject: RE: [PATCH V2 1/2] mmc: block: Support Host to control FUA
Thread-Topic: [PATCH V2 1/2] mmc: block: Support Host to control FUA
Thread-Index: AQHY5R8OLfuUh6VcvUiWPq6FTK+Zba4YeSHw
Date:   Fri, 21 Oct 2022 07:53:40 +0000
Message-ID: <DM6PR04MB6575FC4EF5E3CF08A90279F7FC2D9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221021073025.18831-1-wenchao.chen666@gmail.com>
 <20221021073025.18831-2-wenchao.chen666@gmail.com>
In-Reply-To: <20221021073025.18831-2-wenchao.chen666@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CTMwHmQg1qDiubggj9u0e6lgxv1tmRCV/VPrdDeynXKVvjaBAKr1EBAF8HQv?=
 =?us-ascii?Q?5i3rl8mHlZCWBTi1nRoCQsfrSaBQTQeSmRqdZhedHjXv0sTYQ2VOM/qvhYcy?=
 =?us-ascii?Q?dwAnQknS1wik106B/gK2OCEPnMUfm/nn22OSjazbF/yoBZAGag8nT2fjLVOy?=
 =?us-ascii?Q?oIss00kH9SvF55esl0lbEsN8f0ioTFPVXGjjDMEvkLtS9Z8Y34V4cePzyrKn?=
 =?us-ascii?Q?leO9JXHdTGR692i4waqglpkDw0FLx8soMNHxkyUb7+bnCOv9fYU95Z21vIuX?=
 =?us-ascii?Q?mjIWwTjhsLIgrd0kGF4LWfXAs3R1zDCRMERmvuZLbKPLW8yVuTU1Pvz/CtJz?=
 =?us-ascii?Q?P1WM6TeuEKMhbwLdYyAnH2OnrFBKMLSeDIoirCOI/koeYmovFPy9OaXT2nP3?=
 =?us-ascii?Q?FOKm2BYYkoczTP0Wzbo3dTyMQuVCaNlR2XA39c/pLySyGFIPRr7+jwA/q2eb?=
 =?us-ascii?Q?qL8HvChk2PYECPgBY3g5RGxiI64uZWOY6AzL+yT2IHuvvNcGryPP+ABbRviJ?=
 =?us-ascii?Q?BN+9B4swEY+XfPjfBZOGbLs6HzB2Rl6VljW80U47JUtW3figV1Erk0lsBKOO?=
 =?us-ascii?Q?IfV1mZ8eUVsXJhjKyEUz5+frmlmJ9N3onSTe4VHdX2nMIGRlAVY7+gHxgxHh?=
 =?us-ascii?Q?PHzvDlfuG/1Q1jTNpyvX3kq22DYDPeboxGRKYpBxDZZ0Ou4wngPvsK0e+o+l?=
 =?us-ascii?Q?WcpSSHGgk+mnWEAnFqRG9KotV8LH73RRsIEVismyffsB7sRdIaK1zE64hhnM?=
 =?us-ascii?Q?D27/CNSpNFIO6LUwbxaeSaOo98hX23NqDQrs/QVP6oFvIEr2rZWB+d1Y1tad?=
 =?us-ascii?Q?P/dy41OCJdoZGZtd6VEnPXzU0TZSw0CXieC1GUFcIsp3O9cakmVg6ePEeIj7?=
 =?us-ascii?Q?s6GD0gADY/mkb9GrNTB4+47tLuC9ku7su3v8r5PVTzWlMbQUi59eQGaUZmMN?=
 =?us-ascii?Q?CLOTZQRzuBI4JK6swPux8NiRbRqCyph2Yoyg1EcMg+AQh6GDhd4ihlfyjgAg?=
 =?us-ascii?Q?EpiBSwob61YTII1yYFnUARwbF7EPiVkb1svU5Bl+G3PJi7xRRhMkSNVE09tf?=
 =?us-ascii?Q?eW9SioZky41Xq0QSX0op2ECT1IPPb6WfGGCF9yKiZBVXDEmDqIut4ZIdIEgv?=
 =?us-ascii?Q?ndSURusQxYeMDMsoLMDiMa7t2alke0qhOF70MJlQsB/Ig2xG3PvbIOduAyWt?=
 =?us-ascii?Q?pAPOlbWZXBgXoNZQAKft9FWb0cg0lTeo0FOxEVY74tBTz5FdzKsdQipNfA2D?=
 =?us-ascii?Q?R0U9rbVtb4ejqbBV4i0A3dm2qnOf6n5K2RiFqHIgVsVrvr3l7KTUpF47q5NG?=
 =?us-ascii?Q?8bQZSHvet4j+O/IAifYwffzzPSWjmDDYkqel6H6uEmGbslU4H6k8t6szVB61?=
 =?us-ascii?Q?SmYi3vugRT+yeJ6hs3d/lIotfaqqy/TsLS1JeIN2DUh4PjCoJgnJRY42dnKb?=
 =?us-ascii?Q?GZbBrW6wTAjMNqeZWD/WCWOyP5jDi7wpM26M3nWwb5NG7IEIV4tFNIiMyoxj?=
 =?us-ascii?Q?DDEJiD3adD6y4md5WShjRNXMTMx4DFa0F/t0lk78x5dwrbINHLm7gQSwkqhY?=
 =?us-ascii?Q?d+U1jLxcugNaAdzh7vG15vMI60cmGqdx0qfKJrkb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e325c50-cf8e-4cc6-9b71-08dab3395e96
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 07:53:40.7157
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ozdUqBG7WwlK7Hc2+H1epjr3E4TQ7Drrl1iVcsT68B0jA88ZOpOBQD51MtV5DxZTW8Gw6j4+CzOcg7wFwtf3zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8077
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Wenchao Chen <wenchao.chen@unisoc.com>
>=20
> This patch introduces host->fua_disable for MMC host controller.
> The host can turn off FUA to improve performance.
>=20
> Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
> ---
> V1 -> V2
> Address Chaitanyak's suggestions
> Address Avri's suggestions
> ---
>  drivers/mmc/core/block.c | 3 ++-
>  include/linux/mmc/host.h | 3 +++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index
> 54cd009aee50..333e819e077a 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2490,7 +2490,8 @@ static struct mmc_blk_data
> *mmc_blk_alloc_req(struct mmc_card *card,
>             ((card->ext_csd.rel_param & EXT_CSD_WR_REL_PARAM_EN) ||
>              card->ext_csd.rel_sectors)) {
>                 md->flags |=3D MMC_BLK_REL_WR;
> -               fua_enabled =3D true;
> +               if (!card->host->fua_disable)
> +                       fua_enabled =3D true;
>                 cache_enabled =3D true;
>         }
>         if (mmc_cache_enabled(card->host)) diff --git a/include/linux/mmc=
/host.h
> b/include/linux/mmc/host.h index 8fdd3cf971a3..16a5bee3eeae 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -517,6 +517,9 @@ struct mmc_host {
>         struct blk_crypto_profile crypto_profile;  #endif
>=20
> +       /* Host FUA support */
> +       bool                    fua_disable;
Why do you need to invent a LLD mechanism, when you already have a block ap=
i (QUEUE_FLAG_FUA) for that?
Which is actually misleading, since /sys/block/mmcblk0/queue/fua will still=
 reads 0.

Thanks,
Avri=20

> +
>         /* Host Software Queue support */
>         bool                    hsq_enabled;
>=20
> --
> 2.17.1