Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ed00686-4355-7f3b-4c73-cc6b5a0317b3@virtuozzo.com>
Date:   Fri, 21 Oct 2022 11:02:47 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v5 6/8] drivers: vmware: balloon - report inflated
 memory
To:     Nadav Amit <namit@vmware.com>
Cc:     Pv-drivers <Pv-drivers@vmware.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "kernel@openvz.org" <kernel@openvz.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <20221019095620.124909-7-alexander.atanasov@virtuozzo.com>
 <39FA848F-290D-4110-B27C-8822377E6AA5@vmware.com>
 <627d2c7f-8ba0-2910-a98d-ef42b9dd5ade@virtuozzo.com>
 <CEA2F8DE-DA49-4DB9-95F8-D0864048353C@vmware.com>
From:   Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <CEA2F8DE-DA49-4DB9-95F8-D0864048353C@vmware.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXhiNGcwVWJBZ21ROFlGdkQwRXpNdTZFQ1lzaWp1dDFwQTN2K0dZeWRlTm9w?=
 =?utf-8?B?ZWgvVW1BL3FXS0Iva1pVN3ZEbXUyVG5IZkpwcnZCU3lXeWpPVkRSYUo5Y0hS?=
 =?utf-8?B?OGlrV0MxQ3BlOEZiNjdOQWphcXI0R1RVL0tQMFhOeVphRXRmRm8yVmErYlJM?=
 =?utf-8?B?SWtLaWd2RlArNGFRZ21xdVVkeW1MTCtoRnRYcWZWdHZiSDcvOEJ6dXQwRnhP?=
 =?utf-8?B?MXRuNWdrOWgrQnB4djdkcVQ0bmRSazV4UjRaRDZOVjZGNjc3NFZKMTd6QlJQ?=
 =?utf-8?B?RVF0ZzEza3VCSGl3TzRZeTF2elBkbGlhZWtFY055eElyMWFGU0JlNFczOHdG?=
 =?utf-8?B?S2VqVVBuWmpKOFVHK0lERXNUY29uemU2ODZVcXFHY1o1TFl6UnRpQ1lqN2o1?=
 =?utf-8?B?NHFFOTBNcXYwbjFjL1o3em91R1QyZjFXLytnOTJ4TytoZ0VuWEV0b1lLYndn?=
 =?utf-8?B?OTJmVDQvMTNuVzJ6REx1Q3lnTjhpSEZJLzJjWEx0cGRreWZNdU95VC9PdWFm?=
 =?utf-8?B?QmVRWUFxZ1dMeWhmTVZKUE5GMUFrVXJPZTVyWGlCdWY2dXZZRFBGQzgzL1RP?=
 =?utf-8?B?L09sL0RrbnVLejJiUWRXaVBaU1RHY2lyZ3lXYjFxSlRCdHMwb0JJaE03eDFQ?=
 =?utf-8?B?aWxBaXJYbEJKYWJKQ3dQS0Jha0ZHS2JoTGpyY3hkRkZoNkZ2RVJFUytwOVlr?=
 =?utf-8?B?TDlaQnY2dlVwM1MvN2NQSVgxamliMHNINGZVMURwMlY5RE8wQ1VJazVub2hX?=
 =?utf-8?B?b2ltYTJrVzRDUFRnRmZvV056dnZ5aG1WdncyZE9CV0Q3SVJpQ040V25JQWly?=
 =?utf-8?B?OHN6OXJCM3krc0pOb0FiM3JEendCWG9jVXZJQ1pNK0ordGdkSU5DbUsvckQy?=
 =?utf-8?B?RGR1RUcvSnFrSy84OHNoc0J0eTVuZlNDK2R4S2JiK1J0djlUK2RzSWdxNkQr?=
 =?utf-8?B?OXZDMGFnMWdNNU13V1FKWUFORzhiUVNDQi90VDc0QTVXZWMycTA1NUNOd1ox?=
 =?utf-8?B?Nk16bDNnNVYydWdaYUd4WUdvUTQvcmlZSW5WWHlwMTh0SnpxYzRyKzJUS0gz?=
 =?utf-8?B?SmNBK1A3Y29OR0l4ZnIvWEZ4SUlBdmYvYzhlTlJBOHpYaTVCM2FiMWlJNTJP?=
 =?utf-8?B?QnBMeTJtcmcvOEt3d2NwcEJzbFhvSGpubU9EaUg0bk1XYXJJeVhtdEtPN3lD?=
 =?utf-8?B?MUNwdDM1VS9ZUWdjZnpVNEh0OE14YkxXNWZsdWhGV1BkdUYvcmxJTzNNQUFC?=
 =?utf-8?B?czRBd1FlNlRHQ3ZMTmRZbU8ydG1Hb1BsMTROdHJZVUxKTTl2c0NDb29wdWRs?=
 =?utf-8?B?NEY0QmJWemhDNzNKT0sxNnN4MmhPblZ1U282VnRITGUvVFNBSVQ4ZlNWeVJW?=
 =?utf-8?B?cEl6WjdHeUtFOUx1cEJOdDhxaDRYM1daUmMrcHJpbjlSL3hOaVRLRVE4SEpw?=
 =?utf-8?B?MW01VXFXeXJTcWpFdTR1YisxMmU0SXA1R0FpOHlGUDZCdHRWaTVjOGlhSm5L?=
 =?utf-8?B?QkxCYnY5Y21sMTE2ckdmN0JDanhGcGJqai91a2pVbzcvUkFCQlZPYXFDM29P?=
 =?utf-8?B?dGtuRG5haGJDdlFkdndkN3BlS2FVOGJjV1NXbGsxYUxCRjdGYkh5UmRrQmVF?=
 =?utf-8?B?S3Y1dTdIYjByT2VxNE04RGZ1OEtuWERLenNWbWVSanZWMzFjYTB1ODVWQ3JS?=
 =?utf-8?B?ZHVOVTBseGdxZURuM0c1RnhmVnV4UzZqZlllVVFJc2dnUFlVQm9RNTZWU0l0?=
 =?utf-8?B?LzFvUURCWEVXcWNSby9hOHZuMHAwVFZKeUpRcG5lemRRNlR2ZzVWK0pzall5?=
 =?utf-8?B?TDh0amExSXNyUkJNUC9WSENwZWRIQW9aUE1yM2ZqSW9QdUZMb3R1KysyR1U5?=
 =?utf-8?B?SHhmdXpULzA5QVkyUGM3RDhETk9wV29oTU0wZnA5bEJONWs2bDZ5NTZwMkJ1?=
 =?utf-8?B?TnB2MFA0MnVZYVcrUjBGc1ptUHVXTS9TUWRnZ2plZmc0NUhWY3FZU2VEV08y?=
 =?utf-8?B?L09iQ2xpM3ZHREw2b29qaU9XcHhkWHVNVlpackMwVHBHeVROeWlBa0dwUm01?=
 =?utf-8?B?Ym1CYnRVdjRoeGVydWdYUFBpRS8yZ2RtNWdVQTRQdGRWWWkzd3hoaVVrSHI2?=
 =?utf-8?B?RDN5RmJEMWlFWFRPdXVpTDJYdmNjUnhEV3JDWjZBODMvdFJYZmxzb2o4bTA5?=
 =?utf-8?B?ZVE9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0080ca26-183a-47d6-3184-08dab33aa609
X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4758.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 08:02:50.2848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P/CPtEiJXQP9lgZLGGUyjwUFcyAWsSkwHFqjestKh83UhRfJKlHYRVPtHaH/iIE1TkUcJ0hfcaxILMm9IwiHhcpXLd4gcV35GdBPhsdZL8zxfpAQJMTjyccti9svnvVe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8428
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21.10.22 10:31, Nadav Amit wrote:
> On Oct 21, 2022, at 10:25 AM, Alexander Atanasov <alexander.atanasov@virtuozzo.com> wrote:
> 
>>
>> Ok,I will move it before the enqueue call.
>> But are you sure about this the reset?
>> vmballoon_reset(...) is called only from vmballoon_work(...) which does
>> the update ? what i am missing?
> 
> My bad. But when the module is unloaded, vmballoon_pop() is called.

Yes, i missed the unload -  i will just set it to zero there.


-- 
Regards,
Alexander Atanasov