Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1dd08ecb-2b08-0556-64ac-3f39a8fec76c@quicinc.com>
Date:   Fri, 21 Oct 2022 16:21:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning
To:     David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
        <ziy@nvidia.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>
CC:     <mike.kravetz@oracle.com>, <opendmb@gmail.com>
References: <20221021051936.15346-1-quic_aiquny@quicinc.com>
 <20221021051936.15346-2-quic_aiquny@quicinc.com>
 <d00d6e23-6e4f-074f-67c3-5f00e8a913d2@redhat.com>
From:   "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
In-Reply-To: <d00d6e23-6e4f-074f-67c3-5f00e8a913d2@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/21/2022 2:54 PM, David Hildenbrand wrote:
> On 21.10.22 07:19, Maria Yu wrote:
>> When !CONFIG_VM_BUG_ON, there is warning of
>> clang-analyzer-deadcode.DeadStores:
>> Value stored to 'mt' during its initialization
>> is never read.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
>> ---
>>   mm/page_isolation.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
>> index 04141a9bea70..a7a478a22123 100644
>> --- a/mm/page_isolation.c
>> +++ b/mm/page_isolation.c
>> @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long 
>> boundary_pfn, int flags,
>>                         zone->zone_start_pfn);
>>       if (skip_isolation) {
>> -        int mt = 
>> get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
> 
> __maybe_unused should work as well. Was that considered?
> 
good idea.

-- 
Thx and BRs,
Aiqun(Maria) Yu