Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 11:08:57 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Kevin Yang <kevin_yang@realtek.com>,
        Kalle Valo <kvalo@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.0 681/862] wifi: rtw88: phy: fix warning of possible
 buffer overflow
Message-ID: <Y1JhqYncRRKdwcwR@kroah.com>
References: <20221019083249.951566199@linuxfoundation.org>
 <20221019083320.063888989@linuxfoundation.org>
 <1ab422def27d43e1866b470a3f9d24aa@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ab422def27d43e1866b470a3f9d24aa@realtek.com>
Precedence: bulk

On Fri, Oct 21, 2022 at 12:12:29AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Sent: Wednesday, October 19, 2022 4:33 PM
> > To: linux-kernel@vger.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; stable@vger.kernel.org; Kevin Yang
> > <kevin_yang@realtek.com>; Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; Sasha Levin
> > <sashal@kernel.org>
> > Subject: [PATCH 6.0 681/862] wifi: rtw88: phy: fix warning of possible buffer overflow
> > 
> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
> > 
> > [ Upstream commit 86331c7e0cd819bf0c1d0dcf895e0c90b0aa9a6f ]
> > 
> > reported by smatch
> > 
> > phy.c:854 rtw_phy_linear_2_db() error: buffer overflow 'db_invert_table[i]'
> > 8 <= 8 (assuming for loop doesn't break)
> > 
> > However, it seems to be a false alarm because we prevent it originally via
> >        if (linear >= db_invert_table[11][7])
> >                return 96; /* maximum 96 dB */
> > 
> > Still, we adjust the code to be more readable and avoid smatch warning.
> 
> Like Pavel mentioned [1], this patch is to avoid smatch warning, not a really
> bug. So, shouldn't take this patch. 
> 
> [1] https://lore.kernel.org/linux-wireless/20221018093921.GD1264@duo.ucw.cz/

Ok, will go drop now, thanks.

greg k-h