Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2310946rwi; Fri, 21 Oct 2022 02:17:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hh+BYYmzeDJFSJjh2LMrHvsRSY/vw3v4V2eenfn8sayNOXVQGbMq9jWLOZMSiA4cxCN7j X-Received: by 2002:a17:90b:1a88:b0:20d:8df0:ac63 with SMTP id ng8-20020a17090b1a8800b0020d8df0ac63mr52662806pjb.206.1666343825334; Fri, 21 Oct 2022 02:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666343825; cv=none; d=google.com; s=arc-20160816; b=mr/rt+GQ9XQk8EZ7A2lnbC1z46k+yIRqe5toH2Fu2ehOyGzdov5h8oa6C1xcG2kgf6 C2LtROL68jFoOFF5m3nMFDC0IA3vFk6BC79yd9GEt8EnZkNsbjJ0ykEiscxegEhTcCLX NXKoXMAqH2Xqho0XiXPUyIiWOXIBT+5fhFY46UkOR5nNpkAvVUSP1Is5Ly5krnBwEY1d dPhYSHrLBiKEEZcnDXLiQH13aNHTFhT2Mg27qGFry2/ewambFLAvHBifeqX+qfF/OAdD 3T90j8ZJ2NgADCRgn1nUGKF08lJTCdJjz1D2bmD50kmHDM6HQAujk7ZlGIt38focwyOZ XpRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=st1gmxlORn5gNS3mKnR7YEfKeeexJYLjJJkMJ2yubB0=; b=L9zr6bZ+yjo3aPjoiKPLgJsMaNh5RH3cURe6849uWZB4vPn0RgbEkDqhPYfoUamNsL df423D8246IQ8BXPbyfKuqLIZbeT+1QcLHOJDJEbLHotKSDvJyKDsK/oUaWfrsYXDGhO AfZ05aofrhNoFEfAW9ouLW9J7kXxhtnegbo/0xJWCvWPuh6NqrMfhE3ohZrMcbtk6ewL Bm78Z7eSit3iyoQLe28DxHVodUWrlT7iLotQKBNe5rZGFF/pLleOjLOAxfED3yspbOmd goDYmHFoEKXNJ6MT0LwjJum6CrXY6rtX+q+L9GzGUNudzKCIWjxGDZnmXA+ZAkHUCg// RvlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 139-20020a630091000000b0044e12bf36e1si24912978pga.557.2022.10.21.02.16.53; Fri, 21 Oct 2022 02:17:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbiJUJNZ (ORCPT + 99 others); Fri, 21 Oct 2022 05:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbiJUJM5 (ORCPT ); Fri, 21 Oct 2022 05:12:57 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BD1D2570B3; Fri, 21 Oct 2022 02:12:31 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 48AD42019D; Fri, 21 Oct 2022 11:11:29 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9l94Wvjqj3yJ; Fri, 21 Oct 2022 11:11:28 +0200 (CEST) Received: from mailout1.secunet.com (mailout1.secunet.com [62.96.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id CD98720189; Fri, 21 Oct 2022 11:11:28 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout1.secunet.com (Postfix) with ESMTP id BE90980004A; Fri, 21 Oct 2022 11:11:28 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 11:11:28 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 11:11:28 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id ADD1B3182AD5; Fri, 21 Oct 2022 11:11:27 +0200 (CEST) Date: Fri, 21 Oct 2022 11:11:27 +0200 From: Steffen Klassert To: Christian Langrock CC: Herbert Xu , "David S. Miller" , Hideaki YOSHIFUJI , "David Ahern" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "open list:NETWORKING [IPSEC]" , open list Subject: Re: [PATCH ipsec v7] xfrm: replay: Fix ESN wrap around for GSO Message-ID: <20221021091127.GQ3294086@gauss3.secunet.de> References: <20221017063447.1816366-1-christian.langrock@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221017063447.1816366-1-christian.langrock@secunet.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2022 at 08:34:47AM +0200, Christian Langrock wrote: > When using GSO it can happen that the wrong seq_hi is used for the last > packets before the wrap around. This can lead to double usage of a > sequence number. To avoid this, we should serialize this last GSO > packet. > > Fixes: d7dbefc45cf5 ("xfrm: Add xfrm_replay_overflow functions for offloading") > Co-developed-by: Steffen Klassert > Signed-off-by: Christian Langrock Applied, thanks a lot Christian!