Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2311385rwi; Fri, 21 Oct 2022 02:17:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cF4yGpqIV9LzO8w1xI53cQPjs4GxEn7XupH3yGHa3pNt89TU2PIa+niNTCvrE9bFiKVr9 X-Received: by 2002:a63:5946:0:b0:461:e1b9:c5a5 with SMTP id j6-20020a635946000000b00461e1b9c5a5mr15602362pgm.56.1666343865049; Fri, 21 Oct 2022 02:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666343865; cv=none; d=google.com; s=arc-20160816; b=N6HFfNGf3T+xs5Vjl61qlhoQ/fa0ePuW+K5dNA68AEOreomsphpsMHv+0G9OLJvRVo 1UpO9UvhjSceian6X0+S75BsGLkCK5/yXo046RHR9A4AWPwJ4Ki+KcYZ/t6aL2XzhyQS qL47B8JtKIIMddzv/FpWPLqdr1dqvWHKdXk4x8aQ0OZcfh12NRMkTwEtHo7MdtMebnEn a3lwwd/eeFwJl4R1cCP190oq9jbbnhPErB71e5bfp7ZCJkdjgcIq1J9PAyApq5jn1VJK xIolIwEbFJO6Y9Dg937umws6aBZj54cPo4rGXNd+NHNY3SW1T87NFX3aOchDF3Mqdom8 oaXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=stK0AWcx/AZ01b7n2KWQ9iHqc49fEITiVHxzybb+U1o=; b=QGp2gqn3gjxNhSN8JCPRgMvtKBv2/3yUjkFhHG562KDPoNlU5BUbCkum1pVJ1ukhvg Ga0HgAwOY6fj5M5oVONx9haH5mpOWO5xjPV4ORk4oFslgznrTFQn3p3mlVh+HCE/duBc gYZpryGJeqwqLTJgNj+MpLTXbH3RT4LzXga71R1jq9Sdp2NIqb6ST7iFhpb8zhZVXJ3a mUtXRpAcUZcULZ+qLdRUe8gJ3T7OqHJ8CVi1ifrX8N8mAd4wIv2iLeBpDca8Eb213yGl bBvuCy5Cl8ee90+OVh8pfhmhgt6hj40lUU+mIPcFINtOo1oQFyuFhg8msIWftuB0JUi+ 7yjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cskSjnwy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c13-20020a170902b68d00b0018040bdb798si22990141pls.242.2022.10.21.02.17.31; Fri, 21 Oct 2022 02:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cskSjnwy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbiJUJQv (ORCPT + 99 others); Fri, 21 Oct 2022 05:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbiJUJQn (ORCPT ); Fri, 21 Oct 2022 05:16:43 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA0B61EA563 for ; Fri, 21 Oct 2022 02:14:29 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id f8so1640416qkg.3 for ; Fri, 21 Oct 2022 02:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=stK0AWcx/AZ01b7n2KWQ9iHqc49fEITiVHxzybb+U1o=; b=cskSjnwyJ6vHbgNG9yaijetiCA+RXGT7xI8Cp94+Rslp78do1CSrEKBFvkE7yzTaEb g9OQhPw15/9gQWBB+7QkpcnVSKo+ogPdChR0uxC19MJsRS9BlcLuWLOf2FFc6QbzA/DE Tf/tDKM0DuLzZgkKLqPu2fr1Y7kBpha/kjmbnU3ORoji7WNwkFVahWUSgpFApHfnIUSS Dircv1QvpkYHxk6BplB+GbekZVzQmtmucBwbPf46V72kMfFKa2lTwHyY+EcEViPVc0pO kEb0aec3tRZj4rZqKzklgGc+CSwohgpN5HsLEF0IH2ymj04Tl5HfqAv8pjCp4B69tHYG l5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=stK0AWcx/AZ01b7n2KWQ9iHqc49fEITiVHxzybb+U1o=; b=rmgmcLCXOUAzTQghGw/pPARxZfeXTEwzym3v9SfhtxdtKyBFtKvXNjihSfubu/k8Kk zsZeLcO9TDkGMC3Czzu03BlI/uk1qSiktMmDkwgYAH2tmBNkXE7ECLKDmkLBwA6Pes/k 9MqxLFEr96MsY3L26X5AfzrUXOwdPO4vW5inaeHuo+XZ+Uwg10Vv3ATY6Kav2Lwh1f2v RujhW6/StUfj2vXdR9YzbKYVxxpaUK8tCr5sHwrMChbs9/ls1Q5a1gTi0YBa9pn4Vw+r 27kgH++uLEBOi3ICdjznDy1UP8o/0dFYoOMW2puypYHJAxosszv59U7EJJxJzQcK4zVF vxwA== X-Gm-Message-State: ACrzQf01dKj2s81rumTRGuUBeQmjLHrVvpKX3iPcbsJZVRJsOxVIbhmI Ntvh3JVuWdpt+H/L8mWQcTMIGn0M1ZxqfRn0GDpyr9fYQVI= X-Received: by 2002:ae9:e848:0:b0:6ee:92d5:94e4 with SMTP id a69-20020ae9e848000000b006ee92d594e4mr12931849qkg.404.1666343668326; Fri, 21 Oct 2022 02:14:28 -0700 (PDT) MIME-Version: 1.0 References: <1666318661-11777-1-git-send-email-u0084500@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 21 Oct 2022 12:13:52 +0300 Message-ID: Subject: Re: [PATCH v2] mfd: mt6370: Add the out-of-bound check to prevent the null pointer To: ChiYuan Huang Cc: lee@kernel.org, matthias.bgg@gmail.com, chiaen_wu@richtek.com, cy_huang@richtek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 12:02 PM ChiYuan Huang wrote: > Andy Shevchenko =E6=96=BC 2022=E5=B9=B410=E6= =9C=8821=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:34=E5=AF=AB=E9=81= =93=EF=BC=9A > > On Fri, Oct 21, 2022 at 5:17 AM cy_huang wrote: > > It looks like you randomly cut the trace. > > It's not what I meant and documentation suggests. > > > I checked the submitting-patch.rst. > To satisfy the requirement for 70-75 chars per line, I only keep the > important log. > > May I ask what you mean for the 'trim'? > Is it 'Still keep 70-75 per line and cut the characters that's over > the limit to the next line"? > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#= backtraces-in-commit-messages Have you had a chance to read this section of the document? --=20 With Best Regards, Andy Shevchenko