Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: j5CpfQ/c+Odbsbh7FdCXH98esJIk1/aTwTVx9T3WEpiBH2Y3d+QYI8acfsR7VILzp2TZ+RPHkA
 FbAUtF3DHCNVy/IxmbtfaZPvGAkIUcprNixUltl3PRji6Uj/YRNxCNbM2TtpRoW0M+FRsJQmWB
 9XXnGt39YepnaFUo9qfIbRO8f01qCvHWxo83EL063IRrSWkNEbphqf4MopBWdg9E+GCDofWuAy
 pylybia+G1VdsYebdFXLvs6yJC61+TSeLiG0t8myD2QxuufUynaRpLyI2fCi9meoVVYWnwNrZ1
 rz+J5jp3EKrhxGu35pcLlC6u
IronPort-SDR: SaO/QqUVbQYce2+h9caYVI4z66f/9iPos9pT+daXgXn8yLJWFNcoVmBaXctCHkyruKqbKXpHGS
 jc/VvdfEd5sy5BdmTfYqYZYGAOBH8z9jL3YuHUHXLygfjttcNKpFa79r70gCB0/Fhq/qpKd4l9
 0Rq1+nmLryAlMpQY3i3Se+xfgn0v0gBXPRoTf/Ygq7psQhev3J27umpHDe1/Q4zaKEVjcR/vpJ
 UcnEniNtjkbHw3snErW0fCrcQCXeDjw+XaJdOjEdCtFcOQJ0uL+0M+3z41Cpksp/Ri0PdZEQs/
 AOk=
WDCIronportException: Internal
Message-ID: <e62600da-4a1c-f797-8fdb-2938ca58f25e@opensource.wdc.com>
Date:   Fri, 21 Oct 2022 18:44:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH linux-next] null_blk: use sysfs_emit() to instead of
 scnprintf()
Content-Language: en-US
To:     yexingchen116@gmail.com, axboe@kernel.dk
Cc:     kch@nvidia.com, johannes.thumshirn@wdc.com, bvanassche@acm.org,
        ming.lei@redhat.com, vincent.fu@samsung.com,
        shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, ye xingchen <ye.xingchen@zte.com.cn>
References: <20221021085446.414696-1-ye.xingchen@zte.com.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221021085446.414696-1-ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/21/22 17:54, yexingchen116@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with sysfs_emit() to simplify the code.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/block/null_blk/main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index 1f154f92f4c2..5317ef2ba227 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -255,18 +255,18 @@ static inline struct nullb_device *to_nullb_device(struct config_item *item)
>  
>  static inline ssize_t nullb_device_uint_attr_show(unsigned int val, char *page)
>  {
> -	return snprintf(page, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(page, "%u\n", val);
>  }
>  
>  static inline ssize_t nullb_device_ulong_attr_show(unsigned long val,
>  	char *page)
>  {
> -	return snprintf(page, PAGE_SIZE, "%lu\n", val);
> +	return sysfs_emit(page, "%lu\n", val);
>  }
>  
>  static inline ssize_t nullb_device_bool_attr_show(bool val, char *page)
>  {
> -	return snprintf(page, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(page, "%u\n", val);
>  }
>  
>  static ssize_t nullb_device_uint_attr_store(unsigned int *val,

-- 
Damien Le Moal
Western Digital Research