Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6eea25bf-08a8-641e-2360-68884e194608@redhat.com>
Date:   Fri, 21 Oct 2022 12:18:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v3 0/5] ksm: support tracking KSM-placed zero-pages
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        xu xin <xu.xin.sc@gmail.com>
Cc:     imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        ran.xiaokai@zte.com.cn, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn
References: <20221017165541.6e2d3cebdc1ba13861ea4b2b@linux-foundation.org>
 <20221018090022.373574-1-xu.xin16@zte.com.cn>
 <20221018155407.41c993924ec09a64ae966d50@linux-foundation.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20221018155407.41c993924ec09a64ae966d50@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19.10.22 00:54, Andrew Morton wrote:
> On Tue, 18 Oct 2022 09:00:22 +0000 xu xin <xu.xin.sc@gmail.com> wrote:
> 
>>> A full description of the real-world end-user operational benefits of
>>> these changes would help, please.
>>>
>>
>> The core idea of this patch set is to enable users to perceive the number of any
>> pages merged by KSM, regardless of whether use_zero_page switch has been turned
>> on, so that users can know how much free memory increase is really due to their
>> madvise(MERGEABLE) actions.
> 
> OK, thanks.
> 
>> The motivation for me to do this is that when I do
>> an application optimization of KSM on embedded Linux for 5G platform, I find
>> that ksm_merging_pages of some process becomes very small(but used to be large),
>> which led me to think that there was any problem with the application KSM-madvise
>> strategy, but in fact, it was only because use_zero_pages is on.
> 
> Please expand on the above motivation and experience, and include it in
> the [0/n] changelog.  But let's leave it a few days to see if there's
> additional reviewer input.
> 

I just posted a selftest:

https://lore.kernel.org/all/20221021101141.84170-5-david@redhat.com/T/#u

That could (should) be extended to test if unmerging works as expected.


Having that said, I think we really want a second pair of (KSM-expert) 
eyes on these changes before moving forward with them.

-- 
Thanks,

David / dhildenb