Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39c5a7cb-076a-a6ba-df27-7dee7d98a2a5@arm.com>
Date:   Fri, 21 Oct 2022 11:59:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>
Cc:     linux-kernel@vger.kernel.org, nick.forrington@arm.com,
        al.grant@arm.com, Will Deacon <will@kernel.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, acme@kernel.org
References: <20221020134512.1345013-1-james.clark@arm.com>
 <dcf5d62d-8163-dfee-a6b7-e75207650551@huawei.com>
From:   James Clark <james.clark@arm.com>
In-Reply-To: <dcf5d62d-8163-dfee-a6b7-e75207650551@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 21/10/2022 11:47, John Garry wrote:
> On 20/10/2022 14:45, James Clark wrote:
>> Rename the neoverse-n2 folder to make it clear that it includes V2, and
>> add V2 to mapfile.csv. V2 has the same events as N2, visible by running
>> the following command in the ARM-software/data github repo [1]:
>>
>>    diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
>>
>> Testing:
>>
>>    $ perf test pmu
>>
>>    10: PMU events                                           :
>>    10.1: PMU event table sanity                             : Ok
>>    10.2: PMU event map aliases                              : Ok
>>    10.3: Parsing of PMU event table metrics                 : Ok
>>    10.4: Parsing of PMU event table metrics with fake PMUs  : Ok
>>
>> [1]:https://github.com/ARM-software/data
>>
>> Signed-off-by: James Clark<james.clark@arm.com>
>> ---
> 
> This looks ok. Out of curiosity, do you know how the naming works for
> these neoverse cores? Were "n" a predecessor to "v"?

Thanks for the review. No, they're more like different product lines
than predecessors. From the image on this article [1], N are focused on
performance per watt and V are high performance.

[1]:
https://www.arm.com/company/news/2022/09/redefining-the-global-computing-infrastructure-with-next-generation-arm-neoverse-platforms

> 
> thanks,
> John