Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Subject: RE: [PATCH 2/2] dt-bindings: rtc: add bindings for max313xx RTCs
Thread-Topic: [PATCH 2/2] dt-bindings: rtc: add bindings for max313xx RTCs
Thread-Index: AQHY48BZbMpT/SjNa0SzYqltq8qQ864XyjkAgADySLA=
Date:   Fri, 21 Oct 2022 11:44:12 +0000
Message-ID: <DM8PR03MB62477670C186E6CC5308B600962D9@DM8PR03MB6247.namprd03.prod.outlook.com>
References: <20221019133910.282-1-Ibrahim.Tilki@analog.com>
 <20221019133910.282-2-Ibrahim.Tilki@analog.com> <Y1G6FIvS6WD57GXW@mail.local>
In-Reply-To: <Y1G6FIvS6WD57GXW@mail.local>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qapG0e2cMqhHcm48U83az3cQjFcRnAMvhIXQk/QcBA9DS9ceH38Oqpa+8/nL?=
 =?us-ascii?Q?Lf6Ultc1PrrP7GxxDQ4f4CBWKbSUG2Dz4yg2btgn0iKCZlzq1oHe+tghIW5W?=
 =?us-ascii?Q?LsAoNUt4S0fT3MGTTpcYoZprKLA5fvacPZfEhPnKlzbndxm186qbQ8teK1QI?=
 =?us-ascii?Q?E2SvMSAPdOaGmeU9dKQXAe5XA+u+5T9uaiCCE6gquxbP2lMsAPA8F2xy0bDS?=
 =?us-ascii?Q?Fn/vErnMEqaVgnR3h29B2Bdl9asoqyEvEO80qmsMIQZSWAjZrHzYgKcA1qKy?=
 =?us-ascii?Q?v6wCWWX+LEzvnAnOsmOcfvyBfzhHc6wevS3DHn9Grt8Od9OSB8dapk2pdcRZ?=
 =?us-ascii?Q?sqhci6PXehZNJWeryWyLS6qnOR7pX7ynFxzZ8cTZYOmZ/Z+1eg8T1Co7a4/F?=
 =?us-ascii?Q?YwuswAuE5omc37FF2AKs5n7nzGw3GJYoja3ZbDUnOnhkMwxPxB9Du8TstdGY?=
 =?us-ascii?Q?OcHNBEI8XOI/u+m8iFeu6WyPbTIDRmXl/IwNLesLeyz9QegH94qzfImdkURP?=
 =?us-ascii?Q?jMCgmfgTgUqYFJbGZIyAlWCG/C4lcIQCRzF3Te35EVko1MyTipne8PlBkuVW?=
 =?us-ascii?Q?+kD3C/xq8Gex99TrI9hcyGvO+RlPBIoQ9R+9u2/qgkCtxt7wrCBUGw5/9Be+?=
 =?us-ascii?Q?SeJ2bvQta6Hxby3rs6Alyk89EvGOjr2jYzFVN/w4lBCdyqXPLZiiroYmlucL?=
 =?us-ascii?Q?Pvqp49UgHCr0IA9s56fR90vH3SnzTiSKL5at8pthUBaoP1TZXYiLDTaZmMDc?=
 =?us-ascii?Q?mfmhnC/5QzImBt1e0r6pu1IYlwFE5rVmo8GXtQcw28ejoslstCeCF1CK4X4a?=
 =?us-ascii?Q?k9wcWhhh4CC4UVzcmMkmHlOd1+rbu1uztSRzkNIhOwTCqaRD7C5g1Exaav87?=
 =?us-ascii?Q?9FFdrc/irZyK902WGPfJLFM0aThYELKbCNwL11XbyykDnQ7fGyodxpPAIG1r?=
 =?us-ascii?Q?gpED7wFK9k7UHTE7h+90Z7Mbl0SAPjt3ZLlj6zIuSOLCROpWYGR2dHqtXpT+?=
 =?us-ascii?Q?zxjpelLpXGx6B4ezr7y4YUxF109ungeaMSoszNCRgdWfLgg845ykDMvnbPIK?=
 =?us-ascii?Q?fVe2ECwNm/BrvzEmAi0kP0Rfr6Gv0/8cVf+qz9NwtFmcFavB6nfF8T6N9mj+?=
 =?us-ascii?Q?f9t8H2Okzj+2BQ4j+LxN7kubAA8CLMe/UnfghLj9PGqvShaniF6PphbzxrwL?=
 =?us-ascii?Q?Hm9IAPriwLFUKBxlSG1dZDr3SvhRBcuN+DuDXWJGqSs0C5znL/mEd62x6eyx?=
 =?us-ascii?Q?fssftACgM1jbgFQnCKlMFkBRUYd1c7+xlZFozVhAAkTjSF1d20HBcLt671p2?=
 =?us-ascii?Q?6kNgO6Q8tHyfqNnsVOLwlnp5wlUsUj3LsV4k36eL5DwWfrwX89oHgm7uUpg5?=
 =?us-ascii?Q?rYFZ88gw3Kajr591b5PFa6qxU3wpYITyXiOI7iIgufazl7Q/Cjvj7u5b/DUa?=
 =?us-ascii?Q?fzxSH24dQE5hrxOLEJzHahBnU25CgFMlfr1SyifetsN6+XRA2W6i5sPqPwf5?=
 =?us-ascii?Q?bEm1fwmdBgtQ1R9yrYjsXycfy/4yqSzY8fgDXAQrVMJ41r7sZ7sBBIe3wvAf?=
 =?us-ascii?Q?Oc852nbJc5iXhYHcy05zWA8IxZ0LpXb3wYJf/JPL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR03MB6247.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cfe8639-9fbf-4e43-f196-08dab35992e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 11:44:12.3686
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oeQlx3/Boc5GEONIGIiqmoV+WzCSwjJ62WOcJFht5VsLTy042X/3JhCjkS7Vfw8Cs4WYwPVc3QIajPTea6sJ8BGbglvWcKm+eq6VU0l6A+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6397
X-Proofpoint-GUID: yjxajaNjyxHoSu3blnLz_3C-sNj3saVR
X-Proofpoint-ORIG-GUID: yjxajaNjyxHoSu3blnLz_3C-sNj3saVR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0
 adultscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 spamscore=0 priorityscore=1501 mlxscore=0 malwarescore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210210069
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On 19/10/2022 16:39:10+0300, Ibrahim Tilki wrote:
> > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> >=20
> > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > ---
> > .../devicetree/bindings/rtc/adi,max313xx.yaml | 163 ++++++++++++++++++
> > 1 file changed, 163 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.y=
aml
> >=20
> > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml \
> > b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml new file mode=
 100644
> > index 000000000..1aa491799
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > @@ -0,0 +1,163 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2022 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices MAX313XX series I2C RTC driver
> > +
> > +maintainers:
> > +  - Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > +  - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > +
> > +description: Bindings for the Analog Devices MAX313XX series RTCs.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max31328
> > +      - adi,max31329
> > +      - adi,max31331
> > +      - adi,max31334
> > +      - adi,max31341
> > +      - adi,max31342
> > +      - adi,max31343
> > +
> > +  reg:
> > +    description: I2C address of the RTC
> > +    items:
> > +      - enum: [0x68, 0x69]
> > +
> > +  interrupts:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  interrupt-names:
> > +    description: |
> > +      Name of the interrupt pin of the RTC used for IRQ. Not required =
for
> > +      RTCs that only have single interrupt pin available. Some of the =
RTCs
> > +      share interrupt pins with clock input/output pins.
> > +    minItems: 1
> > +    items:
> > +      - enum: [INTA, INTB]
> > +      - enum: [INTA, INTB]
> > +
>=20
> I don't think this is right, what this is doing is essentially pinmuxing
> interrupts versus clocks. What happens if you want INTB but this goes
> directly to a PMIC instead of the SoC?
> It is not something you can express with your current bindings.
>=20

Why would a user want INTB when it is not connected to SoC?
User can specify none, either one or both of the interrupt pins.
I don't see what the problem here is.

Ibrahim

>=20
> > +  "#clock-cells":
> > +    description: |
> > +      RTC can be used as a clock source through its clock output pin w=
hen
> > +      supplied.
> > +    const: 0
> > +
> > +  clocks:
> > +    description: |
> > +      RTC uses this clock for clock input when supplied. Clock has to =
provide
> > +      one of these four frequencies: 1Hz, 50Hz, 60Hz or 32.768kHz.
> > +    maxItems: 1
> > +
> > +  trickle-diode-disable: true
> > +
> > +  trickle-resistor-ohms:
> > +    description: Enables trickle charger with specified resistor value=
.
> > +    enum: [3000, 6000, 11000]
> > +
> > +  wakeup-source: true
> > +
> > +additionalProperties: false
> > +
> > +allOf:
> > +  - $ref: rtc.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - adi,max31328
> > +              - adi,max31342
> > +
> > +    then:
> > +      properties:
> > +        trickle-diode-disable: false
> > +        trickle-resistor-ohms: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - adi,max31328
> > +              - adi,max31331
> > +              - adi,max31334
> > +              - adi,max31343
> > +
> > +    then:
> > +      properties:
> > +        clocks: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - adi,max31341
> > +              - adi,max31342
> > +
> > +    then:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - const: 0x69
> > +
> > +    else:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - const: 0x68
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        rtc@68 {
> > +            reg =3D <0x68>;
> > +            compatible =3D "adi,max31329";
> > +            clocks =3D <&clkin>;
> > +            interrupt-parent =3D <&gpio>;
> > +            interrupts =3D <26 IRQ_TYPE_EDGE_FALLING>;
> > +            interrupt-names =3D "INTB";
> > +        };
> > +    };
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        rtc@68 {
> > +            reg =3D <0x68>;
> > +            compatible =3D "adi,max31331";
> > +            #clock-cells =3D <0>;
> > +            interrupt-parent =3D <&gpio>;
> > +            interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>, <26 IRQ_TYPE_ED=
GE_FALLING>;
> > +            interrupt-names =3D "INTA", "INTB";
> > +        };
> > +    };
> > +  - |
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        rtc@69 {
> > +            reg =3D <0x69>;
> > +            compatible =3D "adi,max31341";
> > +            #clock-cells =3D <0>;
> > +            clocks =3D <&clkin>;
> > +        };
> > +    };
> > --=20
> > 2.25.1
> >=20
>=20
> --=20
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com