Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Nicolas Dufresne'" <nicolas@ndufresne.ca>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
        <benjamin.gaignard@collabora.com>, <stanimir.varbanov@linaro.org>,
        <dillon.minfei@gmail.com>, <david.plowman@raspberrypi.com>,
        <mark.rutland@arm.com>, <robh+dt@kernel.org>, <krzk+dt@kernel.org>,
        <andi@etezian.org>, <alim.akhtar@samsung.com>,
        <aswani.reddy@samsung.com>, <pankaj.dubey@samsung.com>,
        <linux-fsd@tesla.com>, <smitha.t@samsung.com>
In-Reply-To: <1f3b8e326d64810999e1430da56fbe2f3efc0a91.camel@ndufresne.ca>
Subject: RE: [Patch v3 05/15] Documention: v4l: Documentation for VP9 CIDs.
Date:   Fri, 21 Oct 2022 10:56:26 +0530
Message-ID: <017901d8e50d$aebe1ce0$0c3a56a0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIjXZOHgvokXGuofbg3rWbxTFZEMQHl4WsmAsDEgksCHqqNhK1NNIqA
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221011122516.32135-1-aakarsh.jain@samsung.com>
        <CGME20221011125155epcas5p1e47309b4dd767e81817c316aa0e8b7ca@epcas5p1.samsung.com>
        <20221011122516.32135-6-aakarsh.jain@samsung.com>
        <1f3b8e326d64810999e1430da56fbe2f3efc0a91.camel@ndufresne.ca>
Precedence: bulk


> -----Original Message-----
> From: Nicolas Dufresne =5Bmailto:nicolas=40ndufresne.ca=5D
> Sent: 18 October 2022 20:36
> To: aakarsh jain <aakarsh.jain=40samsung.com>; linux-arm-
> kernel=40lists.infradead.org; linux-media=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; devicetree=40vger.kernel.org
> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> benjamin.gaignard=40collabora.com; stanimir.varbanov=40linaro.org;
> dillon.minfei=40gmail.com; david.plowman=40raspberrypi.com;
> mark.rutland=40arm.com; robh+dt=40kernel.org; krzk+dt=40kernel.org;
> andi=40etezian.org; alim.akhtar=40samsung.com; aswani.reddy=40samsung.com=
;
> pankaj.dubey=40samsung.com; linux-fsd=40tesla.com; smitha.t=40samsung.com
> Subject: Re: =5BPatch v3 05/15=5D Documention: v4l: Documentation for VP9=
 CIDs.
>=20
> Hi,
>=20
> thanks for your patch, very minor comment below.
>=20
> Le mardi 11 octobre 2022 =C3=A0=2017:55=20+0530,=20aakarsh=20jain=20a=20=
=C3=A9crit=20:=0D=0A>=20>=20From:=20Smitha=20T=20Murthy=20<smitha.t=40samsu=
ng.com>=0D=0A>=20>=0D=0A>=20>=20Adds=20V4l2=20controls=20for=20VP9=20encode=
r=20documention.=0D=0A>=20>=0D=0A>=20>=20Cc:=20linux-fsd=40tesla.com=0D=0A>=
=20>=20Signed-off-by:=20Smitha=20T=20Murthy=20<smitha.t=40samsung.com>=0D=
=0A>=20>=20Signed-off-by:=20Aakarsh=20Jain=20<aakarsh.jain=40samsung.com>=
=0D=0A>=20>=20---=0D=0A>=20>=20=20.../media/v4l/ext-ctrls-codec.rst=20=20=
=20=20=20=20=20=20=20=20=20=20=20=7C=20167=20++++++++++++++++++=0D=0A>=20>=
=20=201=20file=20changed,=20167=20insertions(+)=0D=0A>=20>=0D=0A>=20>=20dif=
f=20--git=20a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst=0D=
=0A>=20>=20b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst=0D=
=0A>=20>=20index=202a165ae063fb..2277d83a7cf0=20100644=0D=0A>=20>=20---=20a=
/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst=0D=0A>=20>=20+++=
=20b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst=0D=0A>=20>=
=20=40=40=20-2187,6=20+2187,16=20=40=40=20enum=20v4l2_mpeg_video_vp8_profil=
e=20-=0D=0A>=20>=20=20=20=20=20=20*=20-=20=60=60V4L2_MPEG_VIDEO_VP8_PROFILE=
_3=60=60=0D=0A>=20>=20=20=20=20=20=20=20=20-=20Profile=203=0D=0A>=20>=0D=0A=
>=20>=20+VP9=20Control=20Reference=0D=0A>=20>=20+---------------------=0D=
=0A>=20>=20+=0D=0A>=20>=20+The=20VP9=20controls=20include=20controls=20for=
=20encoding=20parameters=20of=20VP9=0D=0A>=20>=20+video=20codec.=0D=0A>=20>=
=20+=0D=0A>=20>=20+..=20_vp9-control-id:=0D=0A>=20>=20+=0D=0A>=20>=20+VP9=
=20Control=20IDs=0D=0A>=20>=20+=0D=0A>=20>=20=20..=20_v4l2-mpeg-video-vp9-p=
rofile:=0D=0A>=20>=0D=0A>=20>=20=20=60=60V4L2_CID_MPEG_VIDEO_VP9_PROFILE=60=
=60=0D=0A>=20>=20=40=40=20-2253,6=20+2263,163=20=40=40=20enum=20v4l2_mpeg_v=
ideo_vp9_level=20-=0D=0A>=20>=20=20=20=20=20=20*=20-=20=60=60V4L2_MPEG_VIDE=
O_VP9_LEVEL_6_2=60=60=0D=0A>=20>=20=20=20=20=20=20=20=20-=20Level=206.2=0D=
=0A>=20>=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_I_FRAME_QP=60=60=0D=0A>=20>=
=20+=20=20=20=20Quantization=20parameter=20for=20an=20I=20frame=20for=20VP9=
.=20Valid=20range:=20from=201=20to=0D=0A>=20255.=0D=0A>=20>=20+=0D=0A>=20>=
=20+=60=60V4L2_CID_CODEC_VP9_P_FRAME_QP=60=60=0D=0A>=20>=20+=20=20=20=20Qua=
ntization=20parameter=20for=20an=20P=20frame=20for=20VP9.=20Valid=20range:=
=20from=201=20to=0D=0A>=20255.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_=
CODEC_VP9_MAX_QP=60=60=0D=0A>=20>=20+=20=20=20=20Maximum=20quantization=20p=
arameter=20for=20VP9.=20Valid=20range:=20from=201=20to=20255.=0D=0A>=20>=20=
+=20=20=20=20Recommended=20range=20for=20MFC=20is=20from=20230=20to=20255.=
=0D=0A>=20=0D=0A>=20We=20don't=20usually=20want=20every=20single=20HW=20to=
=20be=20documented=20in=20the=20generic=20part=0D=0A>=20of=20the=20document=
ation.=20The=20range=20supported=20by=20the=20HW=20should=20be=20found=20at=
=0D=0A>=20run-time=20I=20suppose,=20by=20querying=20the=20control.=20Would=
=20that=20work=20for=20you=20to=0D=0A>=20remove=20the=20MFC=20specifics=20h=
ere=20and=20in=20other=20controls=20?=0D=0A>=20=0D=0Aok.=20will=20remove=20=
it=20in=20next=20series.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_=
VP9_MIN_QP=60=60=0D=0A>=20>=20+=20=20=20=20Minimum=20quantization=20paramet=
er=20for=20VP9.=20Valid=20range:=20from=201=20to=20255.=0D=0A>=20>=20+=20=
=20=20=20Recommended=20range=20for=20MFC=20is=20from=201=20to=2024.=0D=0A>=
=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_RC_FRAME_RATE=60=60=0D=0A>=
=20>=20+=20=20=20=20Indicates=20the=20number=20of=20evenly=20spaced=20subin=
tervals,=20called=20ticks,=20within=0D=0A>=20>=20+=20=20=20=20one=20second.=
=20This=20is=20a=2016=20bit=20unsigned=20integer=20and=20has=20a=20maximum=
=20value=0D=0A>=20up=20to=0D=0A>=20>=20+=20=20=20=200xffff=20and=20a=20mini=
mum=20value=20of=201.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9=
_GF_REFRESH_PERIOD=60=60=0D=0A>=20>=20+=20=20=20=20Indicates=20the=20refres=
h=20period=20of=20the=20golden=20frame=20for=20VP9=20encoder.=0D=0A>=20>=20=
+=0D=0A>=20>=20+..=20_v4l2-vp9-golden-frame-sel:=0D=0A>=20>=20+=0D=0A>=20>=
=20+=60=60V4L2_CID_CODEC_VP9_GOLDEN_FRAMESEL=60=60=0D=0A>=20>=20+=20=20=20=
=20(enum)=0D=0A>=20>=20+=0D=0A>=20>=20+enum=20v4l2_mpeg_vp9_golden_framesel=
=20-=0D=0A>=20>=20+=20=20=20=20Selects=20the=20golden=20frame=20for=20encod=
ing.=20Valid=20when=20NUM_OF_REF=20is=202.=0D=0A>=20>=20+=20=20=20=20Possib=
le=20values=20are:=0D=0A>=20>=20+=0D=0A>=20>=20+..=20raw::=20latex=0D=0A>=
=20>=20+=0D=0A>=20>=20+=20=20=20=20=5Cfootnotesize=0D=0A>=20>=20+=0D=0A>=20=
>=20+..=20tabularcolumns::=20=7Cp=7B9.0cm=7D=7Cp=7B8.0cm=7D=7C=0D=0A>=20>=
=20+=0D=0A>=20>=20+..=20flat-table::=0D=0A>=20>=20+=20=20=20=20:header-rows=
:=20=200=0D=0A>=20>=20+=20=20=20=20:stub-columns:=200=0D=0A>=20>=20+=0D=0A>=
=20>=20+=20=20=20=20*=20-=20=60=60V4L2_CID_CODEC_VP9_GOLDEN_FRAME_USE_PREV=
=60=60=0D=0A>=20>=20+=20=20=20=20=20=20-=20Use=20the=20(n-2)th=20frame=20as=
=20a=20golden=20frame,=20current=20frame=20index=20being=0D=0A>=20>=20+=20=
=20=20=20=20=20=20=20'n'.=0D=0A>=20>=20+=20=20=20=20*=20-=20=60=60V4L2_CID_=
CODEC_VP9_GOLDEN_FRAME_USE_REF_PERIOD=60=60=0D=0A>=20>=20+=20=20=20=20=20=
=20-=20Use=20the=20previous=20specific=20frame=20indicated=20by=0D=0A>=20>=
=20+=20=20=20=20=20=20=20=20=60=60V4L2_CID_CODEC_VP9_GF_REFRESH_PERIOD=60=
=60=20as=20a=0D=0A>=20>=20+=20=20=20=20=20=20=20=20golden=20frame.=0D=0A>=
=20>=20+=0D=0A>=20>=20+..=20raw::=20latex=0D=0A>=20>=20+=0D=0A>=20>=20+=20=
=20=20=20=5Cnormalsize=0D=0A>=20>=20+=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4=
L2_CID_CODEC_VP9_HIERARCHY_QP_ENABLE=60=60=0D=0A>=20>=20+=20=20=20=20Allows=
=20host=20to=20specify=20the=20quantization=20parameter=20values=20for=20ea=
ch=0D=0A>=20>=20+=20=20=20=20temporal=20layer=20through=20HIERARCHICAL_QP_L=
AYER.=20This=20is=20valid=20only=0D=0A>=20>=20+=20=20=20=20if=20HIERARCHICA=
L_CODING_LAYER=20is=20greater=20than=201.=20Setting=20the=20control=0D=0A>=
=20>=20+=20=20=20=20value=20to=201=20enables=20setting=20of=20the=20QP=20va=
lues=20for=20the=20layers.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20_v4l2-vp9-ref-=
number-of-pframes:=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_RE=
F_NUMBER_FOR_PFRAMES=60=60=0D=0A>=20>=20+=20=20=20=20(enum)=0D=0A>=20>=20+=
=0D=0A>=20>=20+enum=20v4l2_mpeg_vp9_ref_num_for_pframes=20-=0D=0A>=20>=20+=
=20=20=20=20Number=20of=20reference=20pictures=20for=20encoding=20P=20frame=
s.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20raw::=20latex=0D=0A>=20>=20+=0D=0A>=20=
>=20+=20=20=20=20=5Cfootnotesize=0D=0A>=20>=20+=0D=0A>=20>=20+..=20tabularc=
olumns::=20=7Cp=7B9.0cm=7D=7Cp=7B8.0cm=7D=7C=0D=0A>=20>=20+=0D=0A>=20>=20+.=
.=20flat-table::=0D=0A>=20>=20+=20=20=20=20:header-rows:=20=200=0D=0A>=20>=
=20+=20=20=20=20:stub-columns:=200=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20=20=
=20*=20-=20=60=60V4L2_CID_CODEC_VP9_1_REF_PFRAME=60=60=0D=0A>=20>=20+=20=20=
=20=20=20=20-=20Indicates=20one=20reference=20frame,=20last=20encoded=20fra=
me=20will=20be=20searched.=0D=0A>=20>=20+=20=20=20=20*=20-=20=60=60V4L2_CID=
_CODEC_VP9_GOLDEN_FRAME_USE_REF_PERIOD=60=60=0D=0A>=20>=20+=20=20=20=20=20=
=20-=20Indicates=202=20reference=20frames,=20last=20encoded=20frame=20and=
=20golden=20frame=0D=0A>=20>=20+=20=20=20=20=20=20=20=20will=20be=20searche=
d.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20raw::=20latex=0D=0A>=20>=20+=0D=0A>=20=
>=20+=20=20=20=20=5Cnormalsize=0D=0A>=20>=20+=0D=0A>=20>=20+=0D=0A>=20>=20+=
=60=60V4L2_CID_CODEC_VP9_HIERARCHICAL_CODING_LAYER=60=60=0D=0A>=20>=20+=20=
=20=20=20Indicates=20the=20number=20of=20hierarchial=20coding=20layer.=0D=
=0A>=20>=20+=20=20=20=20In=20normal=20encoding=20(non-hierarchial=20coding)=
,=20it=20should=20be=20zero.=0D=0A>=20>=20+=20=20=20=20VP9=20has=20upto=203=
=20layer=20of=20encoder.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_=
VP9_HIERARCHY_RC_ENABLE=60=60=0D=0A>=20>=20+=20=20=20=20Indicates=20enablin=
g=20of=20bit=20rate=20for=20hierarchical=20coding=20layers=20VP9=20encoder.=
=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_HIER_CODING_L0_BR=60=
=60=0D=0A>=20>=20+=20=20=20=20Indicates=20bit=20rate=20for=20hierarchical=
=20coding=20layer=200=20for=20VP9=20encoder.=0D=0A>=20>=20+=0D=0A>=20>=20+=
=60=60V4L2_CID_CODEC_VP9_HIER_CODING_L1_BR=60=60=0D=0A>=20>=20+=20=20=20=20=
Indicates=20bit=20rate=20for=20hierarchical=20coding=20layer=201=20for=20VP=
9=20encoder.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_HIER_COD=
ING_L2_BR=60=60=0D=0A>=20>=20+=20=20=20=20Indicates=20bit=20rate=20for=20hi=
erarchical=20coding=20layer=202=20for=20VP9=20encoder.=0D=0A>=20>=20+=0D=0A=
>=20>=20+=60=60V4L2_CID_CODEC_VP9_HIER_CODING_L0_QP=60=60=0D=0A>=20>=20+=20=
=20=20=20Indicates=20quantization=20parameter=20for=20hierarchical=20coding=
=20layer=200.=0D=0A>=20>=20+=20=20=20=20Valid=20range:=20=5BV4L2_CID_CODEC_=
VP9_MIN_QP,=0D=0A>=20>=20+=20=20=20=20V4L2_CID_CODEC_VP9_MAX_QP=5D.=0D=0A>=
=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_HIER_CODING_L1_QP=60=60=0D=
=0A>=20>=20+=20=20=20=20Indicates=20quantization=20parameter=20for=20hierar=
chical=20coding=20layer=201.=0D=0A>=20>=20+=20=20=20=20Valid=20range:=20=5B=
V4L2_CID_CODEC_VP9_MIN_QP,=0D=0A>=20>=20+=20=20=20=20V4L2_CID_CODEC_VP9_MAX=
_QP=5D.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_HIER_CODING_L=
2_QP=60=60=0D=0A>=20>=20+=20=20=20=20Indicates=20quantization=20parameter=
=20for=20hierarchical=20coding=20layer=202.=0D=0A>=20>=20+=20=20=20=20Valid=
=20range:=20=5BV4L2_CID_CODEC_VP9_MIN_QP,=0D=0A>=20>=20+=20=20=20=20V4L2_CI=
D_CODEC_VP9_MAX_QP=5D.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20_v4l2-vp9-max-part=
ition-depth:=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_MAX_PART=
ITION_DEPTH=60=60=0D=0A>=20>=20+=20=20=20=20(enum)=0D=0A>=20>=20+=0D=0A>=20=
>=20+enum=20v4l2_mpeg_vp9_num_partitions=20-=0D=0A>=20>=20+=20=20=20=20Indi=
cate=20maximum=20coding=20unit=20depth.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20r=
aw::=20latex=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20=20=20=5Cfootnotesize=0D=0A=
>=20>=20+=0D=0A>=20>=20+..=20tabularcolumns::=20=7Cp=7B9.0cm=7D=7Cp=7B8.0cm=
=7D=7C=0D=0A>=20>=20+=0D=0A>=20>=20+..=20flat-table::=0D=0A>=20>=20+=20=20=
=20=20:header-rows:=20=200=0D=0A>=20>=20+=20=20=20=20:stub-columns:=200=0D=
=0A>=20>=20+=0D=0A>=20>=20+=20=20=20=20*=20-=20=60=60V4L2_CID_CODEC_VP9_0_P=
ARTITION=60=60=0D=0A>=20>=20+=20=20=20=20=20=20-=20No=20coding=20unit=20par=
tition=20depth.=0D=0A>=20>=20+=20=20=20=20*=20-=20=60=60V4L2_CID_CODEC_VP9_=
1_PARTITION=60=60=0D=0A>=20>=20+=20=20=20=20=20=20-=20Allows=20one=20coding=
=20unit=20partition=20depth.=0D=0A>=20>=20+=0D=0A>=20>=20+..=20raw::=20late=
x=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20=20=20=5Cnormalsize=0D=0A>=20>=20+=0D=
=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_DISABLE_INTRA_PU_SPLIT=
=60=60=0D=0A>=20>=20+=20=20=20=20Zero=20indicates=20enable=20intra=20NxN=20=
PU=20split.=0D=0A>=20>=20+=20=20=20=20One=20indicates=20disable=20intra=20N=
xN=20PU=20split.=0D=0A>=20>=20+=0D=0A>=20>=20+=60=60V4L2_CID_CODEC_VP9_DISA=
BLE_IVF_HEADER=60=60=0D=0A>=20>=20+=20=20=20=20Indicates=20IVF=20header=20g=
eneration.=20Zero=20indicates=20enable=20IVF=20format.=0D=0A>=20>=20+=20=20=
=20=20One=20indicates=20disable=20IVF=20format.=0D=0A>=20>=20+=0D=0A>=20>=
=0D=0A>=20>=20=20High=20Efficiency=20Video=20Coding=20(HEVC/H.265)=20Contro=
l=20Reference=0D=0A>=20>=0D=0A>=20=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D=0A>=20=3D=
=0D=0AThanks=20for=20the=20review.=0D=0A=0D=0A=0D=0A