Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2618764rwi; Fri, 21 Oct 2022 06:07:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4sDCKjY/rOA4Um8SsZiaoDbKm6LjopJIUQ4wVg0X+vfcf5lCrVZM+SZ86tXePCBAB6VRMN X-Received: by 2002:a05:6402:34ce:b0:45d:14c9:c522 with SMTP id w14-20020a05640234ce00b0045d14c9c522mr17096465edc.160.1666357671573; Fri, 21 Oct 2022 06:07:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666357671; cv=none; d=google.com; s=arc-20160816; b=aGxmWaxaR0lu8yYW8VTqmvi0EOmBZwB2rmWGO/svSOyUeOPICkeNK4toVNGSTW/6mq W7BeAPzzg3YQzK5O08GYOaB/GC/w000NBJqU6vQH0hmwZ+7nKu2JTHgjH4GUB1U9uQUX qvaP14ATUq08sujRTBrwcYXBV5G0AarXxzsB8AifIVlEcCV168yMLBRiUfktWnoZ29nd MDIhB35/LqLUv0RQK9CyPmQEp+pFyyrYKPU1JTT0vEyrRV/XblbfCE5sse97EyYVYaip Zx+3fr1+qxgQZaRbikl78OG3Sdj23BBM0dqt/P34eyedZGSbuhTS7f2kWsZne3/SIWL9 A9iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=ub/Q3aGASlrAXKX6JbBno3sJc5izj2B9kHx5Vfj31no=; b=NwyZy7OyH1z363TFzDxwQlw6hu88ek9eAbQt9oXBc1ks9bhYhtdqXQqogrd779Emak B9L966Q+PWvknaE/MKFVLCn4o28yGDLMRlAeE9QBHIhvUMLepCFrzdwU0ww4x5kTLMUf 4lNpMfi10RYhfEdlHlsmFofTkly8dWL1eZScB0wQwRmdg31vNpJcjR2v3MoaooyctkAa jMudlR7hlE2ZEUBH9LDmuF3kOr6MvQfE1GzsZcfnpEgZql2uqRj/qZe2IrdP+IcrJRVv D+tq8LhDhOFc0j1Z8PJpQQtabPXbrS1l7B14Nt1vqYj/dnLetwJrZGMsVE1EmQLuM0W6 Vscw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=gEJ6INl1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb7-20020a0564020d0700b0045d15503bb8si23217722edb.224.2022.10.21.06.07.24; Fri, 21 Oct 2022 06:07:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=gEJ6INl1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbiJUNEs (ORCPT + 99 others); Fri, 21 Oct 2022 09:04:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbiJUNEp (ORCPT ); Fri, 21 Oct 2022 09:04:45 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 413484AD7C for ; Fri, 21 Oct 2022 06:04:43 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id n12so4682757wrp.10 for ; Fri, 21 Oct 2022 06:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ub/Q3aGASlrAXKX6JbBno3sJc5izj2B9kHx5Vfj31no=; b=gEJ6INl1uo2EhdrqvpQPhIeMhpnTp/XTU+JHgRvsZWO7q0dliF+YoqCWZGjqTDPHmV NZH1YUUL4hRBFfUiUbBxtJlGJEGGhg+dCZZ5CXddKxrwdK8Y/zY35MWxxyY+6rJdfWjg CnbFzh/3uiviFDfs2zHAudI3cY/42hpKZeJehUUk9xx3FSp3PBuGwS/5p4sFoknG0opI gVV94ui6Y5m95IH2FzeDetax+EyO183Vv4HjyeOnWa/m0s6DKjbB4cyPxwYDCFH386sI xHdi6c3J+arK/FjKtZNzt6ZtvYDD8D58x/R8xf4TT33C6TWaVCThCozrmMCQ0Arl9o/Y x6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ub/Q3aGASlrAXKX6JbBno3sJc5izj2B9kHx5Vfj31no=; b=FcyiANvz8w8jT5kUhVs0DZXF80AE6h+Azdgsz6D5yKPjrN92FfDeOx7zZCS6vBKqDW bvA37qBYi0Iv7BTNpGasUa0kVfaPvZUZEUe10PSQjMU8RPScAHzuhaXAMA898cBQvWcx 1IGNnRGVZ/cmFhp/2ZcBXZLUxX1oXhaX3jLX8XrmFquJ2z3I3LmRJOWzNWwJ9SXaUUgn pOwFT0vCMoF8bxF/26X6nc3/kHcB4iBQIqePB2gfuK8nG7umxB7zGo5ojuHqzdlsgCLN /xrbcsa9JC18e2g2CBt+UTSr3jCmFM1Q4Ncfp6Y980NOIZs4VADuTWAl3yVfYDkdiePs Q66Q== X-Gm-Message-State: ACrzQf10WSHsfKQD0Ic0vJebsFibJGqUhCX0LGkcblS34+dYzhlMDjkr lwg3lLcdNFeot4iaqwuNlXP5joBfwWY9Mg== X-Received: by 2002:adf:fa05:0:b0:22e:362a:ce57 with SMTP id m5-20020adffa05000000b0022e362ace57mr12200802wrr.96.1666357481661; Fri, 21 Oct 2022 06:04:41 -0700 (PDT) Received: from localhost ([2a01:cb19:8b2c:5e00:becf:29f6:2774:7ce2]) by smtp.gmail.com with ESMTPSA id c5-20020a05600c0a4500b003bdd2add8fcsm2878337wmq.24.2022.10.21.06.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 06:04:41 -0700 (PDT) From: Mattijs Korpershoek To: Colin Ian King , Dmitry Torokhov , linux-input@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: tps6507x-ts: remove variable loops In-Reply-To: <20221020181642.24417-1-colin.i.king@gmail.com> References: <20221020181642.24417-1-colin.i.king@gmail.com> Date: Fri, 21 Oct 2022 15:04:39 +0200 Message-ID: <87y1t9pbtk.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 19:16, Colin Ian King wrote: > The variable loops is being incremented but is never referenced, > it is redundant and can be removed. > > Signed-off-by: Colin Ian King Reviewed-by: Mattijs Korpershoek > --- > drivers/input/touchscreen/tps6507x-ts.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c > index 357a3108f2e5..f48871767763 100644 > --- a/drivers/input/touchscreen/tps6507x-ts.c > +++ b/drivers/input/touchscreen/tps6507x-ts.c > @@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc, > static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc) > { > s32 ret; > - s32 loops = 0; > u8 val; > > ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG, > @@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc) > ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val); > if (ret) > return ret; > - loops++; > } > > return ret; > -- > 2.37.3