Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 15:08:45 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] leds-pca955x: Remove the unused function
 pca95xx_num_led_regs()
Message-ID: <20221021130845.GA16264@duo.ucw.cz>
References: <20221017081053.52388-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j"
Content-Disposition: inline
In-Reply-To: <20221017081053.52388-1-jiapeng.chong@linux.alibaba.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--nFreZHaLTZJo0R7j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> The function pca95xx_num_led_regs() is defined in the leds-pca955x.c
> file, but not called elsewhere, so delete this unused function.
>=20
> drivers/leds/leds-pca955x.c:149:19: warning: unused function 'pca95xx_num=
_led_regs'.

Thank you, applied.

Best regards,
									Pavel


> +++ b/drivers/leds/leds-pca955x.c
> @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits)
>  	return (bits + 7) / 8;
>  }
> =20
> -/* 4 bits per LED selector register */
> -static inline int pca95xx_num_led_regs(int bits)
> -{
> -	return (bits + 3)  / 4;
> -}
> -
>  /*
>   * Return an LED selector register value based on an existing one, with
>   * the appropriate 2-bit state value set for the given LED number (0-3).

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--nFreZHaLTZJo0R7j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY1KZ3QAKCRAw5/Bqldv6
8nMaAJ43HmLO4zeFHwMAiePUeNJgL3pThgCdFbbgxqTMLO9ylnTp4j8ny+YOHks=
=1LkM
-----END PGP SIGNATURE-----

--nFreZHaLTZJo0R7j--