Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 15:56:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Paolo Valente <paolo.valente@linaro.org>,
        Jens Axboe <axboe@kernel.dk>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        glen.valante@linaro.org, arie.vanderhoeven@seagate.com,
        rory.c.chen@seagate.com, Paolo Valente <paolo.valente@linaro.org>,
        Gabriele Felici <felicigb@gmail.com>,
        Carmine Zaccagnino <carmine@carminezacc.com>
Subject: [kbuild] Re: [PATCH V4 1/8] block, bfq: split sync bfq_queues on a
 per-actuator basis
Message-ID: <202210212014.ynAHDVJU-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221020152643.21199-2-paolo.valente@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vDrx8hD0RTPrFksR9pSXBde0eB/GZ3Qg+GA6Ty3/E07g9hY/nCn28lTo6iTY?=
 =?us-ascii?Q?v3Lf7VxCqGNpY7br5rbro+17rWavLxePEmkolO54BqilYg3J4Za2qjUtilBL?=
 =?us-ascii?Q?eFpwXxE5M59f2KkGBDRiHet+xhbdtFnb8aykSUZdTBqE4rKH1iAj5jZBAJwd?=
 =?us-ascii?Q?idimmdqmEbZIeSch1+/3oiIpYRWNd8XhOBqEsfgiIPA/2ZR0olewAnM2eAXw?=
 =?us-ascii?Q?Jn9lNXe42kH1/qqbIZqGCjTm1X7WPWoweRjPnC7aeG8x3BJQhtzBJGrK1TrH?=
 =?us-ascii?Q?hRMTWf+D703YT+5cjNKjENM7Ara5vJQ6/9eaLwk8PYK0af9zbgysu/ExRGLE?=
 =?us-ascii?Q?Bj9WO7dp4hgCF7LlBQ4SeDIR2lIcvlEFC8VitGd3o1ykVPB2yQVNPMcWCdXO?=
 =?us-ascii?Q?GsAy6q5sd2uvyzVbHuxIv27Dicfj8soCrzTXV/ZQ5+JmktSQM/8DAB2j8Ar/?=
 =?us-ascii?Q?Wg7v/ZGj3xGN0GhQH1agHToBxWJIbtIgxX5Bc/tS1257tAL2xCdcQdSZzqom?=
 =?us-ascii?Q?hNukqmwnTfqcxM5COVH79W5DfNjAO5P6fcHHPr8oWe4bRX4ocpboKkhVx4dE?=
 =?us-ascii?Q?lsu/HApaieT/Kn9OfR/nVeQQZpzluw+R31uP9xK3VIxc928oc6O+0XtzkWjP?=
 =?us-ascii?Q?An0D7WOWbYHYEFGOxSGoj9fKHGB1s2I252PWp9xmnVDShqmICDe9v8trnQ51?=
 =?us-ascii?Q?d1wxK9nMeqN8L5li2FbkMAiSWgK/qw2sbqbGdvz4fD+La/ZNTDRzV/4rybmm?=
 =?us-ascii?Q?dukId1SBINmp80A/8EyfK97RiCDe96coWvRiY2dydj90zdjwwKpJoTpVWz1W?=
 =?us-ascii?Q?GSXIyaTvPQ/pzXLDvrc9PxXPldccBZBv4I9CKEQP91FSN402XUJWsme0/8Sa?=
 =?us-ascii?Q?OKTm8Ouo/sS2ehcrX1nASFzcdNF30XTD/BMOHtg5aBuhl6cQTa0hiVEVgk+8?=
 =?us-ascii?Q?N0oyw/JUX4HGfJP+BM0jAe/TH8Ne0aaAOLnCHR6gMD34VvvGJxi5zvdNkCf7?=
 =?us-ascii?Q?+nt0fl4qynDfI13zXng8/bTLaE3C5GTFd0AR/adpju/N0VnNY3QP8mG6TLca?=
 =?us-ascii?Q?uGXUM/sWldF/RxRJvyJRneuzAnaK4uiYRdhfHne28KuyvjhFnvd6ukbkK8k4?=
 =?us-ascii?Q?LCkBsHMu2o8bz+0zmqp1U9BXoFDIXEBsFAuOY+CT0QVoTQmCCM2S08F/7eSn?=
 =?us-ascii?Q?wqk0xZh4UFdPA6pr9deAwJMMdOuqmQwS2uKT3bPPNa7YzCLDkuMGOaJZjTz3?=
 =?us-ascii?Q?gvbQTkKC2zRHUzTf7ROftZEF/u6aw6SZhnqMsjyfxSryMPGjA4me/scF4HnU?=
 =?us-ascii?Q?FVeniomQV09G9/l6eCu8BMGKOpdRWYfuOh/Kr7rUbl9nM5zIlFOmuNfZeajN?=
 =?us-ascii?Q?tG6yZCDB8RqBA2Toc3FK39Mf5HDHBG8DYPTgbf2AJLmZvvlx6aNbHXjxNipe?=
 =?us-ascii?Q?bCiC6yj0rgosIFKA7QyhQwS2QyCMgpHYqEkzY3vZWiV7PJmYrN5sMFWt0Y2g?=
 =?us-ascii?Q?d6ONYQXT9aJUCKHi8pm0gtkuGPLC0GsFI4W8/8qLrDRuTSU+bjfmuFHxFmJQ?=
 =?us-ascii?Q?IhZo57OzT3gGKTR0xg4pWDLLvRTjBZcKMmFKcuwiVToRxxL05ImAlwSejYxX?=
 =?us-ascii?Q?Ug=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b04b673-b817-4636-3da9-08dab363c670
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 12:57:14.6693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r54w/9BoYDkVsVzNvzBRb/53arjb8YvhjzqS1J2tS5PsLNNIxjwzqmvEX4D5ZjysmM66Axqk8+8c3s0GXT2Sm3FFdTf4lk3A8xnIMLbD5/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4471
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210210077
X-Proofpoint-ORIG-GUID: VLiabWRmYnnj9WjjSaJKz7XJo9xVO5Y1
X-Proofpoint-GUID: VLiabWRmYnnj9WjjSaJKz7XJo9xVO5Y1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Paolo,

https://git-scm.com/docs/git-format-patch#_base_tree_information  ]

url:    https://github.com/intel-lab-lkp/linux/commits/Paolo-Valente/block-bfq-extend-bfq-to-support-multi-actuator-drives/20221020-233011  
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git   for-next
patch link:    https://lore.kernel.org/r/20221020152643.21199-2-paolo.valente%40linaro.org  
patch subject: [PATCH V4 1/8] block, bfq: split sync bfq_queues on a per-actuator basis
config: openrisc-randconfig-m041-20221019
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
block/bfq-iosched.c:5423 bfq_exit_icq() error: we previously assumed 'bfqd' could be null (see line 5420)
block/bfq-iosched.c:5431 bfq_exit_icq() warn: variable dereferenced before check 'bfqd' (see line 5423)

Old smatch warnings:
block/bfq-iosched.c:6115 __bfq_insert_request() warn: variable dereferenced before check 'bfqq' (see line 6111)

vim +/bfqd +5423 block/bfq-iosched.c

aee69d78dec0ff Paolo Valente 2017-04-19  5409  static void bfq_exit_icq(struct io_cq *icq)
aee69d78dec0ff Paolo Valente 2017-04-19  5410  {
aee69d78dec0ff Paolo Valente 2017-04-19  5411  	struct bfq_io_cq *bic = icq_to_bic(icq);
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5412  	struct bfq_data *bfqd = bic_to_bfqd(bic);
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5413  	unsigned long flags;
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5414  	unsigned int act_idx;
430a67f9d6169a Paolo Valente 2021-03-04  5415  
430a67f9d6169a Paolo Valente 2021-03-04  5416  	/*
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5417  	 * bfqd is NULL if scheduler already exited, and in that case
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

fc8f914d9fc5a0 Paolo Valente 2022-10-20  5418  	 * this is the last time these queues are accessed.
430a67f9d6169a Paolo Valente 2021-03-04  5419  	 */
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5420  	if (bfqd)
430a67f9d6169a Paolo Valente 2021-03-04  5421  		spin_lock_irqsave(&bfqd->lock, flags);
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5422  
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5423  	for (act_idx = 0; act_idx < bfqd->num_actuators; act_idx++) {
                                                                            ^^^^^^^^^^^^^^^^^^^
If "bfqd" is NULL then we're toasted.

fc8f914d9fc5a0 Paolo Valente 2022-10-20  5424  		if (bic->stable_merge_bfqq)
430a67f9d6169a Paolo Valente 2021-03-04  5425  			bfq_put_stable_ref(bic->stable_merge_bfqq);
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5426  
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5427  		bfq_exit_icq_bfqq(bic, true, act_idx);
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5428  		bfq_exit_icq_bfqq(bic, false, act_idx);
430a67f9d6169a Paolo Valente 2021-03-04  5429  	}
430a67f9d6169a Paolo Valente 2021-03-04  5430  
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5431  	if (bfqd)
fc8f914d9fc5a0 Paolo Valente 2022-10-20  5432  		spin_unlock_irqrestore(&bfqd->lock, flags);
aee69d78dec0ff Paolo Valente 2017-04-19  5433  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp