Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7ff2627-881a-4d69-ad78-618ee4f4c62e@nvidia.com>
Date:   Fri, 21 Oct 2022 14:40:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] phy: tegra: xusb: Remove usb3 supply
Content-Language: en-US
To:     Haotien Hsu <haotienh@nvidia.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Vinod Koul <vkoul@kernel.org>
Cc:     JC Kuo <jckuo@nvidia.com>, Kishon Vijay Abraham I <kishon@ti.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, Wayne Chang <waynec@nvidia.com>
References: <20221005084031.2154251-1-haotienh@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221005084031.2154251-1-haotienh@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVNUZW5IY3V2NUREcExEQlR4dW0zSWJ0dHhwRnV3QzZHVkZSM1dqMVZFMXJa?=
 =?utf-8?B?VC9VQjBsSzAvRGsxblhReFdNK2dmOHU5azhGMGRqd1JnaXZaM0twOGt3dCtr?=
 =?utf-8?B?RTdneUNkTm1iM0RHd0NqWGNIV0pZTlVDNU01TlZQcjYzdkI3STNsRXZVanpt?=
 =?utf-8?B?VTZUelNnOGRFMlNzeDg5WWErL2lPdjZmYkFpMlVaZVJqY3VKbUxieXBLakor?=
 =?utf-8?B?Vk1jMnQzblVGT3ptRDNwY2szWDdSTTlnSU0rSWtVaUc3dU9ZQVh6OHh1RWhy?=
 =?utf-8?B?SXYwdU11SGo4NEp5Y1U1SWNhSWhtVUVWbTkxN3gyWWhuV3dLZGpndUlkUmw0?=
 =?utf-8?B?N0JrMUhITDNIK2NHZmpZa1R2Yjk3OTlQMTd6VkJnQms3cDJqYms4VlUwNlRF?=
 =?utf-8?B?b1JIYkxwWWttMkIxSFhBQXBJNDFSaEF5VW1xZi91ajROaWY1ZDMyUEJWOGVy?=
 =?utf-8?B?QVRyZEJQdGd2bkw2UGVGRGt2U0VPMEowMERQZitndFpVY2JwYUdTS2QzbUJK?=
 =?utf-8?B?L05MdmpVdndhbUJTQnUzNUJvQkREa1RHWTZaNStUdGlZcXM2VmN0SW9ja3dK?=
 =?utf-8?B?eGxObWVYVGdLN2xlY2wyM1c5Mmd3Z2ZxUW5DYVF1NHNqSXJTOC84SHY3T3R2?=
 =?utf-8?B?RXU2WlkxRjlHSWtDZSs3U3NOTXpyazl5N3VSRWxuRWtrZXlIeWZqWC9NZ2tO?=
 =?utf-8?B?VFkrUVM4U2JKWGplcVNURlA1cy9kV21nT05Xc1Q4SDB1MHkxYVF1OGMzSHkv?=
 =?utf-8?B?aEw4bHlmZjJHL2puTy80d0drVUZ0UVZiT1haOFo2bnZSc2tEOHhUMG1NRUFO?=
 =?utf-8?B?UGxneXo0dVZSS05ockM1Q2NaSDNBejJENWRhRGhhVUpKN2xBcGNsOFZIamtl?=
 =?utf-8?B?a3Zld2UwTCtnc2tGWGhCYlNHSHJ0dGRDVVdmTEZpdW1PekQ4akFSOWsydzhL?=
 =?utf-8?B?Yjd5eHgxdHNyTS9xUWtibTd5Z1N1RFJOOUpKNGZNbWg1U0dOWVBYMVBXZG13?=
 =?utf-8?B?MTE1ekJHQXpGMzZTQjdDaFBFdjFkNG1qN3VYU1ZrOVNGRjdGWldBUmJteG9y?=
 =?utf-8?B?YzZJSnBxLy82VVlhaElaKzNjSHlzSHhkNkREZGRnZGlEcGd4dWxmclM4VDhV?=
 =?utf-8?B?ZDZHQnpMWExiV0xJSFBUMER1Vjg0RXhRTkdWcnpzcUxHUDFqM1JnY1VFNm42?=
 =?utf-8?B?SG83amI5c2FjUjNFQUFZdEgvaVZSa3B3QUE3enAxakZsNFB6TWZkd2hPWkJy?=
 =?utf-8?B?WDMyWUJONDRNMDVjbGtnWHZFNCttZ3FzN2ZwUWoxUVpIZk9scmdXNjhoeUJ6?=
 =?utf-8?B?b3dRN1ppM0JicVEvcnhSTXVyMWsrWmQ5eDJ3VkJsS1RCN2kzZE9iTXd2ekVN?=
 =?utf-8?B?Ly9WK1ZYTEo5OFVpdDUwc21tVi9uVGZjejZGSWNqWmpDYWxySm94cEVQZTJ3?=
 =?utf-8?B?am9jQVVRODhYK1ZnNXFpSVhlUDlUakQvcVdFcTVNbVFCa1N2Nyt6dEo5ZHlo?=
 =?utf-8?B?R01sTzFaNTMxaG05QTE5ZXRjWUw2azJmQTNHRFlsVDRTTWlkcWd2elF4bGYx?=
 =?utf-8?B?Q2pXYis3b2lXQTc3c3crV1F6L1BscW8zMEdFUWkyYnM4d2Vid25QVkREbTJS?=
 =?utf-8?B?Nkd0U0o5cGxHL0dBNFVpMlZwUS9lT2N2b3A4UXFIekgrZzB5bU5zK0lleDk1?=
 =?utf-8?B?RHNwSktFTGVMSGNIa09kREtqYVRWdnR1Mi9yblE5UUg4VmFhSWZkRnMzaElV?=
 =?utf-8?B?RUkwMzJqbzFWaXpvMXhYQlA3QW5iUXppQ2lvZGlLcHhVckdOUFdDRTVzSWpj?=
 =?utf-8?B?K1prMjdIZnFwQ0FpUjZ3UnBLSVIvMWVYbDRqUGtnYnFqL2lmMFNwNFJGVklo?=
 =?utf-8?B?cTBzdkFzSlpaRklld0Q3d01DSkZQYjk2NkxXRlUvZDFxWFhGb0RIbk9XdkZW?=
 =?utf-8?B?dm93MTZRTCtpRUpZREVuYkU5QUZTaEEvb3hRMUdXeUlydmJxdFFiQWZ4MHRB?=
 =?utf-8?B?OHFMTmV2ZzBoaUZrK3M3Z1MwMUhrZ2hDdkNXVXN4SHlaSVBXMGQ4bXQwenJI?=
 =?utf-8?B?S2FWRXFSaFZoblpqeVovYTVvYlZ6WDJ0cWN1T2U5eFZxLzE1dkIyYi9kbHVn?=
 =?utf-8?B?QSs0VDZoTG9oclpkTU5CSUdyM20reCtmeFlzbWZFYTlwR3BRMm1McllCRE1Y?=
 =?utf-8?Q?0j9/Nn0O73aHYQ35uCpFPhrRwEqfbzhsdq1XM3gnhcQ3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4e0597-c5ca-4c22-a20a-08dab369e0c2
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 13:40:55.3104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wcm3zdU7QZKsazXSI5UJuWx0Giw0RSAFFTihcVm3+elRNTXCbOiVCCzOsHrwzil5CNHp5L8Nt55vHL9YPDysyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5627
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05/10/2022 09:40, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
> 
> Remove redundant codes for getting the vbus supply of usb3 ports because
> we get and control the vbus supply by the companion usb2 ports
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
>   drivers/phy/tegra/xusb-tegra124.c |  1 -
>   drivers/phy/tegra/xusb-tegra186.c |  1 -
>   drivers/phy/tegra/xusb-tegra210.c |  1 -
>   drivers/phy/tegra/xusb.c          | 10 +---------
>   drivers/phy/tegra/xusb.h          |  2 --
>   5 files changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/drivers/phy/tegra/xusb-tegra124.c b/drivers/phy/tegra/xusb-tegra124.c
> index db56c7fbe60b..f4f75ea033b8 100644
> --- a/drivers/phy/tegra/xusb-tegra124.c
> +++ b/drivers/phy/tegra/xusb-tegra124.c
> @@ -1652,7 +1652,6 @@ tegra124_usb3_port_map(struct tegra_xusb_port *port)
>   
>   static const struct tegra_xusb_port_ops tegra124_usb3_port_ops = {
>   	.release = tegra_xusb_usb3_port_release,
> -	.remove = tegra_xusb_usb3_port_remove,
>   	.enable = tegra124_usb3_port_enable,
>   	.disable = tegra124_usb3_port_disable,
>   	.map = tegra124_usb3_port_map,
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index f6099609f154..25db49789f41 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -1213,7 +1213,6 @@ tegra186_usb3_port_map(struct tegra_xusb_port *port)
>   
>   static const struct tegra_xusb_port_ops tegra186_usb3_port_ops = {
>   	.release = tegra_xusb_usb3_port_release,
> -	.remove = tegra_xusb_usb3_port_remove,
>   	.enable = tegra186_usb3_port_enable,
>   	.disable = tegra186_usb3_port_disable,
>   	.map = tegra186_usb3_port_map,
> diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c
> index eedfc7c2cc05..ebc8a7e21a31 100644
> --- a/drivers/phy/tegra/xusb-tegra210.c
> +++ b/drivers/phy/tegra/xusb-tegra210.c
> @@ -3078,7 +3078,6 @@ tegra210_usb3_port_map(struct tegra_xusb_port *port)
>   
>   static const struct tegra_xusb_port_ops tegra210_usb3_port_ops = {
>   	.release = tegra_xusb_usb3_port_release,
> -	.remove = tegra_xusb_usb3_port_remove,
>   	.enable = tegra210_usb3_port_enable,
>   	.disable = tegra210_usb3_port_disable,
>   	.map = tegra210_usb3_port_map,
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 46661a8d5bbc..0eaab6d846bf 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -960,8 +960,7 @@ static int tegra_xusb_usb3_port_parse_dt(struct tegra_xusb_usb3_port *usb3)
>   			return -EINVAL;
>   	}
>   
> -	usb3->supply = regulator_get(&port->dev, "vbus");
> -	return PTR_ERR_OR_ZERO(usb3->supply);
> +	return 0;
>   }
>   
>   static int tegra_xusb_add_usb3_port(struct tegra_xusb_padctl *padctl,
> @@ -1018,13 +1017,6 @@ void tegra_xusb_usb3_port_release(struct tegra_xusb_port *port)
>   	kfree(usb3);
>   }
>   
> -void tegra_xusb_usb3_port_remove(struct tegra_xusb_port *port)
> -{
> -	struct tegra_xusb_usb3_port *usb3 = to_usb3_port(port);
> -
> -	regulator_put(usb3->supply);
> -}
> -
>   static void __tegra_xusb_remove_ports(struct tegra_xusb_padctl *padctl)
>   {
>   	struct tegra_xusb_port *port, *tmp;
> diff --git a/drivers/phy/tegra/xusb.h b/drivers/phy/tegra/xusb.h
> index d66b22bfeaa7..1b6b780efeec 100644
> --- a/drivers/phy/tegra/xusb.h
> +++ b/drivers/phy/tegra/xusb.h
> @@ -360,7 +360,6 @@ void tegra_xusb_hsic_port_release(struct tegra_xusb_port *port);
>   
>   struct tegra_xusb_usb3_port {
>   	struct tegra_xusb_port base;
> -	struct regulator *supply;
>   	bool context_saved;
>   	unsigned int port;
>   	bool internal;
> @@ -382,7 +381,6 @@ struct tegra_xusb_usb3_port *
>   tegra_xusb_find_usb3_port(struct tegra_xusb_padctl *padctl,
>   			  unsigned int index);
>   void tegra_xusb_usb3_port_release(struct tegra_xusb_port *port);
> -void tegra_xusb_usb3_port_remove(struct tegra_xusb_port *port);
>   
>   struct tegra_xusb_port_ops {
>   	void (*release)(struct tegra_xusb_port *port);


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic