Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 17:32:21 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Mitja Spes <mitja@lxnav.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Tomasz Duszynski <tduszyns@gmail.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: pressure: ms5611: changed hardcoded SPI
 speed to value limited
Message-ID: <Y1K7hWKl0siEtaAl@gmail.com>
References: <20221021135827.1444793-1-mitja@lxnav.com>
 <20221021135827.1444793-3-mitja@lxnav.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="v0Xw8fmF8ByqwP89"
Content-Disposition: inline
In-Reply-To: <20221021135827.1444793-3-mitja@lxnav.com>
Precedence: bulk


--v0Xw8fmF8ByqwP89
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Mitja,

On Fri, Oct 21, 2022 at 03:58:21PM +0200, Mitja Spes wrote:
> Don't hardcode the ms5611 SPI speed, limit it instead.
>=20
> Signed-off-by: Mitja Spes <mitja@lxnav.com>
> ---
>  drivers/iio/pressure/ms5611_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5=
611_spi.c
> index 432e912096f4..a0a7205c9c3a 100644
> --- a/drivers/iio/pressure/ms5611_spi.c
> +++ b/drivers/iio/pressure/ms5611_spi.c
> @@ -91,7 +91,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
>  	spi_set_drvdata(spi, indio_dev);
> =20
>  	spi->mode =3D SPI_MODE_0;
> -	spi->max_speed_hz =3D 20000000;
> +	spi->max_speed_hz =3D min(spi->max_speed_hz, 20000000U);

max_speed_hz is a limit, and the max frequency the ms5611 support is
20MHz.

Best regards,
Marcus Folkesson

--v0Xw8fmF8ByqwP89
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmNSu4EACgkQiIBOb1ld
UjK1VQ/9Fr5fWh7p566FC/TtB0AR3vyoNNvzkF/tnqTagW0bJ4+uelZqyFYxn8Iw
kS97p1YUm7zHYGWMAL2UCD8+BnGmSJBgtqxEMoa/Ew5ULHCvEVRfpVUFoM//e5EJ
fNFP65loD41VTggRSNTOcNUbdBMrHpzo5L/ENecV4fWQrwc1xKd4DDCu/dL0GlAd
2uQrKcOJbBJh4wR3n7SslOqsL4cQgZWPi89S/xvVf5VPJNjoUAmf0Lic4ZVT1FJn
ZffsTT+oTrkfUnddb26djSp+KxMg9mqaK3OPOFyWebxe4Cp9Ot+4I3uIGguSA9JP
byvoQsg17ds/EalPufTcVl11+YVqrBQ7qnUM/zlXirTzeSbm4NkEQagHkVrwgi3H
dHoF+bURYV23enpF7FQjCm/XsFHXYuiop7NzFtYTZbC9O4+g2C7i806fit0XhbY+
AJ7irSOgVTMat+UUi8M0irAVbI+GHl8U9ww/ptrghm2hUnQmmvlrI1BLYu8LOZ9P
tdtUq0a+YYFlX+1fwDUIYdLV9ELZlJOIfmvlX5skBge8C8H0qWPLTOdxISra8pP4
QIFWPQYkx4PPOcNEppCc0fX576aiYyY9RLZany6vRKspgIJwNton90OqjmOzO0RG
2V6zmX7NGPtalh1Nz1t8RRtT1UvaOqBd4hfZG+KF4yoxgO/5QwU=
=92FB
-----END PGP SIGNATURE-----

--v0Xw8fmF8ByqwP89--