Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2925343rwi; Fri, 21 Oct 2022 09:21:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7lRUT9VCjBYHFvVWg5wFva3uZKRvzhFKaFKX/nYymvXAr/ofQ5kdsmtjKn7LUTNlqHM5Gg X-Received: by 2002:a17:90b:3755:b0:20d:9df4:be01 with SMTP id ne21-20020a17090b375500b0020d9df4be01mr23000918pjb.51.1666369299124; Fri, 21 Oct 2022 09:21:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666369299; cv=none; d=google.com; s=arc-20160816; b=swb2ACFmAuZ+IE9k7uXiqGWITpBMhuxrs1cHyVDUJUSFn+c1z79x6TN93xJwJebTag kwHNOphO5paL3yXQ+gcvTPml+BmmRlnW4ya7zKv1x1EHGGNiXYKQYWfXSWcYZGmdDb/c h54DnM1GS7mVCsfkP7u+LxpmwiI5nuob7cBm+r0qMSj2RolfuX7D2ACzSeEunrwvNug4 wQ5+6SowkeupLyI3uYooEB7BX+/pl+wW2/muf+stAyQBfw3be263c+VD1wNFhRj0SS5P RuOg9lYcT1znUuIHPErE0BH0JaWr41ATt909/SwwAcaIwWY3V23KhucWCZ9a/i42G8jM 0gHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=C1n6WS9gwLzO9NZQ68iLdW55eTrE8mdFW63YZmpVqpw=; b=a3ANUKf9nFEKfQ2Cui3i6TJ5k7exzBMYgDV2w+ZG5wp95pHl/GLBbwZUmfDdXPWl2d tOLPMUKc2cpDi3XCyRj1h+ewPSA49Jo8zLfPmzQ7c+vozV7jPok9m3KCtkg4Tqlfv1we Vn4O3RfMj+o6W6wTJNNjD2/BA/O1PxcJLVXn3pn57X9rmWtjnjds1ut4KipWjD1QlYcM XYAtZqY45tHza0nx7bngP5Qhr/Xng0fy2XeBJ9oEa6i6da1Z25QZTnRvAKKedL/f8lKH IeE91adHyNvicew+I3d2qdRY0res8LuxelMRNXAb6kwX/fob48wqStsj9Sfdsq5aaD6d DMNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PNHUO+oM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a632a11000000b0046e9da7e3e3si5679029pgq.828.2022.10.21.09.21.23; Fri, 21 Oct 2022 09:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PNHUO+oM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbiJUQLo (ORCPT + 99 others); Fri, 21 Oct 2022 12:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbiJUQLe (ORCPT ); Fri, 21 Oct 2022 12:11:34 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C1D52610B6 for ; Fri, 21 Oct 2022 09:11:32 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id i3so2972828pfk.9 for ; Fri, 21 Oct 2022 09:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C1n6WS9gwLzO9NZQ68iLdW55eTrE8mdFW63YZmpVqpw=; b=PNHUO+oMiw1AtRbglOEq5LakLB6qyp4eKEOXQMKpH7aicNdAUC3FHTZJiz78Arv2OG O0lncx58OwP7zNT4I/0qfrinTydPlHpfnukborQzZaRYE5nu8htGYx3dAUdIzE9kPs+u oOlfnQMFEv9SNOjV+yVHaCbvVeIET658Yqurk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1n6WS9gwLzO9NZQ68iLdW55eTrE8mdFW63YZmpVqpw=; b=HwI3kP95I4/TGmiqNcjT+E3WKMgRcjQ8twrMS4bjE5RjYl4Eo5jsh/lO4eUu4ouZkN 6Rk5Jk9rdPE4BiazD5/oWIicg5Uz1cgh9ZBvzFQNxNZr+ZEQi5fXtcwDsu9CwinAx05C fSqHNQ4s8jK9YETPUxA+lFuv3lRhy0h6V8+xdNZ/rqMM2z3+aBe1JhfU2S+1YU1XinlX qKNetFVQwYB+jZxiD81yNpg7xbQTF92TBWG4RHcvxdq3CePNosfkA8DOYOtzG6GOY6EP 5p/6SbXYPXcActIin+ZjHQ3t9vT9YbInWXOd3r1KMwKV1MjckBzPuURYsaSuQXfdh6TI 7fIw== X-Gm-Message-State: ACrzQf0EIBb6qNiRII3tdivCTXt/3+OM6woHFhhI774Apy8U1uZeyDsj aielHu31IOIK+AHSNft4ZKClHQ== X-Received: by 2002:a63:2a08:0:b0:46a:e2a8:4ead with SMTP id q8-20020a632a08000000b0046ae2a84eadmr17177587pgq.132.1666368692172; Fri, 21 Oct 2022 09:11:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b8-20020a170903228800b001830ed575c3sm15175956plh.117.2022.10.21.09.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 09:11:31 -0700 (PDT) Date: Fri, 21 Oct 2022 09:11:30 -0700 From: Kees Cook To: Miguel Ojeda Cc: Andrey Konovalov , Marco Elver , Arnd Bergmann , Andrew Morton , Kumar Kartikeya Dwivedi , Nick Desaulniers , Nathan Chancellor , Uros Bizjak , Dan Li , Alexander Potapenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] compiler-gcc: remove attribute support check for `__no_sanitize_undefined__` Message-ID: <202210210911.1DA1106C@keescook> References: <20221021115956.9947-1-ojeda@kernel.org> <20221021115956.9947-4-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021115956.9947-4-ojeda@kernel.org> X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 01:59:55PM +0200, Miguel Ojeda wrote: > The attribute was added in GCC 4.9, while the minimum GCC version > supported by the kernel is GCC 5.1. > > Therefore, remove the check. > > Link: https://godbolt.org/z/GrMeo6fYr > Signed-off-by: Miguel Ojeda Reviewed-by: Kees Cook -- Kees Cook