Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2935275rwi; Fri, 21 Oct 2022 09:28:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5kBmUJAjrorAp86Qa9S00R88piJd82gZGbU03gV2tM7kyDINUD7Lm4DTG45x/lpRHQkvr9 X-Received: by 2002:a05:6402:1e8d:b0:454:79a9:201f with SMTP id f13-20020a0564021e8d00b0045479a9201fmr18390428edf.176.1666369729686; Fri, 21 Oct 2022 09:28:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666369729; cv=none; d=google.com; s=arc-20160816; b=pzUQOMUhmXFFnRu5zsNWmymHo9/UontYoPp0LwR3bfB9Fhdd9fMeoIYQnkAz7re8L5 zHMuBlNBIh56LMFnG5YmyERwopPG1X4ThEA2CPcvQb//iuqIaBBKQJMTct/cprmd3Flw D6HGUH5+b48i4xFhd3fRNIVTPENHwuMjQYMa00f6aGDSy8HEb/pP1DNQrDH9y+7eZusm NhKra7JV8ElF7RrlWHtLccloUofIppnOVT6+FRcFhSlu19pKPhkHsQFUEkPnPZHNJvjk usmtVhMhWya/p7dwCVLe9XcCKmz+92wLE8SBYCk6fIH5C4e1x+vkHtozonlIn3ZCG0K5 mgbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=vvEJ3k7MXkgB/gp+HqRd8a0uzvZbVYbotzkyU4BLhCo=; b=Hfx2e7p/ilR82RGYDKO0PzFxTkuLjQDCzHDsW5nqP8aKUHVOOTCGTjLSMhBOWXBNhc mS1RkHJfy4QsCSYqiWx7swMCE9lDHIvN1b/M4f+K432UpqPbx6TdeMKRA7BDQKad6xIo 1lnsqrp1L+aMX2T71FU+YworzJ34JkiKZfSBVDNRyTGtGEsBTnDvkCgj5CoYZ+xWhlRr akGyGNhNk+UO9R+H8QJpT2R0ypL9Qvfc81s74neOTGMr6877UE1QbzdsXjAcXvrtJ4M6 0raBoSJ2onU56HPKm106QtYhODzqplOy92+nNxs0Nc8rQd7MOWG3Llvcu8IyQ800LrbA pIpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UgOkjA0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i16-20020a50fc10000000b0045c26758001si17505170edr.539.2022.10.21.09.28.24; Fri, 21 Oct 2022 09:28:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UgOkjA0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbiJUQPU (ORCPT + 99 others); Fri, 21 Oct 2022 12:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbiJUQPS (ORCPT ); Fri, 21 Oct 2022 12:15:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D439E0FE; Fri, 21 Oct 2022 09:15:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF3D761F15; Fri, 21 Oct 2022 16:15:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 816BFC433C1; Fri, 21 Oct 2022 16:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666368915; bh=iCewE/mUxFUwxBVTnDRE81TzLYGC1UfmkQxqs8i3xdI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=UgOkjA0vCyTWZOEVc0oZ4JGwhq2kdluMgDqvKxBto23HIa/+qVg2HuTj8IPoirRh3 kwSGgDINHoE4fvG4RsW1tyq6DKMjNxwLoFuxE5TEs+CkhZp592InEZ1VXE9MlCcd7f xXHc10Ha5fwttkEuWsvAKBs4se4DMNTdEo9Jrhw4Qo5zOlAjuKj+sQnfF3BbtWQs0Y 35bFprox0Lar/dETz922Q3AwU1CJR+R2NHNAI2r8v3rsaD84Aa9z9MuMll1moy9O73 0XYEhGoJG/nBTTXQQNNo4C88G7tEdm42dZKyJ5F6NR2atupQfzH6ESO7qyk3gueFhb fwVEKgbbEn5lQ== From: Mark Brown To: Martin Blumenstingl , Krzysztof Kozlowski , Rob Herring , Neil Armstrong , Jerome Brunet , Amjad Ouled-Ameur , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, Da Xue , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , devicetree@vger.kernel.org In-Reply-To: <20221004-up-aml-fix-spi-v4-0-0342d8e10c49@baylibre.com> References: <20221004-up-aml-fix-spi-v4-0-0342d8e10c49@baylibre.com> Subject: Re: (subset) [PATCH v4 0/4] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle Message-Id: <166636891222.378315.9501642129883885314.b4-ty@kernel.org> Date: Fri, 21 Oct 2022 17:15:12 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.0-dev-fc921 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Oct 2022 15:31:24 +0200, Amjad Ouled-Ameur wrote: > Between SPI transactions, all SPI pins are in HiZ state. When using the SS > signal from the SPICC controller it's not an issue because when the > transaction resumes all pins come back to the right state at the same time > as SS. > > The problem is when we use CS as a GPIO. In fact, between the GPIO CS > state change and SPI pins state change from idle, you can have a missing or > spurious clock transition. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/4] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states commit: 031837826886e254fefff7d8b849dc63b6a7e2b9 [2/4] spi: meson-spicc: Use pinctrl to drive CLK line when idle commit: f4567b28fdd4bede7cab0810200d567a1f03ec5e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark