Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <daa60cf0-0dde-ea2d-211a-70a9e0efc1b8@oracle.com>
Date:   Fri, 21 Oct 2022 12:24:04 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v4] scsi:iscsi: Fix multiple iscsi session unbind event
 sent to userspace
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Steffen Maier <maier@linux.ibm.com>, liuzhiqiang26@huawei.com,
        linfeilong@huawei.com
References: <20221021235754.1968981-1-haowenchao@huawei.com>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20221021235754.1968981-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjliZi8xOFBDSGlPREFsR1hRTnd2ZVFxSm80dUlsN2psYms5VnVhSmtIbHQv?=
 =?utf-8?B?VUJkR2cvM1paaEVzRU1VYjBldlBiY0Q2QU80YlQ2UTFjZ2pPTlc5VEZoQTB2?=
 =?utf-8?B?UWJ3amtxNnpPajhNR3JWaksrbklid2ZRUDJneEJDWDcrTk9sTlNXd2grNnBK?=
 =?utf-8?B?NVQ5RTRlRWg4b3dldmljRExBVFVLaXAzdWxuU0ZVdU54Z2RhbGs5K1lMbnJx?=
 =?utf-8?B?aU9SbkdVYThiY0JqOHFTSWdXcXZSdzhBS2YxNmkvN2M0RkpyT3dsTStwUDNF?=
 =?utf-8?B?SkpaenVCNitIU0lwNWxlYTN0VUVKelJKQUR4S05jMG5MRm50YzZLVnNoa3J1?=
 =?utf-8?B?R2NlTE5wOTZMYlZPT0ZFdVFpTE1hYkZET0tiRVNYOXpIN3BxZXVjbzRYVVNZ?=
 =?utf-8?B?aHJzK012NFZNbkJRMUJDYkRkbi9ZWlFFeXVpVWVycHJxTEhuaXVNV0k3QUFx?=
 =?utf-8?B?dm9oWi9mNlVrNktzSzRnSFBpUkNPeEFvUU0wMzJSVlpWVzJWbzNQSitJc0JR?=
 =?utf-8?B?dlVTUUdsYUtSdGwrVTF1SGFTcUx2SDd1RVBhVGx3OGx3Q0V4eFF5UVRSeVVZ?=
 =?utf-8?B?SDZkTGJGSDU3dEJKN0NCNzNxNENwRnFvL2lEczM1SjlXQ08zWVRsVWdkbFhJ?=
 =?utf-8?B?eU50cUxTTHI3QmRqQ1hQRCtQbjhvMjdpdjdKbWhpTlBWU3ZGWnN6RGpKWUtW?=
 =?utf-8?B?d3lBZGRDcVU0WlZhZlRhK2szTXU5Z1pmYTNHT1hycktRMEp4UUU1WUh6TkhP?=
 =?utf-8?B?Umdpbnc5cU0rRzhhaUdhejlrcEZUZ2ViRHNnUGN1VHNhTXJKZXlUZGVMbGtD?=
 =?utf-8?B?bDVYa3J2bmlaUzRyTlRZY2xzM1gyYkIyYXNJOHZuT3gwK1lKd2V6T00wemdM?=
 =?utf-8?B?SEtYRXd2MmtVbWs3bnFjSm9neUQ0cEh5QXladzdSZXVFTytQSmZtdlpiMUp6?=
 =?utf-8?B?d3dtYUNUbEFma1cvSEdWR01OVmdZTXN6L1JGWmFPUjVWOFhESTZTekpkQ3FZ?=
 =?utf-8?B?M2FnclZyYVluVjdPRGRiQTRUZ3NSUjlQUTU5QXRzKzExMHByb1Y2NGZWRlZs?=
 =?utf-8?B?UW1zbkpzNnFmU1BiMzhoRGZXMVZMZEErS2Z3dzZhYmVHR0s0NzNVWURwNkZk?=
 =?utf-8?B?ZDV4c2xBWXd5QytPbTRDN2EyZW5ka2FMSk9lbko3U2Izdnc0NFJaWEhxWDB5?=
 =?utf-8?B?Vk93Ni93VDU3MkZWWjNwZjBieEtyaURqSW9uN2VZNjRiaEpZTHlpQnEyb2tk?=
 =?utf-8?B?ZWdNUUVSN3N4NE41cXF0dkxRQWl3bkFqNzdvbUFNNDRjZGxCRm1xOXJJZ21Q?=
 =?utf-8?B?Q1RvcE02c0tobjBDV2pWc3Ywc1hzNjlCaWJvbDl6Nk5KSzZCYXAvcVpsZ29H?=
 =?utf-8?B?cEhmOG51b1pEWStqekxGN24wWUNlMTR6dmVKN21EQ3QwbklmUXM2azZzUkZn?=
 =?utf-8?B?WjFyZ3ZPNGdpeE1aK0V2UmlKS3VnVDlLeUFqc2hDaHo2eGFtMTZEaFF1WWFM?=
 =?utf-8?B?Tnp2YlRBZzN1cWhvSHp0bkd1ek1VNy84SzQ2ZGlORnh3ZXdHMEVBUkJEd3E4?=
 =?utf-8?B?VEptRGNScS9xWlpoSmNaWCtrSDA2TGZpUEFqWTFJdDhOTjFqZ1h1a3gvc1cr?=
 =?utf-8?B?YW5NZWdMRWNiUUhMdUZ4aVpvQTRVemNGVnVpb3ROWnhsYU4xYWMySnNOZTQ0?=
 =?utf-8?B?cEUrcytoT2tocFFtL1N5RWpVRnh6L1NNMVpZbDBaNWdFbXdEb0R1VlBlNDlK?=
 =?utf-8?B?Snhydk9yMkdWNjVaTzhySjBzMUo5R01VWEh5ZlF0b242N09SWU9UcDZkZ3Zy?=
 =?utf-8?B?L2R5Z0FpMmRpbVJKUTJ5Tnc2eWFWdFEwTGswMWdZeHNLdmVRQUllU0VsZ3Jy?=
 =?utf-8?B?UEIyVk9HcUVqczB1TDJpS1psZk5EVFE4QUtsS2lKbG56MlBlRWJDZWhCckF6?=
 =?utf-8?B?QW13bGwzb0liazlKTTNEd012T0hEaVlLaDFseC92ZWRvV2t0eHhBbmZYOEQw?=
 =?utf-8?B?alRGQnpISmg1cm5aK0Zjb3l6RE9kTFd5Q1FzMUZXNlRKUDUxelBEUTQ0c041?=
 =?utf-8?B?dnZkWThndSt5dmFyWTNIU1VKT2I0aEdPRXBGMHlKK2huUUdOZ3BmV3puVEI0?=
 =?utf-8?B?dTc3Nml6SmFGdVBhMG5iOFJYWUdFSS9aQWhWWURWSDFOWWRiWVRIQy81QTFB?=
 =?utf-8?B?Umc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cae3d5ee-bead-47e7-e1ce-08dab3890ed3
X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1463.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 17:24:06.9348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7SK+JxeIfrPwBiUtZlXBLHp2pZqYC4DWrggcpC7WSBeeCuFbsxwdzWGvnoSRmhUk+PhzeRzPg3TnMqr7eLMLPQZWlmzlIfEqcyRqNQ8N7ck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4887
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210210104
X-Proofpoint-ORIG-GUID: q49RswqqX8zN4nByB5r4Y1MjDmtf1IpD
X-Proofpoint-GUID: q49RswqqX8zN4nByB5r4Y1MjDmtf1IpD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 6:57 PM, Wenchao Hao wrote:
> +
>  int iscsi_session_chkready(struct iscsi_cls_session *session)
>  {
>  	int err;
> @@ -1899,6 +1922,7 @@ static void __iscsi_unblock_session(struct work_struct *work)
>  	cancel_delayed_work_sync(&session->recovery_work);
>  	spin_lock_irqsave(&session->lock, flags);
>  	session->state = ISCSI_SESSION_LOGGED_IN;
> +	session->target_state = ISCSI_SESSION_TARGET_BOUND;
>  	spin_unlock_irqrestore(&session->lock, flags);
>  	/* start IO */

Hey,

Sorry for the late reply.

For the initial login we have not scanned the session above, so there
is no target yet. If iscsid is restarted at this time, then iscsid wants
to sync the session and also do the initial scan.

To handle that case and also better match the state names with the
session's target state we can:

1. Move the above line to iscsi_user_scan_session after we have scanned
the target.
2. Add a new state ISCSI_SESSION_TARGET_ALLOCATED to reflect we have
allocated the target_id, but not yet scanned.