Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad716b6f-3d1a-8aab-b452-2e01769348dd@intel.com>
Date:   Fri, 21 Oct 2022 12:07:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH V2] x86/split_lock: Add sysctl to control the misery mode
Content-Language: en-US
To:     "Guilherme G. Piccoli" <gpiccoli@igalia.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, luto@kernel.org,
        corbet@lwn.net, linux-doc@vger.kernel.org, kernel-dev@igalia.com,
        kernel@gpiccoli.net, Andre Almeida <andrealmeid@igalia.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Joshua Ashton <joshua@froggi.es>,
        Melissa Wen <mwen@igalia.com>,
        Paul Gofman <pgofman@codeweavers.com>,
        Pavel Machek <pavel@denx.de>,
        Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
        Tony Luck <tony.luck@intel.com>,
        Zebediah Figura <zfigura@codeweavers.com>
References: <20221014180506.211592-1-gpiccoli@igalia.com>
 <44b41091-d474-9f80-fcf1-93c8d1316272@intel.com>
 <267fb708-9fae-f651-d8c6-e34a873d668f@igalia.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <267fb708-9fae-f651-d8c6-e34a873d668f@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/21/22 12:03, Guilherme G. Piccoli wrote:
...
>> 	if (need_release_sem)
>> 		up(...);
>>
>> That's nice and compact.  It's also logically easy to follow because you
>> can see how the need_release_sem gets set only after the
>> down_interruptible().  It's also nice to have both sites share the
>> 'need_release_sem' naming for grepping.
>>
> 
> ...but, this is a very good suggestion, and will eliminate the need for
> two delayed_works, right?

Yes, that too.