Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 15:47:46 -0400
From:   Joe Korty <joe.korty@concurrent-rt.com>
To:     Marc Zyngier <maz@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] arm64: arch_timer: XGene-1 has 31 bit, not 32 bit, arch
 timer.
Message-ID: <20221021194746.GA5830@zipoli.concurrent-rt.com>
Reply-To: Joe Korty <joe.korty@concurrent-rt.com>
References: <20221021153424.GA25677@zipoli.concurrent-rt.com>
 <864jvxnj65.wl-maz@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <864jvxnj65.wl-maz@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mM5qYkIy/goyhhwa0esG2uWU1xzG9ynB/1SFUJZpkRyUdwRhc5pc3yuUFEVK?=
 =?us-ascii?Q?dAkBopNZHNot1rw9tWDngoOdtN9dWuBCayMGiMJ1bbmeLlIHalRFr2Ewy85I?=
 =?us-ascii?Q?OpFUEcweJ9Q6rLDjmk/WnEtUXyy8ydx5gxGW+NJ/kn13tOx0grqUXP1hvNVT?=
 =?us-ascii?Q?wz5Ps6Nw0MTQ2h2iInnApeTuZvOdU6YgFUHa/ZvbhCbx05uyGtWdsxzhe/Ua?=
 =?us-ascii?Q?ZbduM6zrVlnBtz9XR8KV9LqVLCadDRQx6LcJls4vb8To1TXAAd7kqVRmcphC?=
 =?us-ascii?Q?qOHsNI6Br8IzRCVUkHeAxslJII2YzxNq2OMZ/gqXTy0w4hKBQifZ8g4epWu/?=
 =?us-ascii?Q?9LoLs6E8pFNovH79+Pqyuz921gTw3c2z00aqn7O1nf8K4gnEooYiXojeC95s?=
 =?us-ascii?Q?0Y2RewQpY84MiSqUiWGqj+icrhFbKIZ+x/WjbQbPtOfXThtZ4LMNf69i9y8U?=
 =?us-ascii?Q?e/7PR8ZfYdz/kROyQYWD88kgHc1yuYFQT5pHIWho9QHl4hxHadvJkqbOehwP?=
 =?us-ascii?Q?jVHbpUmLbJijKmQFfklFKKrYExYR3bTl10HbamfLpS9SHXo6JML6C7NTHHkD?=
 =?us-ascii?Q?609V5LkVQgkRCAQDs7p+oYmYV5KxzU7T08A/0hHBRZK6rYefsapdlPIMYUTq?=
 =?us-ascii?Q?vOqEgaMbnkuPGt+YgtSMXQjxy1ETwZPWabdK4T10HI4vhq1FVl/8f8WKCb9V?=
 =?us-ascii?Q?ziwDy5PjjeezZMajJZPpxjfhl+kX1Tyz2nrUvNIZTow3UBpzQR4yJrkdoXDp?=
 =?us-ascii?Q?+U+WEaBu5InhLrOKhRURWqCqFjt5JBHrU5yFTEPpCevxsyOJYncTx9zuExmA?=
 =?us-ascii?Q?ggqRTGlR9Dz5d1cnbkgHsiU2O3yfXiSNw/WFlOOYSvdVJJ8lZr4+Vaedi1LW?=
 =?us-ascii?Q?kuiLZwCVRY0DoZkJHHL5rFAWRAB+m/117yJ/ZUM9do28DmmHJsoqUQ04gIt9?=
 =?us-ascii?Q?X60cPH7kEXYAv+wH/DOt+WmosIaG8NThgdWL2ahwPxyut/kcD2qyWbVmIQZk?=
 =?us-ascii?Q?9MsCVDEM8E8j3lYFANpctiFDqhVR8czNU2WzLbY0bLgsA67iq1pmJ3Nlk5OM?=
 =?us-ascii?Q?n8WfiZ6jGlNne8QgH26ngGPr3WpeJT9KQNg2rZZOyU1mtme7uYBXuOl6O3sf?=
 =?us-ascii?Q?qR5BcOy8mPs1jGwYSUZm/0ApsicUP3ia/UFN8SznE9WBupghRH3DSxECTcSd?=
 =?us-ascii?Q?U81ItAfSScQy0lJJJVRDt+LLWv9jJaEjNHXXuC5Tr6fLE12QNyvcHEuwFtK4?=
 =?us-ascii?Q?JirF7qPnsoNu+AQpDktygOxXWOR3Ryo87Oxa9+2Qy2B9PagGkAwhBfTVnTO/?=
 =?us-ascii?Q?qlVJVPdDII6JUFAylX8c/ytEpw3HXfwsWzi6EO4XXm5C0ddyCuKC3ConCW1i?=
 =?us-ascii?Q?RpJhFY0bavydSaJovv/Y02seKlEm7iQ/cEhswkD7JjGBvEK3K0jamtMTYG7S?=
 =?us-ascii?Q?CyuDoy3Xktwu7JvGM3tHLq2EHeJk0skQIdxJTlZkoYgE4mOfaW+lv593aKEz?=
 =?us-ascii?Q?q+o7GfmmeP7PMbsikbMDWvjvvb7srSZULgCazBLYC9C4arNcLyKGjm3HfInj?=
 =?us-ascii?Q?9K3tz/vMT+Wx8pzWeoD8I6a5bVhhDONhTsjaIs6lOMrwKH/4BU4P9hhTbPls?=
 =?us-ascii?Q?Ng=3D=3D?=
X-OriginatorOrg: concurrent-rt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72ea1dab-e3b2-45dd-6cdb-08dab39d23b1
X-MS-Exchange-CrossTenant-AuthSource: DB8PR09MB3580.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 19:47:51.7351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6cce74a3-3975-45e0-9893-b072988b30b6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 590R4Bb5C2hox1xEC+ocyVO5m/i8YJI97l1iYe2z7TgHV1CYivwHcivG6MIjNAEOugvmev3rywsVgJ6HarAn9zCEIGl4EWFZgGFFnSLqONQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR09MB5906
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc,

On Fri, Oct 21, 2022 at 07:08:50PM +0100, Marc Zyngier wrote:
> Sorry, but you'll have to provide a bit more of an analysis here. As
> far as I can tell, you're just changing a parameter without properly
> describing what breaks and how.

There isn't much to analyse.  For ages, 0x7fffffff (31 bits) was the
declared width of 'arch timer' for all arm architures, and that worked.
Your patch series made the declared width vary according to which chipset
was in use, which is good, but that rewrite changed the above mask for
the XGene-1 from 0x7fffffff to 0xffffffff.  That change broke timers
for the XGene-1 since it seems that, in actuality, it has only a 31 bit
wide arch timer.  Thus declaring that arch timer has 32-bits is wrong.
This mismatch between the actual and declared sizes would cause arithmetic
errors in the calculation of timer deltas which more than accounts for
the hrtimer failures I am seeing when running 5.16+ on my Mustang XGene1.

Only one line need change, the rest are fluff:

-             return CLOCKSOURCE_MASK(32);
+             return CLOCKSOURCE_MASK(31);

> Also, this isn't much of a patch.

I don't know what this means.  The patch contains all that is needed for
the fix, no more.  I could add more comments as to _why_ it is 31 bits
not 32, but I don't know why.  I only know that the motherboard behaves
as if 31 bits is all that is available in the hardware.

> Please see the documentation on how to properly submit one.

AFAICS, the only submission mistake is that the 'Cc: stable@vger.kernel.org'
line is missing.

Regards,
Joe