Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 14:18:12 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Miguel Ojeda <ojeda@kernel.org>
Cc:     Andrey Konovalov <andreyknvl@gmail.com>,
        Marco Elver <elver@google.com>,
        Kees Cook <keescook@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Uros Bizjak <ubizjak@gmail.com>,
        Dan Li <ashimida@linux.alibaba.com>,
        Alexander Potapenko <glider@google.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for
 `__no_sanitize_address__`
Message-ID: <Y1MMlE3A2Gdw599+@dev-arch.thelio-3990X>
References: <20221021115956.9947-1-ojeda@kernel.org>
 <20221021115956.9947-2-ojeda@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021115956.9947-2-ojeda@kernel.org>
Precedence: bulk

On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote:
> The attribute was added in GCC 4.8, while the minimum GCC version
> supported by the kernel is GCC 5.1.
> 
> Therefore, remove the check.
> 
> Link: https://godbolt.org/z/84v56vcn8
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  include/linux/compiler-gcc.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index b9530d3515ac..bfce7f4d0978 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -82,11 +82,7 @@
>  #define __noscs __attribute__((__no_sanitize__("shadow-call-stack")))
>  #endif
>  
> -#if __has_attribute(__no_sanitize_address__)
>  #define __no_sanitize_address __attribute__((__no_sanitize_address__))
> -#else
> -#define __no_sanitize_address
> -#endif
>  
>  #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
>  #define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
> -- 
> 2.38.1
> 
>