Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 15:18:05 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        "Robert Richter" <rrichter@amd.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        "Terry Bowman" <terry.bowman@amd.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Ard Biesheuvel <ardb@kernel.org>
Subject: RE: [PATCH 0/2] efi/cper, cxl: Decode CXL Protocol Errors CPER
Message-ID: <63531a9dd51b9_4da32946c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221007211714.71129-1-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221007211714.71129-1-Smita.KoralahalliChannabasappa@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yLprweDNLMh/1ZeCTlcep4oDoXVV1k71mhJcT13m4Rfrs27I+2VDi0o99Mnw?=
 =?us-ascii?Q?5zGpF37UV+ygKBPbxmTEvaaouCp2yyh4knL981imCj2GqJ2sYzMXWiCMp2vu?=
 =?us-ascii?Q?IWO9w7fCAI9l0nS/y7VOvvIu3mWt76QPm5x9FrDZCX9t5eHLuQyMcs/DNTP/?=
 =?us-ascii?Q?7XSoaGCNFIFCdguZaMcknMIf38GFp78915xgIuMZpyy1PnqlVLsxj33PMaOt?=
 =?us-ascii?Q?rIaVTdADnceDeNu2JjVbGhDi0oFWiXY4nePJiqQRD962ezssXZnO7CZJEBhQ?=
 =?us-ascii?Q?bRncqzPr38geCRIZBmX+lAThiu0/aPUAcWmaeytyLJoJQGv5FSwwmRWhnLY7?=
 =?us-ascii?Q?RjKBuToKtlTZ+q3u9Xo7S8myynvlEFw3aC67Y11FnEu09OCYGHKxxNZCEQiv?=
 =?us-ascii?Q?yoWUp9/ksc8PcDZBEqVbNQnKGAwuw6VL1/64bTMhMZmZ38gy0EC8p7J2WPOA?=
 =?us-ascii?Q?GamHBi87/InVhAR7bhhzLiaFzqhnCjB2ZZrIn163LHmk+jYDlFmGpyGhZOQy?=
 =?us-ascii?Q?8NmFObqZa1qlt7lCg/qsY7cmSaIHtV77shKzteavNcq/SoLXDcSxHyPZi4xD?=
 =?us-ascii?Q?oMZjcjz6Wn5Hjyq7GaRKJN1Dg+GKUOvKO7av4JeLxaaIuv0NprTeQSTnszDq?=
 =?us-ascii?Q?Qy0gAOl6OsQi38+JKFKvcuZsS/wN0w7nQ9Yr3bGvuoZZVRcz3mjxHm9feOha?=
 =?us-ascii?Q?62zokUdumMqTQODNEWf8kpGvLBWM3r+s+24H5JNz+dEv1bcBgMRAWx6aeW6h?=
 =?us-ascii?Q?ChELpk2zRby9wnG4hajoCU6O6FrEXcSJZXmM2k4P43WYmnAYgv+4FkBHhR3X?=
 =?us-ascii?Q?i4L1jxHgHSneAr5i/8Rnuj8WCVlQVAcb3a8j6XNPYLNOdA/Ep61PsYzCvKk+?=
 =?us-ascii?Q?vyUgFA3KDtQPSgfmVTnSkVSfvtsq7WP6w877zkKJsOyIQyJEMijCpN4V6kPv?=
 =?us-ascii?Q?zurgLZJedebXmm5dvT+NiMq2rnB5KyrUSa18VDIdz1MV/daP9KMs/f+1tp/v?=
 =?us-ascii?Q?igyAEVlwnzEfkgYwQNewAW3AC2aEo/2Jp+fu1rEZz1E2Shbo65zAZhc2qFmS?=
 =?us-ascii?Q?bjoM39k4p0VkkWuEmZihfYGSiItIk6i5uIolxCoWV3F4bXH+VNPpGHP1r9m7?=
 =?us-ascii?Q?NMHeLciddzd6gSBrebKn5ck2p6wOdVYaO96plUH6JNb5qQZKiRpYM7TxbQnH?=
 =?us-ascii?Q?rKHqhEi5+OfcG5GzqnITHxyOworVIPtdy+2k9MV9i42zVXox13XEkZWYKrk+?=
 =?us-ascii?Q?3Y5P7fvZPwrvuJ4Uc0iP7VeO85Fe2HfwJEUBxnQyNO/HDCWR5DErHLDLhOXs?=
 =?us-ascii?Q?hVbcCqOHL4xPJYiImPsHLhM2+d70zgYiSD/NCb2ON3hxJ2c2m8CZklTq5Wnq?=
 =?us-ascii?Q?LGSejxgrpFOIsPM/0EVpd2w5+zbmSCv3Qj3E6PP1Shvb7LmjfIrDV3c9cL7P?=
 =?us-ascii?Q?QMBtY5YbVRAR2QDkCMA6fL66Ph4jX0Z1+0LXGzDxoQ2hZ0629GlKDkNep/Yc?=
 =?us-ascii?Q?9dJvITc2bDAe7FZU++obD6vzv6hIMXQeyLRxnzg0OdPlfB9KVc3uNj+g3Lxe?=
 =?us-ascii?Q?B0tAIeSTjdzqemYHvPRFArvZtKYrSClMFCKtB9MZb6BTbX7qXpowoSpQenap?=
 =?us-ascii?Q?jg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7209ce-a0a7-405c-6ae4-08dab3b22253
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 22:18:09.0289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2mdfOZWQVdtkoMg5DfGo4rlN+73+BZN8R5vjOkgl4gpiBSQqrVRiDhv/yGC/Br9bVVGu8vT+ErYWgqmS/YUG44C44YHLo5Unkjx51REa9yk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6947
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Smita,

Smita Koralahalli wrote:
> This series adds decoding for the CXL Protocol Errors Common Platform
> Error Record.

Be sure to copy Ard Biesheuvel <ardb@kernel.org>, added, on
drivers/firmware/efi/ patches.

Along those lines, drivers/cxl/ developers have an idea of what is
contained in the new CXL protocol error records and why Linux might want
to decode them, others from outside drivers/cxl/ might not. It always
helps to have a small summary of the benefit to end users of the
motivation to apply a patch set.

> 
> Smita Koralahalli (2):
>   efi/cper, cxl: Decode CXL Protocol Error Section
>   efi/cper, cxl: Decode CXL Error Log
> 
>  drivers/firmware/efi/Makefile   |   2 +-
>  drivers/firmware/efi/cper.c     |   9 +++
>  drivers/firmware/efi/cper_cxl.c | 108 ++++++++++++++++++++++++++++++++
>  drivers/firmware/efi/cper_cxl.h |  58 +++++++++++++++++
>  include/linux/cxl_err.h         |  21 +++++++
>  5 files changed, 197 insertions(+), 1 deletion(-)

I notice no updates for the trace events in ghes_do_proc(), is that next
in your queue? That's ok to be a follow-on after v2.