Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 15:39:41 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>,
        <dan.j.williams@intel.com>
CC:     <terry.bowman@amd.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>,
        <rafael@kernel.org>, <lenb@kernel.org>,
        <Jonathan.Cameron@huawei.com>, <dave@stgolabs.net>,
        <rrichter@amd.com>, <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH 1/5] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1
 support
Message-ID: <63531fad96dcd_6be129496@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221021185615.605233-1-terry.bowman@amd.com>
 <20221021185615.605233-2-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221021185615.605233-2-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wE0P87ZhPSW+XdiXQIdXrlUtvWvicDdc7f1YYf1v6M68yTQcGX+g42288nga?=
 =?us-ascii?Q?iPQY28KSH+huuFZfFDct7ZgTX1DAW6Zy5UmlVx7zE7o0UfgnG/CRkX0xA5on?=
 =?us-ascii?Q?cLWDOkRxDvlpdLVd66Iv8BzHkUoHuUX3SnoNgENVjZlq+yDW3B+Dek5CZqsD?=
 =?us-ascii?Q?GEPLVJlHUTXTf5FRXa/kUKPHN9PTHphQkAeyYb36UsbJm7PTU8jA16rpXyS1?=
 =?us-ascii?Q?jhDPr72loynROGAfsyxTAoVSyFRIMpVWCpPCTiBUdi398UCVNdjySH4bMc5f?=
 =?us-ascii?Q?IjRhZ5oT5FbhglujKqi76IGUx6cDxkuR28YIFiLgiGAklbB97pkuWGQDEiiX?=
 =?us-ascii?Q?Qtx7nGnrWouz5WUvotCeKXVl7T8vUrWnM/WWzRO6lbQwYBiE9U9/aZU6URyi?=
 =?us-ascii?Q?gR8r+kI6JOpcUNe3+kg1hQhEXGaHqLgjoKLKwe/fzuQXPbDiVgV/ZzP9GeOK?=
 =?us-ascii?Q?xcMSrCXb9PoOKRotY7AdMhaQ/G0v8LccMtdoB1iU27UgYI7KfgnvviBcaoSm?=
 =?us-ascii?Q?/q3pfHGi49QHlPGjEptcJDCEqiYGYmJMJNDuBI9yOidqm0Mu/3VIeM3kGzzc?=
 =?us-ascii?Q?q9WBABJYxzELLnncA7P/iNn+km9njrluGlrc+4NBQ6zMaLcDKTirYISlDhr6?=
 =?us-ascii?Q?KOllHc7ofKCGigCNNgnTyHgcBvUZZ8C32dm1D99ogBQk6ymNPCt4ygex/aYS?=
 =?us-ascii?Q?roza0DTdhbu4TR0o5Bdpel1ZOGpxYCliB3k5FfKfq8hSrvJRHurQ3Z9gnVR7?=
 =?us-ascii?Q?xVFbmqUGSR3MGBialQdrSI/lgqSkgpTDbPZTXm5i1up2eK2eUoQL+q9K+9v6?=
 =?us-ascii?Q?omzaSAXJ9AcvtuItyNQE8lBRhGiXCWq7fgf6TiwCvFKsVeTrIYVuzjUXhHsN?=
 =?us-ascii?Q?NEYpDzhwv7xmUcxGzHcGPXKF9y+FkcZedemUK2LjRdKUFGZ3amJcKCv+svZD?=
 =?us-ascii?Q?o5rgdFg3xRfb4p76yAfSkWJ1iKI1zd8C1FOlIEqvZO+LEPfWaU52yb6j+YAJ?=
 =?us-ascii?Q?1h9M4ofD3ZRiakKbyINJdbRMzAlNHhZGzMHA82q+knTkLxacQ8ARLh3iJpQr?=
 =?us-ascii?Q?zFfg5bwgC3ZoXSWyhTdfP5OOwqxfF3EvWrnkNH59kDL61gw36FZCYRGAkbSo?=
 =?us-ascii?Q?VzOFqb9f1qZYkvgMr84frdlXsCkDgah26TRMwBWSzE4Dj1H/hSrToZOHM2w8?=
 =?us-ascii?Q?lzV+AYVCGG9aJcPjBi+2kne1gw79+Q5XeNSPf323iotoXrqmke1Y4ztRB2S3?=
 =?us-ascii?Q?STawUX0JszJbD/SmQJVi7cnxIgsLyvfVQ6QL+YJ8XCjOygGwCfoAMjL7CR1+?=
 =?us-ascii?Q?ULrA+TyIYwRibR0xLcE679pbNrZynShgCpCy0j1TyfiX4aZ1ato53UR0bzu0?=
 =?us-ascii?Q?QuHa/HacATN5vznby6VzI3YMnKzxg7p0RcTdd7K3HpSSb77r3OIt/1HxvxF/?=
 =?us-ascii?Q?hWkra2AywcEsUdIbXN8G+wM+uR37m4iMWcr7V/Oz4z0f5VNSDjOweum5Qzy+?=
 =?us-ascii?Q?V7M4v0R6ZpCc/pg9Ck63iKXpTyt9EU1gRthy3yP5PfKii48DyXRrNAJTy1SK?=
 =?us-ascii?Q?WRMaaTAKBPXxwPmaGVgfczrZ4RH8HNzB8rd58KCmgBaPyCtgtEvsYWNk49OW?=
 =?us-ascii?Q?rQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b8645669-7d30-451a-d501-08dab3b52666
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 22:39:44.2790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nLOpzWoDFK8aRLDDoITY+iZvFYgy75N3xHUdCvHoW1FWnyeR+nKDbr22blSJXiKK8T4SnoUK+0wc2Kttpi0/kVvPxjbUo2NsftUVQ4l4YvI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6784
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> ACPI includes a CXL _OSC support method to communicate the available
> CXL support to FW. The CXL support _OSC includes a field to indicate
> CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
> to RCD and RCH Port registers.[1] FW can potentially change it's operation
> depending on the _OSC support setting reported by the OS.
> 
> The ACPI driver does not currently set the ACPI _OSC support to indicate
> CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
> 
> [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> ---
>  drivers/acpi/pci_root.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index c8385ef54c37..094a59b216ae 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c

Be sure to copy linux-acpi@vger.kernel.org on patches that touch
drivers/acpi/

> @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
>  	u32 support;
>  
>  	support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
> +	support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
>  	if (pci_aer_available())
>  		support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
>  	if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))

This looks good to me though.